[Fusion] Support validate command (#8992)

Author: tobias-tengler

src/Nitro/CommandLine/src/CommandLine.Cloud/Commands/Fusion/FusionValidateCommand.cs

@@ -1,3 +1,4 @@
+using System.IO.Compression;
 using System.Reactive;
 using System.Reactive.Linq;
 using System.Reactive.Subjects;
@@ -6,6 +7,7 @@
 using ChilliCream.Nitro.CommandLine.Cloud.Option;
 using ChilliCream.Nitro.CommandLine.Cloud.Option.Binders;
 using ChilliCream.Nitro.CommandLine.Fusion.Compatibility;
+using HotChocolate.Fusion.Packaging;
 using StrawberryShake;
 using static ChilliCream.Nitro.CommandLine.Cloud.ThrowHelper;
 
@@ -15,9 +17,7 @@ internal sealed class FusionValidateCommand : Command
 {
     public FusionValidateCommand() : base("validate")
     {
-        Description = "Validates a fusion configuration against a stage."
-            + System.Environment.NewLine
-            + "This only works for Fusion v1 at the moment.";
+        Description = "Validates the composed GraphQL schema of a fusion configuration against a stage.";
 
         AddOption(Opt<StageNameOption>.Instance);
         AddOption(Opt<ApiIdOption>.Instance);
@@ -42,7 +42,7 @@ private static async Task<int> ExecuteAsync(
         FileInfo configFile,
         CancellationToken ct)
     {
-        console.Title($"Validate to {stage.EscapeMarkup()}");
+        console.Title($"Validate against {stage.EscapeMarkup()}");
 
         var isValid = false;
 
@@ -63,13 +63,29 @@ await console
 
         async Task ValidateSchema(StatusContext? ctx)
         {
-            console.Log("Initialized");
             console.Log($"Reading file [blue]{configFile.FullName.EscapeMarkup()}[/]");
 
-            var stream = FileHelpers.CreateFileStream(configFile);
+            await using var stream = FileHelpers.CreateFileStream(configFile);
 
-            await using var package = FusionGraphPackage.Open(stream, FileAccess.Read);
-            var schemaStream = await LoadSchemaFile(package, ct);
+            Stream schemaStream;
+            IDisposable disposableArchive;
+
+            if (IsFarFormat(stream))
+            {
+                var archive = FusionArchive.Open(stream, leaveOpen: true);
+
+                schemaStream = await LoadSchemaFile(archive, ct);
+
+                disposableArchive = archive;
+            }
+            else
+            {
+                var package = FusionGraphPackage.Open(stream, FileAccess.Read);
+
+                schemaStream = await LoadSchemaFile(package, ct);
+
+                disposableArchive = package;
+            }
 
             var input = new ValidateSchemaInput
             {
@@ -80,50 +96,60 @@ async Task ValidateSchema(StatusContext? ctx)
 
             console.Log("Create validation request");
 
-            var requestId = await ValidateAsync(console, client, input, ct);
+            try
+            {
+                var requestId = await ValidateAsync(console, client, input, ct);
 
-            console.Log($"Validation request created [grey](ID: {requestId.EscapeMarkup()})[/]");
+                disposableArchive.Dispose();
 
-            using var stopSignal = new Subject<Unit>();
+                console.Log($"Validation request created [grey](ID: {requestId.EscapeMarkup()})[/]");
 
-            var subscription = client.OnSchemaVersionValidationUpdated
-                .Watch(requestId, ExecutionStrategy.NetworkOnly)
-                .TakeUntil(stopSignal);
+                using var stopSignal = new Subject<Unit>();
 
-            await foreach (var x in subscription.ToAsyncEnumerable().WithCancellation(ct))
-            {
-                if (x.Errors is { Count: > 0 } errors)
-                {
-                    console.PrintErrorsAndExit(errors);
-                    throw Exit("No request id returned");
-                }
+                var subscription = client.OnSchemaVersionValidationUpdated
+                    .Watch(requestId, ExecutionStrategy.NetworkOnly)
+                    .TakeUntil(stopSignal);
 
-                switch (x.Data?.OnSchemaVersionValidationUpdate)
+                await foreach (var x in subscription.ToAsyncEnumerable().WithCancellation(ct))
                 {
-                    case ISchemaVersionValidationFailed { Errors: var schemaErrors }:
-                        console.Error.WriteLine("The schema is invalid:");
-                        console.PrintErrorsAndExit(schemaErrors);
-                        stopSignal.OnNext(Unit.Default);
-                        break;
-
-                    case ISchemaVersionValidationSuccess:
-                        isValid = true;
-                        stopSignal.OnNext(Unit.Default);
-
-                        console.Success("Schema validation succeeded.");
-                        break;
-
-                    case IOperationInProgress:
-                    case IValidationInProgress:
-                        ctx?.Status("The validation is in progress.");
-                        break;
-
-                    default:
-                        ctx?.Status(
-                            "This is an unknown response, upgrade Nitro CLI to the latest version.");
-                        break;
+                    if (x.Errors is { Count: > 0 } errors)
+                    {
+                        console.PrintErrorsAndExit(errors);
+                        throw Exit("No request id returned");
+                    }
+
+                    switch (x.Data?.OnSchemaVersionValidationUpdate)
+                    {
+                        case ISchemaVersionValidationFailed { Errors: var schemaErrors }:
+                            console.Error.WriteLine("The schema is invalid:");
+                            console.PrintErrorsAndExit(schemaErrors);
+                            stopSignal.OnNext(Unit.Default);
+                            break;
+
+                        case ISchemaVersionValidationSuccess:
+                            isValid = true;
+                            stopSignal.OnNext(Unit.Default);
+
+                            console.Success("Schema validation succeeded.");
+                            break;
+
+                        case IOperationInProgress:
+                        case IValidationInProgress:
+                            ctx?.Status("The validation is in progress.");
+                            break;
+
+                        default:
+                            ctx?.Status(
+                                "This is an unknown response, upgrade Nitro CLI to the latest version.");
+                            break;
+                    }
                 }
             }
+            finally
+            {
+                disposableArchive.Dispose();
+                await schemaStream.DisposeAsync();
+            }
         }
     }
 
@@ -147,18 +173,45 @@ private static async Task<string> ValidateAsync(
         return data.ValidateSchema.Id;
     }
 
-    private static async Task<MemoryStream> LoadSchemaFile(
-        FusionGraphPackage package,
-        CancellationToken ct)
+    private static async Task<Stream> LoadSchemaFile(FusionArchive archive, CancellationToken ct)
+    {
+        var latestVersion = await archive.GetLatestSupportedGatewayFormatAsync(ct);
+        var configuration = await archive.TryGetGatewayConfigurationAsync(latestVersion, ct);
+
+        if (configuration is null)
+        {
+            throw new InvalidOperationException(
+                $"Failed to retrieve gateway configuration from the fusion archive (format version: {latestVersion}). "
+                + $"The archive may be corrupted, unsupported, or missing required configuration.");
+        }
+
+        return await configuration.OpenReadSchemaAsync(ct);
+    }
+
+    private static async Task<Stream> LoadSchemaFile(FusionGraphPackage package, CancellationToken ct)
     {
         var schemaNode = await package.GetSchemaAsync(ct);
 
         var schemaFileStream = new MemoryStream();
         await using var streamWriter = new StreamWriter(schemaFileStream, leaveOpen: true);
         await streamWriter.WriteAsync(schemaNode.ToString());
-        streamWriter.Flush();
+        await streamWriter.FlushAsync(ct);
         schemaFileStream.Position = 0;
 
         return schemaFileStream;
     }
+
+    public static bool IsFarFormat(Stream stream)
+    {
+        try
+        {
+            using var zip = new ZipArchive(stream, ZipArchiveMode.Read, leaveOpen: true);
+
+            return zip.GetEntry("archive-metadata.json") is not null;
+        }
+        catch
+        {
+            return false;
+        }
+    }
 }

src/Nitro/CommandLine/src/CommandLine.Cloud/Commands/Stages/EditStagesCommand.cs

@@ -44,7 +44,7 @@ CancellationToken cancellationToken
     {
         console.WriteOperationTitle();
 
-        const string apiMessage = "For which api do you want to create a client?";
+        const string apiMessage = "For which api do you want to edit the stages?";
 
         var apiId = await context.GetOrSelectApiId(apiMessage);