Updated code to use collection expressions (#8336)

Author: glen-84

.editorconfig

@@ -166,8 +166,25 @@ dotnet_diagnostic.CA1511.severity = warning
 dotnet_diagnostic.CA1512.severity = warning
 # Use ObjectDisposedException throw helper.
 dotnet_diagnostic.CA1513.severity = warning
+# Use collection initializers or expressions.
+dotnet_diagnostic.IDE0028.severity = warning
 # Use range operator.
 dotnet_diagnostic.IDE0057.severity = warning
+# Use collection expression for array.
+dotnet_diagnostic.IDE0300.severity = warning
+# Use collection expression for empty.
+dotnet_diagnostic.IDE0301.severity = warning
+# Use collection expression for stackalloc.
+dotnet_diagnostic.IDE0302.severity = warning
+# Use collection expression for Create().
+dotnet_diagnostic.IDE0303.severity = warning
+# Use collection expression for builder.
+dotnet_diagnostic.IDE0304.severity = warning
+# Use collection expression for fluent.
+dotnet_diagnostic.IDE0305.severity = silent # see https://github.com/dotnet/roslyn/issues/70833
+# Use collection expression for new.
+dotnet_diagnostic.IDE0306.severity = warning
+dotnet_style_prefer_collection_expression = when_types_exactly_match
 # Add/remove trailing comma.
 dotnet_diagnostic.RCS1260.severity = warning
 roslynator_trailing_comma_style = omit

src/CookieCrumble/src/CookieCrumble/Formatters/JsonSnapshotValueFormatter.cs

@@ -17,7 +17,7 @@ internal sealed class JsonSnapshotValueFormatter : ISnapshotValueFormatter, IMar
             DateFormatHandling = DateFormatHandling.IsoDateFormat,
             Culture = CultureInfo.InvariantCulture,
             ContractResolver = ChildFirstContractResolver.Instance,
-            Converters = new List<JsonConverter> { new StringEnumConverter() }
+            Converters = [new StringEnumConverter()]
         };
 
     public bool CanHandle(object? value)

src/GreenDonut/src/GreenDonut.Data.EntityFramework/Expressions/ExpressionHelpers.cs

@@ -370,8 +370,8 @@ public readonly struct OrderRewriterResult(
 
     private sealed class OrderByRemovalRewriter : ExpressionVisitor
     {
-        private readonly List<LambdaExpression> _orderExpressions = new();
-        private readonly List<string> _orderMethods = new();
+        private readonly List<LambdaExpression> _orderExpressions = [];
+        private readonly List<string> _orderMethods = [];
         private bool _insideSelectProjection;
 
         public (Expression, List<LambdaExpression>, List<string>) Rewrite(Expression expression)

src/GreenDonut/src/GreenDonut.Data.Primitives/Page.cs

@@ -159,7 +159,7 @@ public string CreateCursor(T item, int offset)
     /// <summary>
     /// An empty page.
     /// </summary>
-    public static Page<T> Empty => new(ImmutableArray<T>.Empty, false, false, _ => string.Empty);
+    public static Page<T> Empty => new([], false, false, _ => string.Empty);
 
     /// <summary>
     /// Gets the enumerator for the items of this page.

src/GreenDonut/src/GreenDonut.Data/Cursors/CursorKeyParser.cs

@@ -8,7 +8,7 @@ namespace GreenDonut.Data.Cursors;
 /// </summary>
 public sealed class CursorKeyParser : ExpressionVisitor
 {
-    private readonly List<CursorKey> _keys = new();
+    private readonly List<CursorKey> _keys = [];
 
     public IReadOnlyList<CursorKey> Keys => _keys;
 

src/GreenDonut/src/GreenDonut.Data/DefaultPredicateBuilder.cs

@@ -9,7 +9,7 @@ namespace GreenDonut.Data;
 /// </summary>
 public sealed class DefaultPredicateBuilder : IPredicateBuilder
 {
-    private ImmutableArray<LambdaExpression> _predicates = ImmutableArray<LambdaExpression>.Empty;
+    private ImmutableArray<LambdaExpression> _predicates = [];
 
     /// <summary>
     /// Initializes a new instance of <see cref="DefaultPredicateBuilder"/>.
@@ -82,5 +82,5 @@ public DefaultPredicateBuilder Branch()
     /// <summary>
     /// Gets an empty <see cref="DefaultPredicateBuilder"/>.
     /// </summary>
-    public static DefaultPredicateBuilder Empty { get; } = new(ImmutableArray<LambdaExpression>.Empty);
+    public static DefaultPredicateBuilder Empty { get; } = new([]);
 }

src/GreenDonut/src/GreenDonut.Data/DefaultSelectorBuilder.cs

@@ -9,7 +9,7 @@ namespace GreenDonut.Data;
 /// </summary>
 public sealed class DefaultSelectorBuilder : ISelectorBuilder
 {
-    private ImmutableArray<LambdaExpression> _selectors = ImmutableArray<LambdaExpression>.Empty;
+    private ImmutableArray<LambdaExpression> _selectors = [];
 
     /// <summary>
     /// Initializes a new instance of <see cref="DefaultSelectorBuilder"/>.
@@ -82,5 +82,5 @@ public DefaultSelectorBuilder Branch()
     /// <summary>
     /// Gets an empty <see cref="DefaultSelectorBuilder"/>.
     /// </summary>
-    public static DefaultSelectorBuilder Empty { get; } = new(ImmutableArray<LambdaExpression>.Empty);
+    public static DefaultSelectorBuilder Empty { get; } = new([]);
 }

src/GreenDonut/src/GreenDonut/Batch.cs

@@ -3,7 +3,7 @@ namespace GreenDonut;
 internal class Batch<TKey> where TKey : notnull
 {
     private readonly List<TKey> _keys = [];
-    private readonly Dictionary<TKey, IPromise> _items = new();
+    private readonly Dictionary<TKey, IPromise> _items = [];
 
     public bool IsScheduled { get; set; }
 

src/GreenDonut/src/GreenDonut/PromiseCache.cs

@@ -13,7 +13,7 @@ public sealed class PromiseCache : IPromiseCache
     private readonly object _sync = new();
     private readonly ConcurrentDictionary<PromiseCacheKey, Entry> _map = new();
     private readonly ConcurrentDictionary<Type, ImmutableArray<Subscription>> _subscriptions = new();
-    private readonly List<IPromise> _promises = new();
+    private readonly List<IPromise> _promises = [];
     private readonly int _size;
     private readonly int _order;
     private List<(PromiseCacheKey? Key, IPromise Promise)>? _buffer;
@@ -233,7 +233,7 @@ public IDisposable Subscribe<T>(
 
         _subscriptions.AddOrUpdate(
             type,
-            _ => ImmutableArray.Create<Subscription>(subscription),
+            _ => [subscription],
             (_, list) => list.Add(subscription));
 
         lock (_promises)
@@ -463,7 +463,7 @@ public void Dispose()
             {
                 subscriptions.AddOrUpdate(
                     type,
-                    _ => ImmutableArray.Create(this),
+                    _ => [this],
                     (_, list) => list.Remove(this));
 
                 _disposed = true;

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/CapturePagingQueryInterceptor.cs

@@ -4,7 +4,7 @@ namespace GreenDonut.Data;
 
 public sealed class CapturePagingQueryInterceptor : PagingQueryInterceptor
 {
-    public List<QueryInfo> Queries { get; } = new();
+    public List<QueryInfo> Queries { get; } = [];
 
     public override void OnBeforeExecute<T>(IQueryable<T> query)
     {