Updated code to remove unnecessary null-forgiving operator usage (#8341)

Author: glen-84

.editorconfig

@@ -185,6 +185,8 @@ dotnet_diagnostic.IDE0305.severity = silent # see https://github.com/dotnet/rosl
 # Use collection expression for new.
 dotnet_diagnostic.IDE0306.severity = warning
 dotnet_style_prefer_collection_expression = when_types_exactly_match
+# Unnecessary null-forgiving operator.
+dotnet_diagnostic.RCS1249.severity = warning
 # Remove unnecessary braces.
 dotnet_diagnostic.RCS1251.severity = warning
 # Add/remove trailing comma.

src/CookieCrumble/src/CookieCrumble/Formatters/JsonSnapshotValueFormatter.cs

@@ -54,7 +54,7 @@ protected override IList<JsonProperty> CreateProperties(
                 return 1000 - d.Count;
             }).ToList();
 
-            return properties!;
+            return properties;
         }
     }
 }

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/Brand.cs

@@ -11,7 +11,7 @@ public class Brand
     [Required]
     public string Name { get; set; } = default!;
 
-    public string? DisplayName { get; set; } = default!;
+    public string? DisplayName { get; set; }
 
     public string? AlwaysNull { get; set; }
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/EntitiesResolverTests.cs

@@ -384,7 +384,7 @@ public class FederatedTypeWithOptionalDetail
     {
         public string Id { get; set; } = default!;
 
-        public FederatedTypeDetail? Detail { get; set; } = default!;
+        public FederatedTypeDetail? Detail { get; set; }
 
         [ReferenceResolver]
         public static FederatedTypeWithOptionalDetail ReferenceResolver([Map("detail.id")] string detailId)

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/ReferenceResolverAttributeTests.cs

@@ -236,9 +236,9 @@ public async Task InClassRefResolver_WithGuid()
         var entity = await inClassResolverDelegate.Invoke(context);
 
         if (entity is not null &&
-            type!.Features.TryGet(out ExternalSetter? externalSetter))
+            type.Features.TryGet(out ExternalSetter? externalSetter))
         {
-            externalSetter.Invoke(type, representation!, entity);
+            externalSetter.Invoke(type, representation, entity);
         }
 
         return entity;

src/HotChocolate/AspNetCore/test/AspNetCore.Tests.Utilities/ClientQueryResult.cs

@@ -4,7 +4,7 @@ namespace HotChocolate.AspNetCore.Tests.Utilities;
 
 public sealed class ClientQueryResult
 {
-    public string? ContentType { get; set; } = default!;
+    public string? ContentType { get; set; }
     public HttpStatusCode StatusCode { get; set; }
     public Dictionary<string, object?>? Data { get; set; }
     public List<Dictionary<string, object?>>? Errors { get; set; }

src/HotChocolate/AzureFunctions/test/HotChocolate.AzureFunctions.IsolatedProcess.Tests/IsolatedProcessEndToEndTests.cs

@@ -41,7 +41,7 @@ public async Task AzFuncIsolatedProcess_EndToEndTestAsync()
         var resultContent = await ReadResponseAsStringAsync(response);
         Assert.False(string.IsNullOrWhiteSpace(resultContent));
 
-        dynamic json = JObject.Parse(resultContent!);
+        dynamic json = JObject.Parse(resultContent);
         Assert.Null(json.errors);
         Assert.Equal("Luke Skywalker",json.data.person.ToString());
     }
@@ -90,7 +90,7 @@ public async Task AzFuncIsolatedProcess_FunctionsContextItemsTestAsync()
         var resultContent = await ReadResponseAsStringAsync(response);
         Assert.False(string.IsNullOrWhiteSpace(resultContent));
 
-        dynamic json = JObject.Parse(resultContent!);
+        dynamic json = JObject.Parse(resultContent);
         Assert.Null(json.errors);
         Assert.Equal("Darth Vader", json.data.person.ToString());
     }
@@ -119,7 +119,7 @@ public async Task AzFuncIsolatedProcess_NitroTestAsync()
         var resultContent = await ReadResponseAsStringAsync(httpResponseData);
         Assert.NotNull(resultContent);
         Assert.False(string.IsNullOrWhiteSpace(resultContent));
-        Assert.True(resultContent!.Contains("<html") && resultContent.Contains("</html>"));
+        Assert.True(resultContent.Contains("<html") && resultContent.Contains("</html>"));
     }
 
     private static Task<string> ReadResponseAsStringAsync(HttpResponseData responseData)

src/HotChocolate/AzureFunctions/test/HotChocolate.AzureFunctions.Tests/InProcessEndToEndTests.cs

@@ -34,7 +34,7 @@ public async Task AzFuncInProcess_EndToEndTestAsync()
         var resultContent = await httpContext.ReadResponseContentAsync();
         Assert.False(string.IsNullOrWhiteSpace(resultContent));
 
-        dynamic json = JObject.Parse(resultContent!);
+        dynamic json = JObject.Parse(resultContent);
         Assert.Null(json.errors);
         Assert.Equal("Luke Skywalker",json.data.person.ToString());
     }
@@ -67,6 +67,6 @@ public async Task AzFuncInProcess_NitroTestAsync()
         var resultContent = await httpContext.ReadResponseContentAsync();
         Assert.NotNull(resultContent);
         Assert.False(string.IsNullOrWhiteSpace(resultContent));
-        Assert.True(resultContent!.Contains("<html") && resultContent.Contains("</html>"));
+        Assert.True(resultContent.Contains("<html") && resultContent.Contains("</html>"));
     }
 }

src/HotChocolate/Core/src/Execution.Abstractions/Execution/OperationDocumentId.cs

@@ -175,7 +175,7 @@ public static bool IsValidId(string operationId)
                 return false;
             }
 
-            start = ref Unsafe.Add(ref start, 1)!;
+            start = ref Unsafe.Add(ref start, 1);
         }
 
         return true;

src/HotChocolate/Core/src/Features/FeatureReferences.cs

@@ -103,7 +103,7 @@ public void Initialize(IFeatureCollection collection, int revision)
             flush = true;
         }
 
-        return cached ?? UpdateCached(ref cached!, state, factory, revision, flush);
+        return cached ?? UpdateCached(ref cached, state, factory, revision, flush);
     }
 
     // Update and cache clearing logic, when the fast-path in Fetch isn't applicable