Marked local variables as constants (where applicable) (#8421)

Author: glen-84

.editorconfig

@@ -244,6 +244,8 @@ dotnet_diagnostic.RCS0063.severity = warning
 dotnet_diagnostic.RCS1036.severity = none # see https://github.com/dotnet/roslynator/issues/1632
 # Remove redundant 'ToString' call.
 dotnet_diagnostic.RCS1097.severity = warning
+# Mark local variable as const.
+dotnet_diagnostic.RCS1118.severity = warning
 # Abstract type should not have public constructors.
 dotnet_diagnostic.RCS1160.severity = warning
 # Use constant instead of field.

src/GreenDonut/test/GreenDonut.Data.Tests/Cursors/CursorKeySerializerHelperTests.cs

@@ -38,7 +38,7 @@ public static void Parse_NoColons_ReturnsParsedValue()
     {
         // arrange
         var formattedKey = "testvalue"u8.ToArray();
-        var expectedValue = "testvalue";
+        const string expectedValue = "testvalue";
 
         // act
         var result = CursorKeySerializerHelper.Parse(formattedKey, s_serializer);
@@ -52,7 +52,7 @@ public static void Parse_WithEscapedColons_ReturnsParsedValue()
     {
         // arrange
         var formattedKey = "part1\\:part2"u8.ToArray();
-        var expectedValue = "part1:part2";
+        const string expectedValue = "part1:part2";
 
         // act
         var result = CursorKeySerializerHelper.Parse(formattedKey, s_serializer);

src/GreenDonut/test/GreenDonut.Tests/DataLoaderExtensionsTests.cs

@@ -8,8 +8,8 @@ public class DataLoaderExtensionsTests
     public void SetCacheEntryDataLoaderNull()
     {
         // arrange
-        var key = "Foo";
-        var value = "Bar";
+        const string key = "Foo";
+        const string value = "Bar";
 
         // act
         void Verify() => default(IDataLoader<string, string>)!.SetCacheEntry(key, value);
@@ -25,7 +25,7 @@ public void SetCacheEntryKeyNull()
         var fetch = TestHelpers.CreateFetch<string, string>();
         var batchScheduler = new ManualBatchScheduler();
         var loader = new DataLoader<string, string>(fetch, batchScheduler, new DataLoaderOptions());
-        var value = "Bar";
+        const string value = "Bar";
 
         // act
         void Verify() => loader.SetCacheEntry(null!, value);
@@ -41,7 +41,7 @@ public void SetCacheEntryNoException()
         var fetch = TestHelpers.CreateFetch<string, string>();
         var batchScheduler = new ManualBatchScheduler();
         var loader = new DataLoader<string, string>(fetch, batchScheduler, new DataLoaderOptions());
-        var key = "Foo";
+        const string key = "Foo";
 
         // act
         void Verify() => loader.SetCacheEntry(key, null!);

src/GreenDonut/test/GreenDonut.Tests/DataLoaderTests.cs

@@ -71,7 +71,7 @@ public async Task LoadSingleResult()
         var fetch = CreateFetch<string, string>("Bar");
         var batchScheduler = new ManualBatchScheduler();
         var loader = new DataLoader<string, string>(fetch, batchScheduler, new DataLoaderOptions());
-        var key = "Foo";
+        const string key = "Foo";
 
         // act
         var loadResult = loader.LoadAsync(key);
@@ -89,7 +89,7 @@ public async Task LoadSingleResultTwice()
         var fetch = CreateFetch<string, string>("Bar");
         var batchScheduler = new DelayDispatcher();
         var loader = new DataLoader<string, string>(fetch, batchScheduler, new DataLoaderOptions());
-        var key = "Foo";
+        const string key = "Foo";
 
         // first load.
         (await loader.LoadAsync(key)).MatchSnapshot();
@@ -111,7 +111,7 @@ public async Task LoadSingleResultNoCache()
             fetch,
             batchScheduler,
             new DataLoaderOptions());
-        var key = "Foo";
+        const string key = "Foo";
 
         // act
         var loadResult = loader.LoadAsync(key);
@@ -129,7 +129,7 @@ public async Task LoadSingleErrorResult()
         var fetch = CreateFetch<string, string>();
         var batchScheduler = new ManualBatchScheduler();
         var loader = new DataLoader<string, string>(fetch, batchScheduler, new DataLoaderOptions());
-        var key = "Foo";
+        const string key = "Foo";
 
         // act
         Task<string?> Verify() => loader.LoadAsync(key, CancellationToken.None);
@@ -527,7 +527,7 @@ public void RemoveCacheEntryNoException()
         var fetch = CreateFetch<string, string>();
         var batchScheduler = new ManualBatchScheduler();
         var loader = new DataLoader<string, string>(fetch, batchScheduler, new DataLoaderOptions());
-        var key = "Foo";
+        const string key = "Foo";
 
         // act
         void Verify() => loader.RemoveCacheEntry(key);
@@ -545,7 +545,7 @@ public void RemoveCacheEntry()
         var cache = new PromiseCache(10);
         var options = new DataLoaderOptions { Cache = cache };
         var loader = new DataLoader<string, string>(fetch, batchScheduler, options);
-        var key = "Foo";
+        const string key = "Foo";
 
         loader.SetCacheEntry(key, Task.FromResult<string?>("Bar"));
 
@@ -597,7 +597,7 @@ public void SetCacheEntry()
         var cache = new PromiseCache(10);
         var options = new DataLoaderOptions { Cache = cache };
         var loader = new DataLoader<string, string>(fetch, batchScheduler, options);
-        var key = "Foo";
+        const string key = "Foo";
         var value = Task.FromResult<string?>("Bar");
 
         // act
@@ -616,7 +616,7 @@ public void SetCacheEntryTwice()
         var cache = new PromiseCache(10);
         var options = new DataLoaderOptions { Cache = cache };
         var loader = new DataLoader<string, string>(fetch, batchScheduler, options);
-        var key = "Foo";
+        const string key = "Foo";
         var first = Task.FromResult<string?>("Bar");
         var second = Task.FromResult<string?>("Baz");
 

src/GreenDonut/test/GreenDonut.Tests/PromiseCacheTests.cs

@@ -8,7 +8,7 @@ public class PromiseCacheTests
     public void ConstructorNoException()
     {
         // arrange
-        var cacheSize = 1;
+        const int cacheSize = 1;
 
         // act
         // ReSharper disable once ObjectCreationAsStatement
@@ -45,7 +45,7 @@ public void Size(int cacheSize, int expectedCacheSize)
     public void Usage(string[] values, int expectedUsage)
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
 
         foreach (var value in values)
@@ -64,7 +64,7 @@ public void Usage(string[] values, int expectedUsage)
     public void ClearNoException()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
 
         // act
@@ -78,7 +78,7 @@ public void ClearNoException()
     public void ClearEmptyCache()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
 
         // act
@@ -92,7 +92,7 @@ public void ClearEmptyCache()
     public void ClearAllEntries()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
 
         cache.TryAdd(new PromiseCacheKey("a", "Foo"), new Promise<string>("Bar"));
@@ -109,9 +109,9 @@ public void ClearAllEntries()
     public void RemoveNoException()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
-        var key = "Foo";
+        const string key = "Foo";
 
         // act
         bool Verify() => cache.TryRemove(new("a", key));
@@ -124,7 +124,7 @@ public void RemoveNoException()
     public void RemoveEntry()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
         var key = new PromiseCacheKey("a", "Foo");
         var value = Task.FromResult("Bar");
@@ -143,7 +143,7 @@ public void RemoveEntry()
     public void TryAddValueNull()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
         var key = new PromiseCacheKey("a", "Foo");
 
@@ -158,7 +158,7 @@ public void TryAddValueNull()
     public void TryAddNewCacheEntry()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
         var key = new PromiseCacheKey("a", "Foo");
         var expected = new Promise<string>("Bar");
@@ -177,7 +177,7 @@ public void TryAddNewCacheEntry()
     public void TryAddNewCacheEntryWithFactory()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
         var key = new PromiseCacheKey("a", "Foo");
         var expected = new Promise<string>(Task.FromResult("Bar"));
@@ -196,7 +196,7 @@ public void TryAddNewCacheEntryWithFactory()
     public void TryAddTwice()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
         var key = new PromiseCacheKey("a", "Foo");
         var expected = Task.FromResult("Bar");
@@ -218,7 +218,7 @@ public void TryAddTwice()
     public async Task GetOrAddTaskWhenNothingIsCached()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
         var key = new PromiseCacheKey("a", "Foo");
 
@@ -233,7 +233,7 @@ public async Task GetOrAddTaskWhenNothingIsCached()
     public async Task GetOrAddTaskWhenNothingIsCached_IntegerKey()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var cache = new PromiseCache(cacheSize);
         var key = new PromiseCacheKey("a", 1);
 
@@ -248,7 +248,7 @@ public async Task GetOrAddTaskWhenNothingIsCached_IntegerKey()
     public async Task GetOrAddTask_When_SecondLevelEntry_Exists()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var secondLevel = new SecondLevelCache();
         var cache = new PromiseCache(cacheSize) { Interceptor = secondLevel };
         var key = new PromiseCacheKey("abc", "abc");
@@ -264,7 +264,7 @@ public async Task GetOrAddTask_When_SecondLevelEntry_Exists()
     public async Task GetOrAddTask_When_SecondLevelEntry_Not_Exists()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var secondLevel = new SecondLevelCache();
         var cache = new PromiseCache(cacheSize) { Interceptor = secondLevel };
         var key = new PromiseCacheKey("abc", "123");
@@ -281,7 +281,7 @@ public async Task GetOrAddTask_When_SecondLevelEntry_Not_Exists()
     public async Task TryAddTask_To_SecondLevelCache_1()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var secondLevel = new SecondLevelCache();
         var cache = new PromiseCache(cacheSize) { Interceptor = secondLevel };
         var key = new PromiseCacheKey("abc", "123");
@@ -298,7 +298,7 @@ public async Task TryAddTask_To_SecondLevelCache_1()
     public async Task TryAddTask_To_SecondLevelCache_2()
     {
         // arrange
-        var cacheSize = 10;
+        const int cacheSize = 10;
         var secondLevel = new SecondLevelCache();
         var cache = new PromiseCache(cacheSize) { Interceptor = secondLevel };
         var key = new PromiseCacheKey("abc", "123");

src/GreenDonut/test/GreenDonut.Tests/ResultTests.cs

@@ -141,7 +141,7 @@ public void GetHashCodeEmpty()
     public void GetHashCodeValue()
     {
         // arrange
-        var value = "Foo";
+        const string value = "Foo";
 
         // act
         Result<string> result1 = value;
@@ -182,7 +182,7 @@ public void ImplicitRejectErrorIsNull()
     public void ImplicitReject()
     {
         // arrange
-        var errorMessage = "Foo";
+        const string errorMessage = "Foo";
         var error = new Exception(errorMessage);
 
         // act
@@ -198,7 +198,7 @@ public void ImplicitReject()
     public void ExplicitReject()
     {
         // arrange
-        var errorMessage = "Foo";
+        const string errorMessage = "Foo";
         var error = new Exception(errorMessage);
 
         // act

src/HotChocolate/AspNetCore/test/AspNetCore.Tests/CostTests.cs

@@ -19,7 +19,7 @@ public async Task Request_No_Cost_Header()
 
         var uri = new Uri("http://localhost:5000/graphql");
 
-        var requestBody =
+        const string requestBody =
             """
             {
                 "query" : "query Test($id: String!){human(id: $id){name}}"
@@ -48,7 +48,7 @@ public async Task Request_Report_Cost_Header()
 
         var uri = new Uri("http://localhost:5000/graphql");
 
-        var requestBody =
+        const string requestBody =
             """
             {
                 "query" : "query Test($id: String!){human(id: $id){name}}"
@@ -78,7 +78,7 @@ public async Task Request_Validate_Cost_Header()
 
         var uri = new Uri("http://localhost:5000/graphql");
 
-        var requestBody =
+        const string requestBody =
             """
             {
                 "query" : "query Test($id: String!){human(id: $id){name}}"
@@ -111,7 +111,7 @@ public async Task Cost_Exceeded_With_Cost_Override()
 
         var uri = new Uri("http://localhost:5000/graphql");
 
-        var requestBody =
+        const string requestBody =
             """
             {
                 "query" : "query Test($id: String!){human(id: $id){name}}"