Generate Files in Parallel (#8882)

michaelstaib · web-flow · commit f3a4b80d9fcf · 2025-11-10T10:23:47.000+01:00
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/DataLoaderFileBuilder.cs b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/DataLoaderFileBuilder.cs
@@ -4,7 +4,6 @@
 using HotChocolate.Types.Analyzers.Inspectors;
 using HotChocolate.Types.Analyzers.Models;
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.Text;
 using static HotChocolate.Types.Analyzers.Helpers.GeneratorUtils;
 
 namespace HotChocolate.Types.Analyzers.FileBuilders;
@@ -678,9 +677,6 @@ private static ITypeSymbol ExtractMapType(ITypeSymbol returnType)
     public override string ToString()
         => _sb.ToString();
 
-    public SourceText ToSourceText()
-        => SourceText.From(ToString(), Encoding.UTF8);
-
     public void Dispose()
     {
         if (_disposed)
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/DataLoaderModuleFileBuilder.cs b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/DataLoaderModuleFileBuilder.cs
@@ -1,6 +1,5 @@
 using System.Text;
 using HotChocolate.Types.Analyzers.Helpers;
-using Microsoft.CodeAnalysis.Text;
 
 namespace HotChocolate.Types.Analyzers.FileBuilders;
 
@@ -118,9 +117,6 @@ public void WriteAddDataLoaderGroup(string groupType, string groupInterfaceType)
     public override string ToString()
         => _sb.ToString();
 
-    public SourceText ToSourceText()
-        => SourceText.From(ToString(), Encoding.UTF8);
-
     public void Dispose()
     {
         if (_disposed)
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ModuleFileBuilder.cs b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ModuleFileBuilder.cs
@@ -1,7 +1,6 @@
 using System.Text;
 using HotChocolate.Types.Analyzers.Helpers;
 using HotChocolate.Types.Analyzers.Models;
-using Microsoft.CodeAnalysis.Text;
 
 namespace HotChocolate.Types.Analyzers.FileBuilders;
 
@@ -166,9 +165,6 @@ public void WriteTryAddOperationType(OperationType type)
     public override string ToString()
         => _sb.ToString();
 
-    public SourceText ToSourceText()
-        => SourceText.From(ToString(), Encoding.UTF8);
-
     public void Dispose()
     {
         if (_disposed)
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/OperationFieldFileBuilder.cs b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/OperationFieldFileBuilder.cs
@@ -1,7 +1,6 @@
 using System.Text;
 using HotChocolate.Types.Analyzers.Helpers;
 using HotChocolate.Types.Analyzers.Models;
-using Microsoft.CodeAnalysis.Text;
 
 namespace HotChocolate.Types.Analyzers.FileBuilders;
 
@@ -115,9 +114,6 @@ private static string GetOperationConstant(OperationType type)
     public override string ToString()
         => _sb.ToString();
 
-    public SourceText ToSourceText()
-        => SourceText.From(ToString(), Encoding.UTF8);
-
     public void Dispose()
     {
         if (_disposed)
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/RequestMiddlewareFileBuilder.cs b/src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/RequestMiddlewareFileBuilder.cs
@@ -1,7 +1,6 @@
 using System.Text;
 using HotChocolate.Types.Analyzers.Helpers;
 using HotChocolate.Types.Analyzers.Models;
-using Microsoft.CodeAnalysis.Text;
 using static HotChocolate.Types.Analyzers.WellKnownTypes;
 
 namespace HotChocolate.Types.Analyzers.FileBuilders;
@@ -282,9 +281,6 @@ public void WriteInterceptMethod(
     public override string ToString()
         => _sb.ToString();
 
-    public SourceText ToSourceText()
-        => SourceText.From(ToString(), Encoding.UTF8);
-
     public void Dispose()
     {
         if (_disposed)
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/Generators/DataLoaderGenerator.cs b/src/HotChocolate/Core/src/Types.Analyzers/Generators/DataLoaderGenerator.cs
@@ -4,7 +4,6 @@
 using HotChocolate.Types.Analyzers.Inspectors;
 using HotChocolate.Types.Analyzers.Models;
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.Text;
 
 namespace HotChocolate.Types.Analyzers.Generators;
 
@@ -14,7 +13,7 @@ public void Generate(
         SourceProductionContext context,
         string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos,
-        Action<string, SourceText> addSource)
+        Action<string, string> addSource)
     {
         var dataLoaderDefaults = syntaxInfos.GetDataLoaderDefaults();
         WriteDataLoader(syntaxInfos, dataLoaderDefaults, addSource);
@@ -23,7 +22,7 @@ public void Generate(
     private static void WriteDataLoader(
         ImmutableArray<SyntaxInfo> syntaxInfos,
         DataLoaderDefaultsInfo defaults,
-        Action<string, SourceText> addSource)
+        Action<string, string> addSource)
     {
         var dataLoaders = new List<DataLoaderInfo>();
 
@@ -124,7 +123,7 @@ private static void WriteDataLoader(
 
         if (hasDataLoaders)
         {
-            addSource(WellKnownFileNames.DataLoaderFile, generator.ToSourceText());
+            addSource(WellKnownFileNames.DataLoaderFile, generator.ToString());
         }
     }
 
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/Generators/DataLoaderModuleGenerator.cs b/src/HotChocolate/Core/src/Types.Analyzers/Generators/DataLoaderModuleGenerator.cs
@@ -3,7 +3,6 @@
 using HotChocolate.Types.Analyzers.Helpers;
 using HotChocolate.Types.Analyzers.Models;
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.Text;
 
 namespace HotChocolate.Types.Analyzers.Generators;
 
@@ -13,7 +12,7 @@ public void Generate(
         SourceProductionContext context,
         string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos,
-        Action<string, SourceText> addSource)
+        Action<string, string> addSource)
     {
         var module = GetDataLoaderModuleInfo(syntaxInfos);
         var dataLoaderDefaults = syntaxInfos.GetDataLoaderDefaults();
@@ -73,7 +72,7 @@ public void Generate(
         generator.WriteEndClass();
         generator.WriteEndNamespace();
 
-        addSource(WellKnownFileNames.DataLoaderModuleFile, generator.ToSourceText());
+        addSource(WellKnownFileNames.DataLoaderModuleFile, generator.ToString());
     }
 
     private static DataLoaderModuleInfo? GetDataLoaderModuleInfo(
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/Generators/ISyntaxGenerator.cs b/src/HotChocolate/Core/src/Types.Analyzers/Generators/ISyntaxGenerator.cs
@@ -1,7 +1,6 @@
 using System.Collections.Immutable;
 using HotChocolate.Types.Analyzers.Models;
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.Text;
 
 namespace HotChocolate.Types.Analyzers.Generators;
 
@@ -11,5 +10,5 @@ void Generate(
         SourceProductionContext context,
         string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos,
-        Action<string, SourceText> addSource);
+        Action<string, string> addSource);
 }
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/Generators/MiddlewareGenerator.cs b/src/HotChocolate/Core/src/Types.Analyzers/Generators/MiddlewareGenerator.cs
@@ -3,7 +3,6 @@
 using HotChocolate.Types.Analyzers.Helpers;
 using HotChocolate.Types.Analyzers.Models;
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.Text;
 
 namespace HotChocolate.Types.Analyzers.Generators;
 
@@ -15,7 +14,7 @@ public void Generate(
         SourceProductionContext context,
         string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos,
-        Action<string, SourceText> addSource)
+        Action<string, string> addSource)
     {
         if (syntaxInfos.IsEmpty)
         {
@@ -65,6 +64,6 @@ public void Generate(
 
         generator.WriteEndNamespace();
 
-        addSource(WellKnownFileNames.MiddlewareFile, generator.ToSourceText());
+        addSource(WellKnownFileNames.MiddlewareFile, generator.ToString());
     }
 }
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/Generators/TypeModuleSyntaxGenerator.cs b/src/HotChocolate/Core/src/Types.Analyzers/Generators/TypeModuleSyntaxGenerator.cs
@@ -3,7 +3,6 @@
 using HotChocolate.Types.Analyzers.Helpers;
 using HotChocolate.Types.Analyzers.Models;
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.Text;
 using TypeInfo = HotChocolate.Types.Analyzers.Models.TypeInfo;
 
 namespace HotChocolate.Types.Analyzers.Generators;
@@ -14,7 +13,7 @@ public void Generate(
         SourceProductionContext context,
         string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos,
-        Action<string, SourceText> addSource)
+        Action<string, string> addSource)
     {
         if (syntaxInfos.IsEmpty)
         {
@@ -43,7 +42,7 @@ public void Generate(
     private static void WriteConfiguration(
         List<SyntaxInfo> syntaxInfos,
         ModuleInfo module,
-        Action<string, SourceText> addSource)
+        Action<string, string> addSource)
     {
         var dataLoaderDefaults = syntaxInfos.GetDataLoaderDefaults();
         HashSet<(string InterfaceName, string ClassName)>? groups = null;
@@ -267,14 +266,14 @@ private static void WriteConfiguration(
 
         if (hasConfigurations)
         {
-            addSource(WellKnownFileNames.TypeModuleFile, generator.ToSourceText());
+            addSource(WellKnownFileNames.TypeModuleFile, generator.ToString());
         }
     }
 
     private static void WriteOperationTypes(
         List<SyntaxInfo> syntaxInfos,
         ModuleInfo module,
-        Action<string, SourceText> addSource)
+        Action<string, string> addSource)
     {
         var operations = new List<OperationInfo>();
 
@@ -310,7 +309,7 @@ private static void WriteOperationTypes(
 
         generator.WriteEndNamespace();
 
-        addSource(WellKnownFileNames.RootTypesFile, generator.ToSourceText());
+        addSource(WellKnownFileNames.RootTypesFile, generator.ToString());
     }
 
     public static string GetAssemblyQualifiedName(ITypeSymbol typeSymbol)
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/Generators/TypesSyntaxGenerator.cs b/src/HotChocolate/Core/src/Types.Analyzers/Generators/TypesSyntaxGenerator.cs
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/GraphQLServerGenerator.cs b/src/HotChocolate/Core/src/Types.Analyzers/GraphQLServerGenerator.cs
diff --git a/src/HotChocolate/Core/src/Types.Analyzers/Helpers/PooledObjects.cs b/src/HotChocolate/Core/src/Types.Analyzers/Helpers/PooledObjects.cs
diff --git a/src/HotChocolate/Core/test/Types.Analyzers.Tests/TestHelper.cs b/src/HotChocolate/Core/test/Types.Analyzers.Tests/TestHelper.cs

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`	`using HotChocolate.Types.Analyzers.Inspectors;`
`5`	`5`	`using HotChocolate.Types.Analyzers.Models;`
`6`	`6`	`using Microsoft.CodeAnalysis;`
`7`		`-using Microsoft.CodeAnalysis.Text;`
`8`	`7`
`9`	`8`	`namespace HotChocolate.Types.Analyzers.Generators;`
`10`	`9`
`@@ -14,7 +13,7 @@ public void Generate(`
`14`	`13`	`SourceProductionContext context,`
`15`	`14`	`string assemblyName,`
`16`	`15`	`ImmutableArray<SyntaxInfo> syntaxInfos,`
`17`		`- Action<string, SourceText> addSource)`
	`16`	`+ Action<string, string> addSource)`
`18`	`17`	`{`
`19`	`18`	`var dataLoaderDefaults = syntaxInfos.GetDataLoaderDefaults();`
`20`	`19`	`WriteDataLoader(syntaxInfos, dataLoaderDefaults, addSource);`
`@@ -23,7 +22,7 @@ public void Generate(`
`23`	`22`	`private static void WriteDataLoader(`
`24`	`23`	`ImmutableArray<SyntaxInfo> syntaxInfos,`
`25`	`24`	`DataLoaderDefaultsInfo defaults,`
`26`		`- Action<string, SourceText> addSource)`
	`25`	`+ Action<string, string> addSource)`
`27`	`26`	`{`
`28`	`27`	`var dataLoaders = new List<DataLoaderInfo>();`
`29`	`28`
`@@ -124,7 +123,7 @@ private static void WriteDataLoader(`
`124`	`123`
`125`	`124`	`if (hasDataLoaders)`
`126`	`125`	`{`
`127`		`- addSource(WellKnownFileNames.DataLoaderFile, generator.ToSourceText());`
	`126`	`+ addSource(WellKnownFileNames.DataLoaderFile, generator.ToString());`
`128`	`127`	`}`
`129`	`128`	`}`
`130`	`129`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`using HotChocolate.Types.Analyzers.Helpers;`
`4`	`4`	`using HotChocolate.Types.Analyzers.Models;`
`5`	`5`	`using Microsoft.CodeAnalysis;`
`6`		`-using Microsoft.CodeAnalysis.Text;`
`7`	`6`
`8`	`7`	`namespace HotChocolate.Types.Analyzers.Generators;`
`9`	`8`
`@@ -15,7 +14,7 @@ public void Generate(`
`15`	`14`	`SourceProductionContext context,`
`16`	`15`	`string assemblyName,`
`17`	`16`	`ImmutableArray<SyntaxInfo> syntaxInfos,`
`18`		`- Action<string, SourceText> addSource)`
	`17`	`+ Action<string, string> addSource)`
`19`	`18`	`{`
`20`	`19`	`if (syntaxInfos.IsEmpty)`
`21`	`20`	`{`
`@@ -65,6 +64,6 @@ public void Generate(`
`65`	`64`
`66`	`65`	`generator.WriteEndNamespace();`
`67`	`66`
`68`		`- addSource(WellKnownFileNames.MiddlewareFile, generator.ToSourceText());`
	`67`	`+ addSource(WellKnownFileNames.MiddlewareFile, generator.ToString());`
`69`	`68`	`}`
`70`	`69`	`}`