[Fusion] Fix findings (#8870)

Author: tobias-tengler

src/HotChocolate/Core/src/Types.Abstractions/Types/Extensions/HotChocolateTypesAbstractionsScalarDefinitionExtensions.cs

@@ -0,0 +1,34 @@
+using System.Collections.Frozen;
+
+namespace HotChocolate.Types;
+
+public static class HotChocolateTypesAbstractionsScalarDefinitionExtensions
+{
+    private static readonly FrozenDictionary<string, ScalarSerializationType> s_serializationTypeLookup =
+        new Dictionary<string, ScalarSerializationType>
+            {
+                ["https://scalars.graphql.org/andimarek/date-time.html"] = ScalarSerializationType.String,
+                ["https://scalars.graphql.org/andimarek/local-date.html"] = ScalarSerializationType.String
+            }
+            .ToFrozenDictionary();
+
+    public static ScalarSerializationType GetScalarSerializationType(
+        this IScalarTypeDefinition scalarTypeDefinition)
+    {
+        if (scalarTypeDefinition.SpecifiedBy is not null
+            && s_serializationTypeLookup.TryGetValue(scalarTypeDefinition.SpecifiedBy.AbsoluteUri, out var scalarSerializationType))
+        {
+            return scalarSerializationType;
+        }
+
+        return scalarTypeDefinition.Name switch
+        {
+            SpecScalarNames.String.Name => ScalarSerializationType.String,
+            SpecScalarNames.Int.Name => ScalarSerializationType.Int,
+            SpecScalarNames.Float.Name => ScalarSerializationType.Float,
+            SpecScalarNames.Boolean.Name => ScalarSerializationType.Boolean,
+            SpecScalarNames.ID.Name => ScalarSerializationType.String | ScalarSerializationType.Int,
+            _ => scalarTypeDefinition.SerializationType
+        };
+    }
+}

src/HotChocolate/Core/src/Types.Abstractions/Types/IScalarTypeDefinition.cs

@@ -22,7 +22,7 @@ public interface IScalarTypeDefinition
 
     /// <summary>
     /// Gets the ECMA-262 regex pattern that the serialized scalar value conforms
-    /// to if its of the serialization type <see cref="ScalarSerializationType.String"/>.
+    /// to, if it's of the serialization type <see cref="ScalarSerializationType.String"/>.
     /// </summary>
     string? Pattern { get; }
 

src/HotChocolate/Core/src/Types.Abstractions/Types/SpecDirectiveNames.cs

@@ -3,8 +3,7 @@
   <PropertyGroup>
     <AssemblyName>HotChocolate.Fusion.Aspire</AssemblyName>
     <RootNamespace>HotChocolate.Fusion.Aspire</RootNamespace>
-    <TargetFrameworks>net9.0</TargetFrameworks>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFrameworks>net10.0; net9.0</TargetFrameworks>
     <IsAotCompliant>false</IsAotCompliant>
   </PropertyGroup>
 

src/HotChocolate/Core/src/Types.Abstractions/Types/SpecScalarNames.cs

@@ -27,6 +27,7 @@ public static class LogEntryCodes
     public const string InputFieldDefaultMismatch = "INPUT_FIELD_DEFAULT_MISMATCH";
     public const string InputFieldTypesNotMergeable = "INPUT_FIELD_TYPES_NOT_MERGEABLE";
     public const string InputWithMissingRequiredFields = "INPUT_WITH_MISSING_REQUIRED_FIELDS";
+    public const string InputWithMissingOneOf = "INPUT_WITH_MISSING_ONEOF";
     public const string InterfaceFieldNoImplementation = "INTERFACE_FIELD_NO_IMPLEMENTATION";
     public const string InvalidFieldSharing = "INVALID_FIELD_SHARING";
     public const string InvalidGraphQL = "INVALID_GRAPHQL";

src/HotChocolate/Fusion-vnext/src/Fusion.Aspire/HotChocolate.Fusion.Aspire.csproj

@@ -483,6 +483,24 @@ public static LogEntry InputWithMissingRequiredFields(
             .Build();
     }
 
+    public static LogEntry InputWithMissingOneOf(
+        MutableInputObjectTypeDefinition inputType,
+        MutableSchemaDefinition schema,
+        MutableSchemaDefinition schemaWhereOneOfIsDefined)
+    {
+        return LogEntryBuilder.New()
+            .SetMessage(
+                LogEntryHelper_InputWithMissingOneOf,
+                inputType.Name,
+                schema.Name,
+                schemaWhereOneOfIsDefined.Name)
+            .SetCode(LogEntryCodes.InputWithMissingOneOf)
+            .SetSeverity(LogSeverity.Error)
+            .SetTypeSystemMember(inputType)
+            .SetSchema(schema)
+            .Build();
+    }
+
     public static LogEntry InterfaceFieldNoImplementation(
         MutableObjectTypeDefinition objectType,
         string fieldName,

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Logging/LogEntryCodes.cs

@@ -0,0 +1,43 @@
+using HotChocolate.Fusion.Events;
+using HotChocolate.Fusion.Events.Contracts;
+using HotChocolate.Fusion.Extensions;
+using HotChocolate.Fusion.Logging;
+using HotChocolate.Types.Mutable;
+
+namespace HotChocolate.Fusion.PreMergeValidationRules;
+
+/// <summary>
+/// If one input type is annotated with the @oneOf directive, all input types
+/// of the same name must be annotated with it as well.
+/// </summary>
+internal sealed class InputWithMissingOneOfRule : IEventHandler<InputTypeGroupEvent>
+{
+    public void Handle(InputTypeGroupEvent @event, CompositionContext context)
+    {
+        var (_, inputTypeGroup) = @event;
+
+        var firstInputWithOneOf = inputTypeGroup.FirstOrDefault(i => i.InputType.IsOneOf);
+
+        if (firstInputWithOneOf is null || inputTypeGroup.Length == 1)
+        {
+            return;
+        }
+
+        foreach (var (inputType, schema) in inputTypeGroup)
+        {
+            if (inputType.HasInaccessibleDirective())
+            {
+                continue;
+            }
+
+            if (!inputType.IsOneOf)
+            {
+                context.Log.Write(
+                    LogEntryHelper.InputWithMissingOneOf(
+                        inputType,
+                        schema,
+                        firstInputWithOneOf.Schema));
+            }
+        }
+    }
+}