[OpenAPI] Fix ImmutableArray deserialization (#9011)

Author: tobias-tengler

src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/Definitions/OpenApiModelDefinition.cs

@@ -16,7 +16,9 @@ public static OpenApiModelDefinition From(
         string name,
         DocumentNode document)
     {
-        var fragmentReferences = FragmentReferenceFinder.Find(document);
+        var primaryFragmentDefinition = document.Definitions.OfType<FragmentDefinitionNode>().First();
+
+        var fragmentReferences = FragmentReferenceFinder.Find(document, primaryFragmentDefinition);
 
         return new OpenApiModelDefinition(
             name,

src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/Serialization/OpenApiEndpointSettingsDto.cs

@@ -4,6 +4,13 @@ namespace HotChocolate.Adapters.OpenApi;
 
 public sealed record OpenApiEndpointSettingsDto(
     string? Description,
-    ImmutableArray<OpenApiEndpointDefinitionParameter> RouteParameters,
-    ImmutableArray<OpenApiEndpointDefinitionParameter> QueryParameters,
-    string? BodyVariableName);
+    ImmutableArray<OpenApiEndpointDefinitionParameter> RouteParameters = default,
+    ImmutableArray<OpenApiEndpointDefinitionParameter> QueryParameters = default,
+    string? BodyVariableName = null)
+{
+    public ImmutableArray<OpenApiEndpointDefinitionParameter> RouteParameters { get; init; } =
+        RouteParameters.IsDefault ? [] : RouteParameters;
+
+    public ImmutableArray<OpenApiEndpointDefinitionParameter> QueryParameters { get; init; } =
+        QueryParameters.IsDefault ? [] : QueryParameters;
+}

src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/Serialization/OpenApiEndpointSettingsSerializerTests.cs

@@ -0,0 +1,108 @@
+using System.Text.Json;
+
+namespace HotChocolate.Adapters.OpenApi.Serialization;
+
+public class OpenApiEndpointSettingsSerializerTests
+{
+    [Fact]
+    public void Parse_With_Initialized_Properties_Succeeds()
+    {
+        // arrange
+        var jsonDocument = JsonDocument.Parse(
+            """
+            {
+              "description": "Fetches user posts",
+              "routeParameters": [
+                {
+                  "key": "userId",
+                  "variableName":"userId"
+                }],
+              "queryParameters": [
+                {
+                  "key": "limit",
+                  "variableName": "limit"
+                },
+                {
+                  "key": "offset",
+                  "variableName": "offset"
+                }],
+              "bodyVariableName": "input"
+            }
+            """);
+
+        // act
+        var settings = OpenApiEndpointSettingsSerializer.Parse(jsonDocument);
+
+        // assert
+        Assert.Equal("Fetches user posts", settings.Description);
+
+        var routeParam = Assert.Single(settings.RouteParameters);
+        Assert.Equal("userId", routeParam.Key);
+        Assert.Equal("userId", routeParam.VariableName);
+
+        Assert.Equal(2, settings.QueryParameters.Length);
+        Assert.Contains(settings.QueryParameters, p => p.Key == "limit");
+        Assert.Contains(settings.QueryParameters, p => p.Key == "offset");
+
+        Assert.Equal("input", settings.BodyVariableName);
+    }
+
+    [Fact]
+    public void Parse_With_Null_Properties_Succeeds()
+    {
+        // arrange
+        var jsonDocument = JsonDocument.Parse(
+            """
+            {
+              "description": null,
+              "routeParameters": [
+                {
+                  "key": "userId",
+                  "variableName":"userId"
+                }],
+              "queryParameters": [
+                {
+                  "key": "limit",
+                  "variableName": "limit"
+                },
+                {
+                  "key": "offset",
+                  "variableName": "offset"
+                }],
+              "bodyVariableName": null
+            }
+            """);
+
+        // act
+        var settings = OpenApiEndpointSettingsSerializer.Parse(jsonDocument);
+
+        // assert
+        Assert.Null(settings.Description);
+
+        var routeParam = Assert.Single(settings.RouteParameters);
+        Assert.Equal("userId", routeParam.Key);
+        Assert.Equal("userId", routeParam.VariableName);
+
+        Assert.Equal(2, settings.QueryParameters.Length);
+        Assert.Contains(settings.QueryParameters, p => p.Key == "limit");
+        Assert.Contains(settings.QueryParameters, p => p.Key == "offset");
+
+        Assert.Null(settings.BodyVariableName);
+    }
+
+    [Fact]
+    public void Parse_Empty_JsonObject_Succeeds()
+    {
+        // arrange
+        var jsonDocument = JsonDocument.Parse("{}");
+
+        // act
+        var settings = OpenApiEndpointSettingsSerializer.Parse(jsonDocument);
+
+        // assert
+        Assert.Null(settings.Description);
+        Assert.Empty(settings.RouteParameters);
+        Assert.Empty(settings.QueryParameters);
+        Assert.Null(settings.BodyVariableName);
+    }
+}

src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/Serialization/OpenApiModelSettingsSerializerTests.cs

@@ -0,0 +1,55 @@
+using System.Text.Json;
+
+namespace HotChocolate.Adapters.OpenApi.Serialization;
+
+public class OpenApiModelSettingsSerializerTests
+{
+    [Fact]
+    public void Parse_With_Initialized_Properties_Succeeds()
+    {
+        // arrange
+        var jsonDocument = JsonDocument.Parse(
+            """
+            {
+              "description": "The user's address information"
+            }
+            """);
+
+        // act
+        var settings = OpenApiModelSettingsSerializer.Parse(jsonDocument);
+
+        // assert
+        Assert.Equal("The user's address information", settings.Description);
+    }
+
+    [Fact]
+    public void Parse_With_Null_Properties_Succeeds()
+    {
+        // arrange
+        var jsonDocument = JsonDocument.Parse(
+            """
+            {
+              "description": null
+            }
+            """);
+
+        // act
+        var settings = OpenApiModelSettingsSerializer.Parse(jsonDocument);
+
+        // assert
+        Assert.Null(settings.Description);
+    }
+
+    [Fact]
+    public void Parse_Empty_JsonObject_Succeeds()
+    {
+        // arrange
+        var jsonDocument = JsonDocument.Parse("{}");
+
+        // act
+        var settings = OpenApiModelSettingsSerializer.Parse(jsonDocument);
+
+        // assert
+        Assert.Null(settings.Description);
+    }
+}