Skip to content

Commit ffe47b7

Browse files
Cleanup
1 parent d6e5953 commit ffe47b7

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Nodes/OperationExecutionNode.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ public OperationExecutionNode(
5757

5858
_variables = variables.ToArray();
5959

60-
// TODO: This might include requirements that we wouldn't want to create a front-end facing error for
6160
// TODO: How to deal with selections on a specific type? Creating errors for all possible response names is wrong
6261
_responseNames = GetResponseNamesFromPath(operation, source);
6362
}

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Results/ValueCompletion.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public void BuildErrorResult(
8989
{
9090
var fieldResult = objectResult[responseName];
9191

92-
if (!fieldResult.Selection.IsIncluded(_includeFlags))
92+
if (fieldResult.Selection.IsInternal || !fieldResult.Selection.IsIncluded(_includeFlags))
9393
{
9494
continue;
9595
}

src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/__snapshots__/SubgraphErrorTests.No_Data_And_Error_Without_Path_For_Lookup.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"message": "A global error"
55
},
66
{
7-
"message": "Unexpected execution error",
7+
"message": "Unexpected Execution Error",
88
"path": [
99
"topProduct",
1010
"name"

src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/__snapshots__/SubgraphErrorTests.No_Data_And_Error_Without_Path_For_Root_Field.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"message": "A global error"
88
},
99
{
10-
"message": "Unexpected execution error",
10+
"message": "Unexpected Execution Error",
1111
"path": [
1212
"productById"
1313
]

0 commit comments

Comments
 (0)