Skip to content

Adds inaccessible support #8887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 9 commits into from
Nov 19, 2025
Merged

Adds inaccessible support #8887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
139272e
Adds inaccessible support to fields.
michaelstaib Nov 10, 2025
8c977e6
fixed snapshots
michaelstaib Nov 10, 2025
4e1636e
Operation compiler must use fusion schema.
michaelstaib Nov 10, 2025
3bc5fc9
wip
michaelstaib Nov 10, 2025
4f658b7
wip
michaelstaib Nov 11, 2025
9751d48
Added more tests
michaelstaib Nov 18, 2025
18b1aca
Added more tests and fixed issue we discovered
michaelstaib Nov 19, 2025
ccffd8a
Merge branch 'main' into mst/inaccessible-support
michaelstaib Nov 19, 2025
a1ac5c1
Fixed merge
michaelstaib Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...colate/Core/src/Types.Abstractions/Types/Collections/IReadOnlyTypeDefinitionCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ public interface IReadOnlyTypeDefinitionCollection : IReadOnlyList<ITypeDefiniti
/// Tries to get a type by its name and kind.
/// </summary>
/// <param name="name">The name of the type.</param>
/// <param name="type">The resolved type.</param>
/// <param name="typeDefinition">The resolved type.</param>
/// <returns>
/// <c>true</c>, if a type with the name exists and is of the specified
/// kind, <c>false</c> otherwise.
/// </returns>
bool TryGetType(string name, [NotNullWhen(true)] out ITypeDefinition? type);
bool TryGetType(string name, [NotNullWhen(true)] out ITypeDefinition? typeDefinition);

/// <summary>
/// Tries to get a type by its name and kind.
Expand Down
4 changes: 4 additions & 0 deletions src/HotChocolate/Core/src/Types/Types/Composite/Directives/InaccessibleAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ protected internal override void TryConfigure(
unionTypeDescriptor.Inaccessible();
break;

case IScalarTypeDescriptor scalarTypeDescriptor:
scalarTypeDescriptor.Inaccessible();
break;

default:
throw new NotSupportedException(
$"The {descriptor.GetType().Name} descriptor is not supported.");
Expand Down
31 changes: 31 additions & 0 deletions ...otChocolate/Core/src/Types/Types/Composite/Directives/InaccessibleDescriptorExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,4 +417,35 @@ public static IUnionTypeDescriptor Inaccessible(
ArgumentNullException.ThrowIfNull(descriptor);
return descriptor.Directive(Composite.Inaccessible.Instance);
}

/// <summary>
/// <para>
/// Applies the @inaccessible directive to the scalar type to prevent it
/// from being accessible through the client-facing composite schema,
/// even if it is accessible in the underlying source schemas.
/// </para>
/// <para>
/// <code language="graphql">
/// scalar Email @inaccessible
/// </code>
/// </para>
/// <para>
/// <see href="https://graphql.github.io/composite-schemas-spec/draft/#sec--inaccessible"/>
/// </para>
/// </summary>
/// <param name="descriptor">
/// The union type descriptor to apply the directive to.
/// </param>
/// <returns>
/// The union type descriptor with the directive applied.
/// </returns>
/// <exception cref="ArgumentNullException">
/// The <paramref name="descriptor"/> is <c>null</c>.
/// </exception>
public static IScalarTypeDescriptor Inaccessible(
this IScalarTypeDescriptor descriptor)
{
ArgumentNullException.ThrowIfNull(descriptor);
return descriptor.Directive(Composite.Inaccessible.Instance);
}
}
8 changes: 4 additions & 4 deletions src/HotChocolate/Core/src/Types/Types/TypeDefinitionCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,20 +77,20 @@ public T GetType<T>(string name)
/// Tries to get a type by its name and kind.
/// </summary>
/// <param name="name">The name of the type.</param>
/// <param name="type">The resolved type.</param>
/// <param name="typeDefinition">The resolved type.</param>
/// <returns>
/// <c>true</c>, if a type with the name exists and is of the specified
/// kind, <c>false</c> otherwise.
/// </returns>
public bool TryGetType(string name, [NotNullWhen(true)] out ITypeDefinition? type)
public bool TryGetType(string name, [NotNullWhen(true)] out ITypeDefinition? typeDefinition)
{
if (_typeLookup.TryGetValue(name, out var t))
{
type = t;
typeDefinition = t;
return true;
}

type = null;
typeDefinition = null;
return false;
}

Expand Down
Loading
Loading