Skip to content

Commit 02212e2

Browse files
robtaylorclaude
andcommitted
Fix lint issues in amaranth test files
- Remove unused imports in test_silicon_platform_additional.py - Remove unused imports in test_silicon_platform_amaranth.py - Fix F821 undefined name errors for Signal and ClockDomain - Remove unused variable in test_silicon_platform_amaranth.py 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent c3f5408 commit 02212e2

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

tests/test_silicon_platform_additional.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
from unittest import mock
77

88
import tomli
9-
from amaranth import Module, Signal, ClockDomain, ClockSignal, ResetSignal
10-
from amaranth.lib import io, wiring
11-
from amaranth.lib.wiring import Component, In
9+
from amaranth import Module, Signal, ClockDomain
10+
from amaranth.lib import io
1211

1312
from chipflow_lib.platforms.silicon import (
1413
IOBuffer, FFBuffer, SiliconPlatformPort
@@ -93,8 +92,8 @@ def setUp(self):
9392
def test_instantiate_ports(self, mock_load_pinlock):
9493
"""Test instantiate_ports method with minimal mocking"""
9594
# Import here to avoid issues during test collection
96-
from chipflow_lib.platforms.silicon import SiliconPlatform, Port
97-
from amaranth import Module, Signal, ClockDomain
95+
from chipflow_lib.platforms.silicon import SiliconPlatform
96+
from amaranth import Module
9897

9998
# Create mock pinlock
10099
mock_pinlock = mock.MagicMock()
@@ -213,8 +212,8 @@ def test_instantiate_ports_with_clocks_and_resets(self, mock_load_pinlock, mock_
213212
mock_reset_signal, mock_clock_signal):
214213
"""Test instantiate_ports method with clocks and resets"""
215214
# Import here to avoid issues during test collection
216-
from chipflow_lib.platforms.silicon import SiliconPlatform, Port
217-
from amaranth import Module, Signal
215+
from chipflow_lib.platforms.silicon import SiliconPlatform
216+
from amaranth import Module
218217

219218
# Create mocks for signals and buffer
220219
mock_clock_signal_instance = Signal()

tests/test_silicon_platform_amaranth.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
from unittest import mock
77

88
import tomli
9-
from amaranth import Module, Signal, Cat, ClockDomain, ClockSignal, ResetSignal
10-
from amaranth.lib import io, wiring
9+
from amaranth import Module, Signal, ClockDomain
10+
from amaranth.lib import io
1111
from amaranth.hdl._ir import Fragment
1212

1313
from chipflow_lib import ChipFlowError
@@ -439,7 +439,7 @@ def elaborate(self, platform):
439439
return m
440440

441441
# Call build with our test elaboratable
442-
result = platform.build(TestElaboratable(), name="test_build")
442+
platform.build(TestElaboratable(), name="test_build")
443443

444444
# Check that prepare was called
445445
platform._prepare.assert_called_once()

0 commit comments

Comments
 (0)