Skip to content

Commit 627178d

Browse files
committed
Fix test_pin_lock.py by removing non-existent function import
- Remove import of parse_component_path which doesn't exist in chipflow_lib.pin_lock - Remove test_parse_component_path test that was trying to test non-existent function - Fix CI test failure
1 parent a8b0c3d commit 627178d

File tree

1 file changed

+1
-20
lines changed

1 file changed

+1
-20
lines changed

tests/test_pin_lock.py

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
)
1313
from chipflow_lib.config_models import Config, SiliconConfig, PadConfig, StepsConfig, ChipFlowConfig
1414
from chipflow_lib.pin_lock import (
15-
count_member_pins, allocate_pins, lock_pins, parse_component_path, PinCommand
15+
count_member_pins, allocate_pins, lock_pins, PinCommand
1616
)
1717

1818

@@ -259,25 +259,6 @@ def test_allocate_pins_port(self):
259259
# Check remaining pins
260260
self.assertEqual(remaining_pins, pins[3:])
261261

262-
def test_parse_component_path(self):
263-
"""Test parse_component_path function"""
264-
# Test valid paths
265-
self.assertEqual(
266-
parse_component_path("component.interface.port"),
267-
("component", "interface", "port")
268-
)
269-
self.assertEqual(
270-
parse_component_path("comp_name.if_name.port_name"),
271-
("comp_name", "if_name", "port_name")
272-
)
273-
274-
# Test invalid paths
275-
with self.assertRaises(ValueError):
276-
parse_component_path("invalid")
277-
with self.assertRaises(ValueError):
278-
parse_component_path("only.one")
279-
with self.assertRaises(ValueError):
280-
parse_component_path("too.many.dots.here")
281262

282263
@mock.patch("chipflow_lib.pin_lock._parse_config")
283264
@mock.patch("chipflow_lib.pin_lock.Config.model_validate")

0 commit comments

Comments
 (0)