Skip to content

Commit c1adadc

Browse files
committed
retired the api unit test: Unit tests are meant to be isolated, so testing code that interacts directly with databases, APIs, file systems, or hardware isn't ideal for unit tests—use integration tests instead. e.g.: Testing an API client that only makes a network request—better tested with integration or end-to-end tests.
1 parent 63d542c commit c1adadc

File tree

3 files changed

+3
-91
lines changed

3 files changed

+3
-91
lines changed

chipflow_lib/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from .pin_lock import PinCommand
1616

1717

18-
logging.basicConfig(stream=sys.stdout, level=logging.WARNING)
18+
logging.basicConfig(stream=sys.stdout, level=logging.INFO)
1919

2020

2121
class UnexpectedError(ChipFlowError):

chipflow_lib/steps/silicon.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,15 +94,15 @@ def submit(self, rtlil_path, *, dry_run=False):
9494
"""
9595
git_head = subprocess.check_output(
9696
["git", "-C", os.environ["CHIPFLOW_ROOT"],
97-
"rev-parse", "HEAD"],
97+
"rev-parse", "--short", "HEAD"],
9898
encoding="ascii").rstrip()
9999
git_dirty = bool(subprocess.check_output(
100100
["git", "-C", os.environ["CHIPFLOW_ROOT"],
101101
"status", "--porcelain", "--untracked-files=no"]))
102102
submission_name = git_head
103103
if git_dirty:
104104
logging.warning("Git tree is dirty, submitting anyway!")
105-
submission_name += f"-dirty.{time.strftime('%Y%m%d%M%H%S', time.gmtime())}"
105+
submission_name += f"-dirty"
106106
dep_versions = {
107107
"python": sys.version.split()[0]
108108
}

tests/test_silicon_step.py

Lines changed: 0 additions & 88 deletions
This file was deleted.

0 commit comments

Comments
 (0)