Add browser prompt after silicon submit #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a successful silicon submission, the user is now prompted to open the build URL in their browser. This applies whether using --wait or not. The prompt only appears in interactive terminals (when stdout.isatty() returns true). Changes: - Import webbrowser module in silicon_step.py - Add user prompt after successful submission asking if they want to open the build URL - Handle both 'y' and 'yes' responses - Gracefully handle KeyboardInterrupt and EOFError during prompt - Skip prompt in non-interactive terminals (CI, scripts, etc.) Tests: - Add comprehensive test suite for browser prompt functionality - Test 'yes' response opens browser - Test 'no' response doesn't open browser - Test non-TTY environments skip the prompt 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a successful silicon submission, the user is now prompted to open
the build URL in their browser. This applies whether using --wait or not.
The prompt only appears in interactive terminals (when stdout.isatty()
returns true).
Changes:
open the build URL
Tests:
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]