Skip to content

Commit 7849fe7

Browse files
committed
clear type: ignore
1 parent ab5eb96 commit 7849fe7

File tree

2 files changed

+50
-50
lines changed

2 files changed

+50
-50
lines changed

fast_tmp/site/base.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ class BaseAdminControl(AbstractAmisAdminDB, AbstractControl, AmisOrm):
111111
label: str
112112
description: Optional[str]
113113
placeholder: Optional[str]
114-
_field: fields.Field
114+
_field: Any
115115
_control: FormItem = None # type: ignore
116116
_column: Column = None # type: ignore
117117
_column_inline: ColumnInline = None # type: ignore
@@ -136,11 +136,11 @@ def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
136136
description=self.description,
137137
placeholder=self.placeholder,
138138
)
139-
if not callable(self._field.default): # type: ignore
140-
if not self._field.null: # type: ignore
139+
if not callable(self._field.default):
140+
if not self._field.null:
141141
self._control.required = True
142-
if self._field.default is not None: # type: ignore
143-
self._control.value = self.orm_2_amis(self._field.default) # type: ignore
142+
if self._field.default is not None:
143+
self._control.value = self.orm_2_amis(self._field.default)
144144
return self._control
145145

146146
def options(self):
@@ -158,7 +158,7 @@ def get_column_inline(self, request: Request) -> Column:
158158
options = self.options()
159159
if options:
160160
self._column_inline.quickEdit.options = options
161-
if self._field.null: # type: ignore
161+
if self._field.null:
162162
self._column_inline.quickEdit.clearable = True
163163
return self._column_inline
164164

@@ -169,15 +169,15 @@ async def set_value(self, request: Request, obj: Model, value: Any):
169169
async def get_value(self, request: Request, obj: Model) -> Any:
170170
return self.orm_2_amis(getattr(obj, self.name))
171171

172-
def __init__(self, name: str, field: fields.Field, prefix: str, **kwargs):
172+
def __init__(self, name: str, field: fields.Field[Any], prefix: str, **kwargs):
173173
super().__init__(name, prefix, **kwargs)
174-
self._field = field # type: ignore
174+
self._field = field
175175
self.name = name
176176
label, description, placeholder = None, None, None
177177
if field.description:
178178
values = field_description.match(field.description)
179179
if values and not isinstance(
180-
self._field, ManyToManyFieldInstance # type: ignore
180+
self._field, ManyToManyFieldInstance
181181
): # todo 还没想好多对多怎么处理 一对多也没想好怎么处理 枚举类型description默认有值,需要自己进行覆盖
182182
label, description, placeholder = values.groups()
183183
self.label = kwargs.get("label") or label or name
@@ -187,11 +187,11 @@ def __init__(self, name: str, field: fields.Field, prefix: str, **kwargs):
187187
async def validate(self, value: Any, is_create=False) -> Any:
188188
if not value and is_create:
189189
if (
190-
callable(self._field.default) and not self._field.null # type: ignore
190+
callable(self._field.default) and not self._field.null
191191
): # 不为空且默认值是函数的时候,前段页面如果传null则使用默认值
192-
return self._field.default() # type: ignore
192+
return self._field.default()
193193
value = self.amis_2_orm(value)
194-
self._field.validate(value) # type: ignore
194+
self._field.validate(value)
195195
return value
196196

197197

fast_tmp/site/field.py

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,12 @@ def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
6262
self._control = NumberItem(
6363
type=self._control_type, name=self.name, label=self.label, big=True
6464
)
65-
self._control.precision = self._field.decimal_places # type: ignore
66-
self._control.max = self._field.max_digits * 9 # type: ignore
67-
if not self._field.null: # type: ignore
65+
self._control.precision = self._field.decimal_places
66+
self._control.max = self._field.max_digits * 9
67+
if not self._field.null:
6868
self._control.required = True
69-
if self._field.default is not None: # type: ignore
70-
self._control.value = self.orm_2_amis(self._field.default) # type: ignore
69+
if self._field.default is not None:
70+
self._control.value = self.orm_2_amis(self._field.default)
7171
return self._control
7272

7373
def amis_2_orm(self, value: float) -> Any:
@@ -87,7 +87,7 @@ def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
8787
super().get_formitem(request, codenames)
8888
d = self._control.dict(exclude_none=True)
8989
d.pop("type")
90-
if self._field.null: # type: ignore
90+
if self._field.null:
9191
d["clearable"] = True
9292
self._control = SelectItem(**d)
9393
self._control.options = self.options()
@@ -98,16 +98,16 @@ def orm_2_amis(self, value: Any) -> Any:
9898
return value.name
9999

100100
def amis_2_orm(self, value: Any) -> Any:
101-
if value is None and self._field.null: # type: ignore
101+
if value is None and self._field.null:
102102
return None
103-
for i in self._field.enum_type: # type: ignore
103+
for i in self._field.enum_type:
104104
if i.name == value:
105105
return i.value
106106
raise TmpValueError(f"{self.label} 不能为 {value}")
107107

108108
def options(self) -> List[str]:
109109
res = []
110-
for i in self._field.enum_type: # type: ignore
110+
for i in self._field.enum_type:
111111
res.append(i.name)
112112
return res
113113

@@ -119,7 +119,7 @@ def options(self) -> List[str]:
119119
return ["True", "False"]
120120

121121
def amis_2_orm(self, value: Any) -> Any:
122-
if not value and self._field.null: # type: ignore
122+
if not value and self._field.null:
123123
return None
124124
if value == "True":
125125
return True
@@ -157,7 +157,7 @@ def get_column_inline(self, request: Request) -> Column:
157157
def amis_2_orm(self, value: str) -> Any:
158158
if value:
159159
return datetime.datetime.strptime(value, "%Y-%m-%d %H:%M:%S")
160-
if self._field.null: # type: ignore
160+
if self._field.null:
161161
return None
162162
raise TmpValueError(f"{self.label} 不能为 {value}")
163163

@@ -185,7 +185,7 @@ def amis_2_orm(self, value: Any) -> Any:
185185
if value:
186186
year, month, day = value.split("-")
187187
return datetime.date(int(year), int(month), int(day))
188-
if self._field.null: # type: ignore
188+
if self._field.null:
189189
return None
190190
raise TmpValueError(f"{self.label} 不能为 {value}")
191191

@@ -215,7 +215,7 @@ def get_column_inline(self, request: Request) -> Column:
215215
def amis_2_orm(self, value: Any) -> Any:
216216
if value:
217217
return datetime.time.fromisoformat(value)
218-
if self._field.null: # type: ignore
218+
if self._field.null:
219219
return None
220220
raise TmpValueError(f"{self.label} 不能为 {value}")
221221

@@ -237,7 +237,7 @@ def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
237237
if not self._control:
238238
super().get_formitem(request, codenames)
239239
self._control.validations = "isJson"
240-
if not callable(self._field.default): # type: ignore
240+
if not callable(self._field.default):
241241
self._control.required = True # jsonfield不能为空不然写数据库必爆炸
242242
if not self._control.value: # 如果有默认值则已经在父类里面被调用
243243
self._control.value = "{}"
@@ -280,12 +280,12 @@ async def get_selects(
280280
page: Optional[int],
281281
filter: Any = None,
282282
):
283-
field_model_all = self._field.related_model.all() # type: ignore
283+
field_model_all = self._field.related_model.all()
284284
# if filter:
285285
# if isinstance(filter, dict):
286-
# field_model_all = self._field.related_model.filter(**filter) # type: ignore
286+
# field_model_all = self._field.related_model.filter(**filter)
287287
# else:
288-
# field_model_all = self._field.related_model.filter(filter) # type: ignore
288+
# field_model_all = self._field.related_model.filter(filter)
289289
# if perPage is not None and page is not None:
290290
# field_model = field_model_all.limit(perPage).offset((page - 1) * perPage)
291291
# count = await field_model_all.count()
@@ -323,7 +323,7 @@ def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
323323
labelField="label",
324324
valueField="value",
325325
)
326-
if not self._field.null: # type: ignore
326+
if not self._field.null:
327327
self._control.required = True
328328
else:
329329
self._control.clearable = True
@@ -338,7 +338,7 @@ async def set_value(self, request: Request, obj: Model, value: Any):
338338
if value is not None:
339339
if isinstance(value, dict):
340340
value = value.get("value")
341-
value = await self._field.related_model.filter(pk=value).first() # type: ignore
341+
value = await self._field.related_model.filter(pk=value).first()
342342
setattr(obj, self.name, value)
343343

344344

@@ -360,7 +360,7 @@ def get_column(self, request: Request) -> Column:
360360
title=self.label,
361361
body=CRUD(
362362
api="get:"
363-
+ self._field.model.__name__.lower() # type: ignore
363+
+ self._field.model.__name__.lower()
364364
+ f"/select/{self.name}?pk=$pk",
365365
columns=[
366366
Column(label="主键", name="pk"),
@@ -381,9 +381,9 @@ async def get_selects(
381381
page: Optional[int],
382382
filter: Any = None,
383383
):
384-
related_model = self._field.related_model # type: ignore
384+
related_model = self._field.related_model
385385
if pk is not None:
386-
queryset = related_model.filter(**{self._field.related_name: pk}) # type: ignore
386+
queryset = related_model.filter(**{self._field.related_name: pk})
387387
else:
388388
queryset = related_model.all()
389389
# if filter:
@@ -409,7 +409,7 @@ def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
409409
label=self.label,
410410
source=f"get:{self._prefix}/select/{self.name}",
411411
)
412-
if self._field.null: # type: ignore
412+
if self._field.null:
413413
self._control.clearable = True
414414
return self._control
415415

@@ -422,7 +422,7 @@ async def validate(self, value: Any, is_create=False) -> Any:
422422
if value is not None:
423423
pks = self.amis_2_orm(value)
424424
if len(pks) > 0:
425-
return await self._field.related_model.filter(pk__in=pks) # type: ignore
425+
return await self._field.related_model.filter(pk__in=pks)
426426
return []
427427

428428
async def set_value(self, request: Request, obj: Model, value: Any) -> Optional[Coroutine]:
@@ -467,12 +467,12 @@ def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
467467
self._control = FileItem(
468468
name=self.name,
469469
label=self.label,
470-
receiver=f"{self._field.model.__name__}/file/{self.name}", # type: ignore
470+
receiver=f"{self._field.model.__name__}/file/{self.name}",
471471
)
472-
if not self._field.null: # type: ignore
472+
if not self._field.null:
473473
self._control.required = True
474-
if self._field.default is not None: # type: ignore
475-
self._control.value = self.orm_2_amis(self._field.default) # type: ignore
474+
if self._field.default is not None:
475+
self._control.value = self.orm_2_amis(self._field.default)
476476
return self._control
477477

478478
def orm_2_amis(self, value: str) -> Any:
@@ -492,12 +492,12 @@ def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
492492
self._control = ImageItem(
493493
name=self.name,
494494
label=self.label,
495-
receiver=f"{self._field.model.__name__.lower()}/file/{self.name}", # type: ignore
495+
receiver=f"{self._field.model.__name__.lower()}/file/{self.name}",
496496
)
497-
if not self._field.null: # type: ignore
497+
if not self._field.null:
498498
self._control.required = True
499-
if self._field.default is not None: # type: ignore
500-
self._control.value = self.orm_2_amis(self._field.default) # type: ignore
499+
if self._field.default is not None:
500+
self._control.value = self.orm_2_amis(self._field.default)
501501
return self._control
502502

503503
def get_column(self, request: Request) -> Column:
@@ -520,10 +520,10 @@ class RichTextControl(BaseAdminControl):
520520
def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
521521
if not self._control:
522522
self._control = RichTextItem(type=self._control_type, name=self.name, label=self.label)
523-
if not self._field.null: # type: ignore
523+
if not self._field.null:
524524
self._control.required = True
525-
if self._field.default is not None: # type: ignore
526-
self._control.value = self.orm_2_amis(self._field.default) # type: ignore
525+
if self._field.default is not None:
526+
self._control.value = self.orm_2_amis(self._field.default)
527527
return self._control
528528

529529

@@ -591,7 +591,7 @@ async def set_value(self, request: Request, obj: Model, value: Any):
591591
def get_formitem(self, request: Request, codenames: Iterable[str]) -> FormItem:
592592
if not self._control:
593593
self._control = FormItem(type=self._control_type, name=self.name, label=self.label)
594-
if not self._field.null: # type: ignore
595-
if self._field.default is not None: # type: ignore
596-
self._control.value = self.orm_2_amis(self._field.default) # type: ignore
594+
if not self._field.null:
595+
if self._field.default is not None:
596+
self._control.value = self.orm_2_amis(self._field.default)
597597
return self._control

0 commit comments

Comments
 (0)