Skip to content

Commit f9dfbd6

Browse files
pupnewfsterDrullkus
authored andcommitted
Update Neo, and fix breaking changes related to configs (#235)
1 parent 2cb8131 commit f9dfbd6

File tree

9 files changed

+25
-13
lines changed

9 files changed

+25
-13
lines changed

build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ plugins {
33
id 'eclipse'
44
id 'idea'
55
id 'org.ajoberstar.grgit.service' version '5.2.2'
6-
id 'net.neoforged.gradle.userdev' version '7.0.142'//https://projects.neoforged.net/neoforged/neogradle
6+
id 'net.neoforged.gradle.userdev' version '7.0.154'//https://projects.neoforged.net/neoforged/neogradle
77
id 'io.freefair.lombok' version '8.6'
88
id 'com.matthewprenger.cursegradle' version '1.4.0'
99
}
1010

1111
tasks.named('wrapper', Wrapper).configure {
1212
//Define wrapper values here so as to not have to always do so when updating gradlew.properties
13-
gradleVersion = '8.8'
13+
gradleVersion = '8.9'
1414
distributionType = Wrapper.DistributionType.ALL
1515
}
1616

@@ -35,10 +35,10 @@ runs {
3535
if (hasProperty('forge_force_ansi')) {
3636
//Force ansi if declared as a gradle variable, as the auto detection doesn't detect IntelliJ properly
3737
// or eclipse's plugin that adds support for ansi escape in console
38-
jvmArguments.add("-Dterminal.ansi=${property('forge_force_ansi')}")
38+
systemProperties.put('terminal.ansi', (String) property('forge_force_ansi'))
3939
}
4040

41-
modSources(sourceSets.main, sourceSets.test)
41+
modSources.add((SourceSet[]) [sourceSets.main, sourceSets.test])
4242

4343
// Recommended logging level for the console
4444
systemProperties.put('forge.logging.console.level', 'debug')

gradle.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
mod_version=1.2.0
22
minecraft_version=1.21
3-
forge_version=21.0.0-beta
3+
forge_version=21.0.86-beta
44

55
curse_type=beta
66
projectId=267602
@@ -12,6 +12,6 @@ org.gradle.jvmargs=-Xmx4G
1212
org.gradle.daemon=false
1313

1414
#NeoGradle Settings
15-
neogradle.subsystems.parchment.minecraftVersion=1.20.6
16-
neogradle.subsystems.parchment.mappingsVersion=2024.06.02
15+
neogradle.subsystems.parchment.minecraftVersion=1.21
16+
neogradle.subsystems.parchment.mappingsVersion=2024.06.23
1717
neogradle.subsystems.conventions.sourcesets.enabled=false

gradle/wrapper/gradle-wrapper.jar

51 Bytes
Binary file not shown.

gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-all.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

gradlew

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gradlew.bat

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main/java/team/chisel/ctm/CTM.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,15 @@ public CTM(ModContainer modContainer, IEventBus modBus) {
4949
TextureTypeRegistry.scan();
5050

5151
definitionManager = new CTMDefinitionManager();
52-
ReloadableResourceManager resourceManager = (ReloadableResourceManager) Minecraft.getInstance().getResourceManager();
53-
resourceManager.registerReloadListener(definitionManager.getReloadListener());
52+
Minecraft minecraft = Minecraft.getInstance();
53+
if (minecraft != null) {
54+
//TODO
55+
// Note: This can be null in datagen. We just skip adding the definition manager, as resources don't actually need
56+
// to be loaded in datagen. Once: https://github.com/neoforged/NeoForge/pull/1289 is merged, we should move to using
57+
// that instead
58+
ReloadableResourceManager resourceManager = (ReloadableResourceManager) minecraft.getResourceManager();
59+
resourceManager.registerReloadListener(definitionManager.getReloadListener());
60+
}
5461
reloadListener = new CTMPackReloadListener();
5562
modBus.addListener(this::reloadListenersLate);
5663
}

src/main/java/team/chisel/ctm/Configurations.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class Configurations {
1616
public static final Configurations INSTANCE = new Configurations();
1717

1818
public static void register(ModContainer modContainer, IEventBus modBus) {
19-
modContainer.addConfig(new ModConfig(Type.CLIENT, INSTANCE.configSpec, modContainer, "ctm.toml"));
19+
modContainer.registerConfig(Type.CLIENT, INSTANCE.configSpec, "ctm.toml");
2020
modBus.addListener(ModConfigEvent.Reloading.class, event -> {
2121
if (event.getConfig().getModId().equals(CTM.MOD_ID)) {
2222
//Only reload when our config changes

src/main/resources/META-INF/neoforge.mods.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ license="GPL-2.0"
2020
[[dependencies.ctm]]
2121
modId="neoforge"
2222
type="required"
23-
versionRange="[21.0.0-beta,)"
23+
versionRange="[21.0.82-beta,)"
2424
ordering="NONE"
2525
side="BOTH"

0 commit comments

Comments
 (0)