Mod compatibility regression: Breaking changes made in KeyboardFix cause OptiFabric 1.13.24 to crash when entering text using the keyboard with Borderless Mining 1.1.1 (1.17.1) or 1.0.6 (1.16.5) installed. #1013
Description
Mod compatibility regression: Breaking changes made in KeyboardFix cause OptiFabric 1.13.24 to crash when entering text using the keyboard with Borderless Mining 1.1.1 (1.17.1) or 1.0.6 (1.16.5) installed.
I've fully bisected this issue, and can confirm that:
- Commit 9a9a804 ("Fix JEI") introduces the conflict with 1.0.6 (1.16.5).
- Commit 647312a ("Fix screenshotting on 1.19.4") introduces the conflict with 1.1.1 (1.17.1).
Stack trace (1.17.1)
java.lang.NoSuchMethodError: 'void net.minecraft.class_309.method_1458(net.minecraft.class_309, int, int, net.minecraft.class_364)'
at net.minecraft.class_309.method_1457(net/fabricmc/fabric/mixin/screen/KeyboardMixin.java [fabric-screen-api-v1.mixins.json]:93) ~[client-intermediary.jar:?]
at net.minecraft.class_309.method_22677(net/fabricmc/fabric/mixin/screen/KeyboardMixin.java [fabric-screen-api-v1.mixins.json]:157) ~[client-intermediary.jar:?]
at net.minecraft.class_1255.execute(class_1255.java:118) ~[client-intermediary.jar:?]
at net.minecraft.class_309.method_22675(net/fabricmc/fabric/mixin/screen/KeyboardMixin.java [fabric-screen-api-v1.mixins.json]:156) ~[client-intermediary.jar:?]
at org.lwjgl.glfw.GLFWCharModsCallbackI.callback(GLFWCharModsCallbackI.java:39) ~[lwjgl-glfw-3.2.2.jar:?]
at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.2.2.jar:?]
at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3174) ~[lwjgl-glfw-3.2.2.jar:?]
at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:188) ~[client-intermediary.jar:?]
at net.minecraft.class_310.method_1523(class_310.java:1140) ~[client-intermediary.jar:?]
at net.minecraft.class_310.method_1514(class_310.java:728) [client-intermediary.jar:?]
at net.minecraft.client.main.Main.main(Main.java:217) [client-intermediary.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:462) [fabric-loader-0.14.18.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.14.18.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.14.18.jar:?]
Stack trace (1.16.5)
java.lang.NoSuchMethodError: net.minecraft.class_309.method_1458(Lnet/minecraft/class_309;IILnet/minecraft/class_364;)V
at java.lang.invoke.MethodHandleNatives.resolve(Native Method) ~[?:1.8.0_51]
at java.lang.invoke.MemberName$Factory.resolve(MemberName.java:962) ~[?:1.8.0_51]
at java.lang.invoke.MemberName$Factory.resolveOrFail(MemberName.java:987) ~[?:1.8.0_51]
at java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:1390) ~[?:1.8.0_51]
at java.lang.invoke.MethodHandles$Lookup.linkMethodHandleConstant(MethodHandles.java:1746) ~[?:1.8.0_51]
at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:477) ~[?:1.8.0_51]
at net.minecraft.class_309.method_1457(link/infra/borderlessmining/mixin/F11FixMixin.java [borderlessmining.mixins.json]:43) ~[client-intermediary.jar:?]
at net.minecraft.class_309.method_22677(link/infra/borderlessmining/mixin/F11FixMixin.java [borderlessmining.mixins.json]:107) ~[client-intermediary.jar:?]
at net.minecraft.class_309$$Lambda$5039/573333268.run(Unknown Source) ~[?:?]
at net.minecraft.class_1255.execute(class_1255.java:111) ~[client-intermediary.jar:?]
at net.minecraft.class_309.method_22675(link/infra/borderlessmining/mixin/F11FixMixin.java [borderlessmining.mixins.json]:106) ~[client-intermediary.jar:?]
at net.minecraft.class_309$$Lambda$4215/2003440397.invoke(Unknown Source) ~[?:?]
at org.lwjgl.glfw.GLFWCharModsCallbackI.callback(GLFWCharModsCallbackI.java:39) ~[lwjgl-glfw-3.2.2.jar:?]
at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.2.2.jar:?]
at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3174) ~[lwjgl-glfw-3.2.2.jar:?]
at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:127) ~[client-intermediary.jar:?]
at net.minecraft.class_310.method_1523(class_310.java:1071) ~[client-intermediary.jar:?]
at net.minecraft.class_310.method_1514(class_310.java:681) [client-intermediary.jar:?]
at net.minecraft.client.main.Main.main(Main.java:215) [client-intermediary.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:462) [fabric-loader-0.14.18.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.14.18.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.14.18.jar:?]