fix: 선택지 수정 벨리데이션 추가

Author: Gwonyeong

src/game-builder/choice/applications/controllers/choice.controller.ts

@@ -68,7 +68,6 @@ export class ChoiceController {
     @Param('choiceId', ParseIntPipe) choiceId: number,
     @Body() body: UpdateChoiceReqDto,
   ): Promise<UpdateChoiceResDto> {
-    console.log(body);
     return await this.updateChoiceUsecase.execute(gameId, choiceId, body);
   }
 

src/game-builder/choice/applications/usecases/update-choice.usecase.ts

@@ -1,10 +1,16 @@
 import { PrismaService } from '@@prisma/prisma.service';
-import { Inject, Injectable, NotFoundException } from '@nestjs/common';
-import { CreateChoiceReqDto } from '../controllers/dto/create-choice.dto';
+import {
+  ConflictException,
+  Inject,
+  Injectable,
+  NotFoundException,
+} from '@nestjs/common';
+
 import { IChoiceService } from '../../domain/port/input/choice.service.interface';
 import { IGameService } from '@@src/game-builder/game/domain/ports/input/game.service.interface';
 import { UpdateChoiceReqDto } from '../controllers/dto/update-choice.dto';
 import { IPageService } from '@@src/game-builder/page/domain/ports/input/page.service.interface';
+import { toGetAllResMapper } from '@@src/game-builder/game/application/usecases/mapper/to-get-all-res.mapper';
 
 @Injectable()
 export class UpdateChoiceUseCase {
@@ -22,12 +28,42 @@ export class UpdateChoiceUseCase {
   ) {
     const game = await this.gameService.getById(gameId);
     if (!game) throw new NotFoundException(`game is null`);
+    const pages = await this.pageService.getAllByGameId(gameId);
+    const choices = await this.choiceService.getAllByPageIds(
+      pages.map((page) => page.id),
+    );
+    if (!game) {
+      throw new NotFoundException('Game not found');
+    }
+
+    const gameTrees = toGetAllResMapper(game, pages, choices);
 
-    const parentPage = await this.pageService.getOneById(
-      createChoiceReqDto.parentPageId,
+    const parentPage = gameTrees.pages.find(
+      (page) => page.id === createChoiceReqDto.parentPageId,
     );
+
     if (!parentPage) throw new NotFoundException(`parentPage is null`);
-    parentPage.checkIsEnding();
+
+    const pageChoice = await this.choiceService.getAllByToPageId(parentPage.id);
+
+    if (pageChoice.length < 1) {
+      throw new ConflictException(
+        '부모 페이지가 없으면 선택지를 만들 수 없습니다.',
+      );
+    }
+
+    if (parentPage.isEnding) {
+      throw new ConflictException('종료 페이지는 선택지를 만들 수 없습니다.');
+    }
+
+    if (
+      createChoiceReqDto.childPageId &&
+      parentPage.fromPageIds.includes(createChoiceReqDto.childPageId)
+    ) {
+      throw new ConflictException(
+        '자식 페이지는 부모 페이지가 될 수 없습니다.',
+      );
+    }
 
     if (createChoiceReqDto.childPageId) {
       const childPage = await this.pageService.getOneById(

src/game-builder/game/application/controllers/dto/get-all-game.dto.ts

@@ -21,6 +21,7 @@ type Page = {
     url: string | null;
   };
   choices: Choice[];
+  fromPageIds: number[];
 };
 
 export class GetAllGameResDto {

src/game-builder/game/application/usecases/mapper/to-get-all-res.mapper.ts

@@ -25,7 +25,11 @@ export const toGetAllResMapper = (
     throw new NotFoundException('Starting page not found');
   }
 
-  const dfs = (page: PageDomainEntity, depth: number) => {
+  const dfs = (
+    page: PageDomainEntity,
+    depth: number,
+    fromPageIds: number[],
+  ) => {
     if (!page) {
       return;
     }
@@ -47,12 +51,15 @@ export const toGetAllResMapper = (
       },
       contents: page.contents,
       depth,
+      fromPageIds,
       choices: childChoices,
     });
-    childPages.forEach((childPage) => dfs(childPage, depth + 1));
+    childPages.forEach((childPage) =>
+      dfs(childPage, depth + 1, [...fromPageIds, page.id]),
+    );
   };
 
-  dfs(startingPage, 1);
+  dfs(startingPage, 1, []);
 
   // 선택지가 연결되지 않은 페이지
   // parentId와 childId가 모두 존재하지 않는 페이지
@@ -77,6 +84,7 @@ export const toGetAllResMapper = (
       isEnding: page.isEnding,
       depth: -1,
       choices: [],
+      fromPageIds: [],
     });
   }