feat: add strong PHP Types, cleanup

Author: Chris8934

src/ProviderFactory/PluginProviderFactory.php

@@ -14,6 +14,7 @@
 
 use Geocoder\Plugin\Plugin;
 use Geocoder\Plugin\PluginProvider;
+use Geocoder\Provider\Provider;
 
 /**
  * This factory creates a PluginProvider.
@@ -23,19 +24,17 @@
 final class PluginProviderFactory
 {
     /**
-     * @param Plugin[]                          $plugins
-     * @param callable|ProviderFactoryInterface $factory
-     * @param array<mixed>                      $config                config to the client factory
-     * @param array{max_restarts?: int<0, max>} $pluginProviderOptions config forwarded to the PluginProvider
+     * @param Plugin[]                                          $plugins
+     * @param callable(array):Provider|ProviderFactoryInterface $factory
+     * @param array<mixed>                                      $config                config to the client factory
+     * @param array{max_restarts?: int<0, max>}                 $pluginProviderOptions config forwarded to the PluginProvider
      */
     public static function createPluginProvider(array $plugins, callable|ProviderFactoryInterface $factory, array $config, array $pluginProviderOptions = []): PluginProvider
     {
         if ($factory instanceof ProviderFactoryInterface) {
             $client = $factory->createProvider($config);
-        } elseif (is_callable($factory)) {
-            $client = $factory($config);
         } else {
-            throw new \RuntimeException(sprintf('Second argument to PluginProviderFactory::createPluginProvider must be a "%s" or a callable.', ProviderFactoryInterface::class));
+            $client = $factory($config);
         }
 
         return new PluginProvider($client, $plugins, $pluginProviderOptions);

src/Validator/Constraint/Address.php

@@ -31,16 +31,9 @@ class Address extends Constraint
 
     public string $service = AddressValidator::class;
 
-    public string $message = 'Address {{ address }} is not valid.';
-
-    /**
-     * @param string[]|null $options
-     */
-    public function __construct(?array $options = null, ?string $message = null, ?array $groups = null, $payload = null)
+    public function __construct(public string $message = 'Address {{ address }} is not valid.', ?array $groups = null, $payload = null)
     {
-        parent::__construct($options, $groups, $payload);
-
-        $this->message = $message ?? $this->message;
+        parent::__construct(null, $groups, $payload);
     }
 
     public function validatedBy(): string