consolidate lint warning suppressions to the module plugin

Author: ChrisHegarty

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/ElasticsearchJavaModulePlugin.java

@@ -92,6 +92,8 @@ static void configureCompileModulePath(Project project) {
         }).getFiles();
 
         project.getTasks().named("compileJava", JavaCompile.class).configure(task -> {
+            task.getOptions().getCompilerArgs().add("-Xlint:-module,-exports,-requires-automatic,-requires-transitive-automatic");
+
             var argumentProvider = new CompileModulePathArgumentProvider(isModuleProject, moduleCompileClasspath);
             task.getOptions().getCompilerArgumentProviders().add(argumentProvider);
             FileCollection classpath = task.getClasspath();

libs/cli/build.gradle

@@ -20,7 +20,3 @@ tasks.named("jarHell").configure { enabled = false }
 tasks.named('forbiddenApisMain').configure {
   replaceSignatureFiles 'jdk-signatures'
 }
-
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-exports,-requires-automatic,-requires-transitive-automatic")
-}

libs/core/build.gradle

@@ -41,7 +41,3 @@ tasks.named("thirdPartyAudit").configure {
           'org/osgi/framework/wiring/BundleWiring'
   )
 }
-
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-module,-exports,-requires-automatic,-requires-transitive-automatic")
-}

libs/lz4/build.gradle

@@ -31,7 +31,3 @@ tasks.named("thirdPartyAudit").configure {
     'net.jpountz.util.UnsafeUtils'
   )
 }
-
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-module,-exports,-requires-automatic,-requires-transitive-automatic")
-}

libs/ssl-config/build.gradle

@@ -19,10 +19,6 @@ dependencies {
   testImplementation "org.hamcrest:hamcrest:${versions.hamcrest}"
 }
 
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-exports,-missing-explicit-ctor")
-}
-
 tasks.named('forbiddenApisMain').configure {
   replaceSignatureFiles 'jdk-signatures'
 }

libs/x-content/build.gradle

@@ -66,10 +66,6 @@ tasks.named("dependencyLicenses").configure {
   mapping from: /jackson-.*/, to: 'jackson'
 }
 
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-exports")
-}
-
 File generatedResourcesDir = new File(buildDir, 'generated-resources')
 def generateProviderManifest = tasks.register("generateProviderManifest") {
   File manifestFile = new File(generatedResourcesDir, "LISTING.TXT")

modules/aggs-matrix-stats/build.gradle

@@ -18,7 +18,3 @@ restResources {
     include '_common', 'indices', 'cluster', 'index', 'search', 'nodes'
   }
 }
-
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-exports,-missing-explicit-ctor")
-}

modules/lang-painless/build.gradle

@@ -54,10 +54,6 @@ restResources {
     }
 }
 
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-exports,-requires-automatic,-missing-explicit-ctor")
-}
-
 tasks.named("test").configure {
     // in WhenThingsGoWrongTests we intentionally generate an out of memory error, this prevents the heap from being dumped to disk
     jvmArgs '-XX:-OmitStackTraceInFastThrow', '-XX:-HeapDumpOnOutOfMemoryError'

modules/lang-painless/spi/build.gradle

@@ -16,7 +16,3 @@ dependencies {
   compileOnly project(":server")
   testImplementation project(":test:framework")
 }
-
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-exports")
-}

modules/percolator/build.gradle

@@ -24,10 +24,6 @@ restResources {
   }
 }
 
-tasks.named("compileJava").configure {
-  options.compilerArgs.add("-Xlint:-exports,-missing-explicit-ctor")
-}
-
 tasks.named("yamlRestTestV7CompatTransform").configure{ task ->
   task.addAllowedWarningRegex("\\[types removal\\].*")
 }