Dividing files into smaller modules

[jeevithakannan2]

Should we split the files into small modes for modularity and maintainability ?

For example seperating the draw function and handle_function from state.rs into separate files as ui.rs and keybindings.rs and having a parent module as app state

Summoning the gods here @ChrisTitusTech @lj3954 @adamperkowski @cartercanedy @nnyyxxxx @JustLinuxUser @afonsofrancof

[adamperkowski]

Yea I think that's a good idea. I always split things like that in my projects.

[cartercanedy]

Totally, I'd just wait until we start paring down that list of 73 PRs

[jeevithakannan2]

Yeah I will start working on splitting state.rs.

app_state.rs ( App state focus enum, list entry struct and new fn)

hints.rs ( keybinding hints )
keybindings.rs ( handle_keys )

misc.rs ( Functions like selected_item_is_cmd, enable_preview, refresh_tab, etc )
mod.rs ( module )
ui.rs ( draw function )
tips.rs ( cool tips )

This what I was thinking about, is this overkill ?? or is it okay ??

[cartercanedy]

Yeah, @nnyyxxxx has a point. I don't really want to get to a point that this becomes like every other C# project with only a single struct/impl per file, that's the absolute worst imho

[cartercanedy]

That's not to say that you shouldn't do this, but let's not go hog wild with it

[jeevithakannan2]

If you have suggestions they are welcome. That's why I am here

[jeevithakannan2]

I will merge Focus and ListEntry with AppState. Other files have their core functionality which cannot be merged with other files. Maybe hints and keybindings can be merged. If you guys have any suggestions let me know !!

[adamperkowski]

Yeah, @nnyyxxxx has a point. I don't really want to get to point that this become like every other C# project with only a single struct/impl per file, that's the absolute worst imho

That's not to say that you shouldn't do this, but let's not go hog wild with it

Yeah I kinda agree