perf: increase rendering efficiency#1017
Merged
ChrisTitusTech merged 3 commits intoChrisTitusTech:mainfrom Feb 28, 2025
Merged
Conversation
koibtw
approved these changes
Feb 7, 2025
Collaborator
koibtw
left a comment
There was a problem hiding this comment.
not sure i'm 100% with you on using atomic but still the improvement is huge. thanks!
Contributor
Author
I used an atomic, because:
But I would like to know why you don't like the usage of the global atomic. Mb there is a better solution that I am not seeing?. Ty |
Collaborator
not saying i don't like it being there. it's more about when i see atomic i'm like:
+ it might be a little bit overkill |
ChrisTitusTech
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This small PR, makes, so that the UI is not re-rendered, unless an event is detected. The event might be a terminal event (keypress, mouse moved, resize, etc.)
Or if a terminal is open, if some new input came in from the terminal
Testing
Before: 50% CPU usage on my machine with debug on
After: 1% CPU usage on my machine with debug on
Impact
It doesn't impact the performance of the app, it will run just as fast as before, but it affects it's efficiency, so it's not re-rendered unless it should be.
Additional Information
I am not aware of any possible side effects this might create, but if in the future we want to implement something like an animation system, it will complicate it a little.