fix: scroll down not reaching the bottom entry#961
Closed
jeevithakannan2 wants to merge 2 commits intoChrisTitusTech:mainfrom
Closed
fix: scroll down not reaching the bottom entry#961jeevithakannan2 wants to merge 2 commits intoChrisTitusTech:mainfrom
jeevithakannan2 wants to merge 2 commits intoChrisTitusTech:mainfrom
Conversation
lj3954
suggested changes
Nov 21, 2024
Contributor
lj3954
left a comment
lj3954
left a comment
There was a problem hiding this comment.
Variable name could be a little more clear.
Co-authored-by: Liam <33645555+lj3954@users.noreply.github.com>
lj3954
approved these changes
Nov 22, 2024
koibtw
changed the title
koibtw
approved these changes
Nov 22, 2024
4 tasks
|
what do you think about the changes in #1015 it also includes this fix with refactoring of both scroll up and down functions |
|
the code looks a lot better now, and is more readable. Do you want me to drop these changes? since they are kind of duplicating the changes in this merge request. |
ghost
mentioned this pull request
|
superseded by #1015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Testing
Issues
Checklist