refactor(shortcuts): creation macro#973
Merged
ChrisTitusTech merged 2 commits intoChrisTitusTech:mainfrom Feb 2, 2025
Merged
Conversation
jeevithakannan2
approved these changes
Dec 1, 2024
afonsofrancof
approved these changes
Dec 6, 2024
koibtw
changed the title
koibtw
approved these changes
Dec 17, 2024
lj3954
changed the title
Contributor
Author
|
This is not a feature addition, it's a refactoring. |
ChrisTitusTech
approved these changes
Jan 10, 2025
Owner
|
@lj3954 clippy not happy with during Lint. Once those are clean I'll merge. Thanks for the PR! |
Contributor
Author
|
Linting issue should have nothing to do with this branch, it's caused by preexisting issues that were fixed by #971. This should fix it. |
ChrisTitusTech
approved these changes
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Improve code readability by replacing manual shortcut initialization with a macro.
Checklist