Skip to content

Feature/notion support#3619

Closed
ZeusCraft10 wants to merge 7 commits intoChrisTitusTech:mainfrom
ZeusCraft10:feature/notion-support
Closed

Feature/notion support#3619
ZeusCraft10 wants to merge 7 commits intoChrisTitusTech:mainfrom
ZeusCraft10:feature/notion-support

Conversation

@ZeusCraft10
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

This pull request adds support for installing and updating the Notion desktop app through Winutil. The change introduces a new entry for Notion in config/applications.json, allowing users to manage Notion using WinGet or Chocolatey. Notion is a popular productivity and note-taking tool. This addresses user feature request #3576.

Testing

  • Verified that Notion appears in the applications list.
  • Confirmed installation and update via WinGet and Chocolatey on a test environment.
  • Performed self-review of the code changes.

Impact

  • Adds a new productivity application to Winutil.
  • No impact on performance or existing dependencies.
  • No breaking changes; increases available app options.

Issue related to PR

Additional Information

No additional information.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

…rors

Ensure binary directory exists before compile step to prevent path errors

Extended Description:
This commit adds a workflow step to `.github/workflows/compile-check.yaml` that checks for the existence of the `D:\a\winutil\winutil\binary\` directory before any compile or syntax check steps are executed. If the directory does not exist, it is created automatically. This change prevents job failures caused by missing directories when scripts attempt to enumerate or access files in the binary path.

The added PowerShell step uses `Test-Path` to check for the directory and creates it using `New-Item` only if it's missing. This is especially important for clean runners and first-time builds, where the directory may not be present by default.

By ensuring the directory is always available, this commit improves workflow reliability and prevents errors such as:
> The job failed because it could not find the path 'D:\a\winutil\winutil\binary\'.

No changes are made to the compile logic itself; only the environment setup is improved. This fix is safe, has no side effects, and is compatible with all existing steps and scripts that expect the binary directory to be present.
@ZeusCraft10
Copy link
Contributor Author

Ensure binary directory exists before compile step to prevent path errors

Extended Description:
This commit adds a workflow step to .github/workflows/compile-check.yaml that checks for the existence of the D:\a\winutil\winutil\binary\ directory before any compile or syntax check steps are executed. If the directory does not exist, it is created automatically. This change prevents job failures caused by missing directories when scripts attempt to enumerate or access files in the binary path.

The added PowerShell step uses Test-Path to check for the directory and creates it using New-Item only if it's missing. This is especially important for clean runners and first-time builds, where the directory may not be present by default.

By ensuring the directory is always available, this commit improves workflow reliability and prevents errors such as:

The job failed because it could not find the path 'D:\a\winutil\winutil\binary'.

No changes are made to the compile logic itself; only the environment setup is improved. This fix is safe, has no side effects, and is compatible with all existing steps and scripts that expect the binary directory to be present.

@CodingWonders
Copy link
Contributor

This looks AI-made.

@ZeusCraft10
Copy link
Contributor Author

This looks AI-made.

The descriptions are in fact AI made. I suck at following templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

could you add Notion support?

3 participants