Skip to content

Commit d96a7b9

Browse files
Merge pull request #280 from ChrispyBacon-dev/unstable
Fix for No TLS Verify Bug
2 parents df16f80 + cc22414 commit d96a7b9

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

.github/workflows/docker-image.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
build_self_hosted:
2525
runs-on: self-hosted
2626

27-
timeout-minutes: 5
27+
timeout-minutes: 3
2828
steps:
2929
- name: Checkout repository
3030
uses: actions/checkout@v4

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
6262
- **Prevention of unsafe configurations:** System now prevents creation of policies where "any user with selected IdP" (e.g., any Google account) could access protected services
6363
- **Clear error messaging:** Users receive actionable security warnings explaining why email addresses are required with IdP authentication
6464
- **Result:** Eliminates accidental creation of overly permissive access policies that could expose services to unauthorized users
65+
- **Agent No TLS Verify Bug:** Fixed bug where `dockflare.no_tls_verify=true` label was ignored when Agent containers started.
6566

6667
### Documentation
6768
- **CLI Usage Guide:** Created comprehensive [CLI_USAGE.md](CLI_USAGE.md) documenting the duplicate policy cleanup utility with examples, safety features, and best practices for advanced users.

dockflare/app/core/state_manager.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ def load_state():
141141
rule_copy.setdefault("access_group_id", None)
142142
rule_copy.setdefault("tunnel_id", None)
143143
rule_copy.setdefault("zone_name", None)
144+
rule_copy.setdefault("no_tls_verify", False)
145+
rule_copy.setdefault("origin_server_name", None)
144146

145147
tunnel_name = rule_copy.get("tunnel_name")
146148
if not tunnel_name or tunnel_name == "dockflare-tunnel":

dockflare/app/web/api_v2_routes.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,15 +1076,15 @@ def process_agent_container_start(payload, agent_id):
10761076
logging.error(f"AGENT_PROCESS: Could not determine Zone ID for DNS record {hostname_dns}")
10771077

10781078
from app.core.state_manager import get_agent_rules
1079+
from app.core.tunnel_manager import _build_ingress_entry_from_rule
10791080
agent_rules = get_agent_rules(agent_id)
1080-
1081+
10811082
ingress_rules = []
10821083
for rule_key, rule in agent_rules.items():
10831084
if rule.get("status") == "active":
1084-
entry = {"hostname": rule["hostname"], "service": rule["service"]}
1085-
if rule.get("path"):
1086-
entry["path"] = rule["path"]
1087-
ingress_rules.append(entry)
1085+
entry = _build_ingress_entry_from_rule(rule)
1086+
if entry:
1087+
ingress_rules.append(entry)
10881088
ingress_rules.append({"service": "http_status:404"})
10891089
account_id = current_app.config.get('CF_ACCOUNT_ID')
10901090
endpoint = f"/accounts/{account_id}/cfd_tunnel/{agent_tunnel_id}/configurations"

0 commit comments

Comments
 (0)