[bug] fix stale chart when multiple registries, and stale values in image when discovering tag (#142)

Author: ChristofferNissen

pkg/helm/chartImportOption.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"log/slog"
+	"os"
 	"sort"
 
 	"github.com/ChristofferNissen/helmper/pkg/image"
@@ -264,6 +265,7 @@ func (opt ChartImportOption) Run(ctx context.Context, setters ...Option) error {
 								return fmt.Errorf("helm: error pushing and modifying chart %s to registry %s :: %w", c.Name, r.URL, err)
 							}
 							slog.Debug(res)
+							defer os.RemoveAll(res)
 							_ = bar.Add(1)
 							return nil
 						}

pkg/helm/chartOption.go

@@ -42,7 +42,10 @@ type ChartOption struct {
 func determineTag(ctx context.Context, img *image.Image, plainHTTP bool) bool {
 	ctx = context.WithoutCancel(ctx)
 	ref := img.String()
-	tag, _ := img.TagOrDigest()
+	tag, err := img.TagOrDigest()
+	if err != nil {
+		return false
+	}
 
 	available, _ := registry.Exist(ctx, ref, tag, plainHTTP)
 	if available {
@@ -394,6 +397,7 @@ func (co *ChartOption) Run(ctx context.Context, setters ...Option) (ChartData, e
 
 							plainHTTP := strings.Contains(i.Registry, "localhost") || strings.Contains(i.Registry, "0.0.0.0")
 							available := determineTag(egCtx, i, plainHTTP)
+							i.ResetParsedRef()
 
 							// send availability response
 							channel <- &imageInfo{available, c, i, &helmValuePaths}

pkg/image/image.go

@@ -63,6 +63,11 @@ type Image struct {
 	parsedRef  *string
 }
 
+func (i *Image) ResetParsedRef() {
+	// Remove the assignment to i.parsedRef
+	i.parsedRef = nil
+}
+
 // IsEmpty determines if an image is empty (i.e., registry, repository, and name are empty).
 func (i Image) IsEmpty() bool {
 	return i.Registry == "" && i.Repository == "" && i.Tag == ""