[feat] fail on missing images (#150)

* add option to fail on missing valuesPaths

* refactor check to happen in viper bootstrap

* add option to fail on unavailable images in helm charts

Author: ChristofferNissen

example/helmper.yaml

@@ -6,6 +6,7 @@ parser:
   disableImageDetection: false
   useCustomValues: false
   failOnMissingValues: false
+  failOnMissingImages: false
 mirrors:
   - registry: docker.io
     mirror: example.azurecr.io/docker/

internal/bootstrap/viper.go

@@ -79,6 +79,7 @@ type ParserConfigSection struct {
 	DisableImageDetection bool `yaml:"disableImageDetection"`
 	UseCustomValues       bool `yaml:"useCustomValues"`
 	FailOnMissingValues   bool `yaml:"failOnMissingValues"`
+	FailOnMissingImages   bool `yaml:"failOnMissingImages"`
 }
 
 type MirrorConfigSection struct {

internal/program.go

@@ -116,9 +116,10 @@ func program(ctx context.Context, _ []string, viper *viper.Viper, settings *cli.
 	// STEP 2: Find images in Helm Charts and dependencies
 	slog.Debug("Starting parsing user specified chart(s) for images..")
 	co := helm.ChartOption{
-		ChartCollection: charts,
-		IdentifyImages:  !parserConfig.DisableImageDetection,
-		UseCustomValues: parserConfig.UseCustomValues,
+		ChartCollection:     charts,
+		IdentifyImages:      !parserConfig.DisableImageDetection,
+		UseCustomValues:     parserConfig.UseCustomValues,
+		FailOnMissingImages: parserConfig.FailOnMissingImages,
 
 		Mirrors: bootstrap.ConvertToHelmMirrors(mirrorConfig),
 		Images:  images,
@@ -152,7 +153,6 @@ func program(ctx context.Context, _ []string, viper *viper.Viper, settings *cli.
 
 	// Step 4: Import charts to registries
 	if importConfig.Import.Enabled {
-		ctx := context.WithoutCancel(ctx)
 		err := helm.ChartImportOption{
 			Data:           mCharts,
 			All:            all,

pkg/helm/chartOption.go

@@ -26,9 +26,10 @@ import (
 )
 
 type ChartOption struct {
-	ChartCollection *ChartCollection
-	IdentifyImages  bool
-	UseCustomValues bool
+	ChartCollection     *ChartCollection
+	IdentifyImages      bool
+	UseCustomValues     bool
+	FailOnMissingImages bool
 
 	Mirrors []Mirror
 	Images  []image.Image
@@ -417,14 +418,17 @@ func (co *ChartOption) Run(ctx context.Context, setters ...Option) (ChartData, e
 		return channel
 	}
 
-	imageCollector := func(imgs <-chan *imageInfo) ChartData {
+	imageCollector := func(imgs <-chan *imageInfo) (ChartData, error) {
 		chartImageHelmValuesMap := make(ChartData)
 		id := 0
 
 		for i := range imgs {
 			if !i.available {
 				str := i.image.String()
 				slog.Info("Image not available. will be excluded from import...", slog.String("image", str))
+				if co.FailOnMissingImages {
+					return nil, xerrors.New("image not available")
+				}
 				continue
 			}
 
@@ -453,30 +457,33 @@ func (co *ChartOption) Run(ctx context.Context, setters ...Option) (ChartData, e
 			id = id + 1
 		}
 
-		return chartImageHelmValuesMap
+		return chartImageHelmValuesMap, nil
 	}
 
-	workload := func(c *ChartCollection) ChartData {
+	workload := func(c *ChartCollection) (ChartData, error) {
 		if co.IdentifyImages {
 			return imageCollector(
 				imageGenerator(
 					chartGenerator(c),
 				),
 			)
 		}
-		return chartCollector(chartGenerator(c))
+		return chartCollector(chartGenerator(c)), nil
 	}
 
-	cd := workload(co.ChartCollection)
+	cd, err := workload(co.ChartCollection)
+	if err != nil {
+		return nil, err
+	}
 
 	if err := eg.Wait(); err != nil {
-		return ChartData{}, err
+		return nil, err
 	}
 
 	// Replace mirrors for further processing
-	err := replaceWithMirrors(&cd, co.Mirrors)
+	err = replaceWithMirrors(&cd, co.Mirrors)
 	if err != nil {
-		return ChartData{}, err
+		return nil, err
 	}
 
 	if len(co.Images) > 0 {