Skip to content

Commit 0624029

Browse files
authored
fix: improve navigate_page_history error messages (#321)
1 parent f415c3e commit 0624029

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

src/tools/pages.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,15 +142,16 @@ export const navigatePageHistory = defineTool({
142142
const options = {
143143
timeout: request.params.timeout,
144144
};
145+
145146
try {
146147
if (request.params.navigate === 'back') {
147148
await page.goBack(options);
148149
} else {
149150
await page.goForward(options);
150151
}
151-
} catch {
152+
} catch (error) {
152153
response.appendResponseLine(
153-
`Unable to navigate ${request.params.navigate} in currently selected page.`,
154+
`Unable to navigate ${request.params.navigate} in currently selected page. ${error.message}`,
154155
);
155156
}
156157

tests/tools/pages.test.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,12 @@ describe('pages', () => {
163163
context,
164164
);
165165

166-
assert.equal(
167-
response.responseLines.at(0),
168-
'Unable to navigate forward in currently selected page.',
166+
assert.ok(
167+
response.responseLines
168+
.at(0)
169+
?.startsWith(
170+
'Unable to navigate forward in currently selected page.',
171+
),
169172
);
170173
assert.ok(response.includePages);
171174
});
@@ -178,9 +181,10 @@ describe('pages', () => {
178181
context,
179182
);
180183

181-
assert.equal(
182-
response.responseLines.at(0),
183-
'Unable to navigate back in currently selected page.',
184+
assert.ok(
185+
response.responseLines
186+
.at(0)
187+
?.startsWith('Unable to navigate back in currently selected page.'),
184188
);
185189
assert.ok(response.includePages);
186190
});

0 commit comments

Comments
 (0)