Merge branch 'main' into feat/list-network-requests-parameters

OzTamir · web-flow · commit 11deb4da0122 · 2025-09-24T11:44:38.000+03:00
diff --git a/.github/workflows/publish-to-npm-on-tag.yml b/.github/workflows/publish-to-npm-on-tag.yml
@@ -65,6 +65,9 @@ jobs:
       - name: Build
         run: npm run build
 
+      - name: Bump
+        run: npm run sync-server-json-version
+
       - name: Install MCP Publisher
         run: |
           curl -L "https://github.com/modelcontextprotocol/registry/releases/download/v1.1.0/mcp-publisher_1.1.0_$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/').tar.gz" | tar xz mcp-publisher
diff --git a/.release-please-manifest.json b/.release-please-manifest.json
@@ -1,3 +1,3 @@
 {
-  ".": "0.2.3"
+  ".": "0.2.6"
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,26 @@
 # Changelog
 
+## [0.2.6](https://github.com/ChromeDevTools/chrome-devtools-mcp/compare/chrome-devtools-mcp-v0.2.5...chrome-devtools-mcp-v0.2.6) (2025-09-24)
+
+
+### Bug Fixes
+
+* manually bump server.json versions based on package.json ([#105](https://github.com/ChromeDevTools/chrome-devtools-mcp/issues/105)) ([cae1cf1](https://github.com/ChromeDevTools/chrome-devtools-mcp/commit/cae1cf13d5a97add3b96f20c425f720a1ceabf94))
+
+## [0.2.5](https://github.com/ChromeDevTools/chrome-devtools-mcp/compare/chrome-devtools-mcp-v0.2.4...chrome-devtools-mcp-v0.2.5) (2025-09-24)
+
+
+### Bug Fixes
+
+* add mcpName to package.json ([#103](https://github.com/ChromeDevTools/chrome-devtools-mcp/issues/103)) ([bd0351f](https://github.com/ChromeDevTools/chrome-devtools-mcp/commit/bd0351fd36ae35e41e613f0d15df40aeca17ba94))
+
+## [0.2.4](https://github.com/ChromeDevTools/chrome-devtools-mcp/compare/chrome-devtools-mcp-v0.2.3...chrome-devtools-mcp-v0.2.4) (2025-09-24)
+
+
+### Bug Fixes
+
+* forbid closing the last page ([#90](https://github.com/ChromeDevTools/chrome-devtools-mcp/issues/90)) ([0ca2434](https://github.com/ChromeDevTools/chrome-devtools-mcp/commit/0ca2434a29eb4bc6e570a4ebe21a135d85f4c0f3))
+
 ## [0.2.3](https://github.com/ChromeDevTools/chrome-devtools-mcp/compare/chrome-devtools-mcp-v0.2.2...chrome-devtools-mcp-v0.2.3) (2025-09-24)
 
 
diff --git a/docs/tool-reference.md b/docs/tool-reference.md
@@ -116,7 +116,7 @@
 
 ### `close_page`
 
-**Description:** Closes the page by its index.
+**Description:** Closes the page by its index. The last open page cannot be closed.
 
 **Parameters:**
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "chrome-devtools-mcp",
-  "version": "0.2.3",
+  "version": "0.2.6",
   "description": "MCP server for Chrome DevTools",
   "type": "module",
   "bin": "./build/src/index.js",
@@ -18,7 +18,8 @@
     "test:only": "npm run build && node --require ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-reporter spec --test-force-exit --test --test-only \"build/tests/**/*.test.js\"",
     "test:only:no-build": "node --require ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-reporter spec --test-force-exit --test --test-only \"build/tests/**/*.test.js\"",
     "test:update-snapshots": "npm run build && node --require ./build/tests/setup.js --no-warnings=ExperimentalWarning --test-force-exit --test --test-update-snapshots \"build/tests/**/*.test.js\"",
-    "prepare": "node --experimental-strip-types scripts/prepare.ts"
+    "prepare": "node --experimental-strip-types scripts/prepare.ts",
+    "sync-server-json-version": "node  --experimental-strip-types scripts/sync-server-json-version.ts && npm run format"
   },
   "files": [
     "build/src",
@@ -33,6 +34,7 @@
     "url": "https://github.com/ChromeDevTools/chrome-devtools-mcp/issues"
   },
   "homepage": "https://github.com/ChromeDevTools/chrome-devtools-mcp#readme",
+  "mcpName": "io.github.ChromeDevTools/chrome-devtools-mcp",
   "dependencies": {
     "@modelcontextprotocol/sdk": "1.18.1",
     "debug": "4.4.3",
diff --git a/scripts/sync-server-json-version.ts b/scripts/sync-server-json-version.ts
@@ -0,0 +1,16 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+import fs from 'node:fs';
+
+const packageJson = JSON.parse(fs.readFileSync('./package.json', 'utf-8'));
+const serverJson = JSON.parse(fs.readFileSync('./server.json', 'utf-8'));
+
+serverJson.version = packageJson.version;
+for (const pkg of serverJson.packages) {
+  pkg.version = packageJson.version;
+}
+
+fs.writeFileSync('./server.json', JSON.stringify(serverJson, null, 2));
diff --git a/server.json b/server.json
@@ -1,23 +1,23 @@
 {
-  "$schema": "https://static.modelcontextprotocol.io/schemas/2025-07-09/server.schema.json",
+  "$schema": "https://static.modelcontextprotocol.io/schemas/2025-09-16/server.schema.json",
   "name": "io.github.ChromeDevTools/chrome-devtools-mcp",
   "description": "MCP server for Chrome DevTools",
   "status": "active",
   "repository": {
     "url": "https://github.com/ChromeDevTools/chrome-devtools-mcp",
     "source": "github"
   },
-  "version": "0.2.1",
+  "version": "0.2.5",
   "packages": [
     {
-      "registry_type": "npm",
-      "registry_base_url": "https://registry.npmjs.org",
+      "registryType": "npm",
+      "registryBaseUrl": "https://registry.npmjs.org",
       "identifier": "chrome-devtools-mcp",
-      "version": "0.2.1",
+      "version": "0.2.5",
       "transport": {
         "type": "stdio"
       },
-      "environment_variables": []
+      "environmentVariables": []
     }
   ]
 }
diff --git a/src/McpContext.ts b/src/McpContext.ts
@@ -131,6 +131,16 @@ export class McpContext implements Context {
     this.#consoleCollector.addPage(page);
     return page;
   }
+  async closePage(pageIdx: number): Promise<void> {
+    if (this.#pages.length === 1) {
+      throw new Error(
+        'Unable to close the last page in the browser. It is fine to keep the last page open.',
+      );
+    }
+    const page = this.getPageByIdx(pageIdx);
+    this.setSelectedPageIdx(0);
+    await page.close({runBeforeUnload: false});
+  }
 
   getNetworkRequestByUrl(url: string): HTTPRequest {
     const requests = this.getNetworkRequests();
diff --git a/src/tools/ToolDefinition.ts b/src/tools/ToolDefinition.ts
@@ -72,6 +72,7 @@ export type Context = Readonly<{
   clearDialog(): void;
   getPageByIdx(idx: number): Page;
   newPage(): Promise<Page>;
+  closePage(pageIdx: number): Promise<void>;
   setSelectedPageIdx(idx: number): void;
   getElementByUid(uid: string): Promise<ElementHandle<Element>>;
   setNetworkConditions(conditions: string | null): void;
diff --git a/src/tools/pages.ts b/src/tools/pages.ts
@@ -45,7 +45,7 @@ export const selectPage = defineTool({
 
 export const closePage = defineTool({
   name: 'close_page',
-  description: `Closes the page by its index.`,
+  description: `Closes the page by its index. The last open page cannot be closed.`,
   annotations: {
     category: ToolCategories.NAVIGATION_AUTOMATION,
     readOnlyHint: false,
@@ -58,9 +58,7 @@ export const closePage = defineTool({
       ),
   },
   handler: async (request, response, context) => {
-    const page = context.getPageByIdx(request.params.pageIdx);
-    context.setSelectedPageIdx(0);
-    await page.close({runBeforeUnload: false});
+    await context.closePage(request.params.pageIdx);
     response.setIncludePages(true);
   },
 });
diff --git a/tests/tools/pages.test.ts b/tests/tools/pages.test.ts
@@ -53,6 +53,21 @@ describe('pages', () => {
         assert.ok(response.includePages);
       });
     });
+    it('cannot close the last page', async () => {
+      await withBrowser(async (response, context) => {
+        const page = context.getSelectedPage();
+        try {
+          await closePage.handler({params: {pageIdx: 0}}, response, context);
+          assert.fail('not reached');
+        } catch (err) {
+          assert.strictEqual(
+            err.message,
+            'Unable to close the last page in the browser. It is fine to keep the last page open.',
+          );
+        }
+        assert.ok(!page.isClosed());
+      });
+    });
   });
   describe('browser_select_page', () => {
     it('selects a page', async () => {

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- ".": "0.2.3"`
	`2`	`+ ".": "0.2.6"`
`3`	`3`	`}`