Fix: add dialog handling instruction in McpResponse.format

Author: yasirusman85

src/McpResponse.ts

@@ -7,20 +7,24 @@ import type {
   ImageContent,
   TextContent,
 } from '@modelcontextprotocol/sdk/types.js';
-import type {ResourceType} from 'puppeteer-core';
+import type { ResourceType } from 'puppeteer-core';
 
-import {formatConsoleEvent} from './formatters/consoleFormatter.js';
+import { formatConsoleEvent } from './formatters/consoleFormatter.js';
 import {
   getFormattedHeaderValue,
   getShortDescriptionForRequest,
   getStatusFromRequest,
 } from './formatters/networkFormatter.js';
-import {formatA11ySnapshot} from './formatters/snapshotFormatter.js';
-import type {McpContext} from './McpContext.js';
-import type {ImageContentData, Response} from './tools/ToolDefinition.js';
-import {paginate, type PaginationOptions} from './utils/pagination.js';
+import { formatA11ySnapshot } from './formatters/snapshotFormatter.js';
+import type { McpContext } from './McpContext.js';
+import type { ImageContentData, Response } from './tools/ToolDefinition.js';
+import { paginate, type PaginationOptions } from './utils/pagination.js';
 
 export class McpResponse implements Response {
+  // ✅ added properties here (not duplicated)
+  public consoleMessages: any[] = [];
+  public cleanedConsoleData: string[] = [];
+
   #includePages = false;
   #includeSnapshot = false;
   #attachedNetworkRequestUrl?: string;
@@ -70,6 +74,30 @@ export class McpResponse implements Response {
 
   setIncludeConsoleData(value: boolean): void {
     this.#includeConsoleData = value;
+    if (value) {
+      const raw = this.consoleMessages ?? [];
+
+      const seen = new Set<string>();
+      const cleaned: string[] = [];
+
+      for (const entry of raw) {
+        let text =
+          typeof entry === 'string'
+            ? entry
+            : entry.text ?? JSON.stringify(entry);
+        text = text.replace(/\bt=\d+(?::\d+){0,2}\b/g, '');
+        text = text.replace(/\bLog>\b/g, '');
+        text = text.replace(/\s+/g, ' ').trim();
+        if (!text) continue;
+        if (seen.has(text)) continue;
+        seen.add(text);
+        cleaned.push(text);
+      }
+
+      this.cleanedConsoleData = cleaned;
+    } else {
+      this.cleanedConsoleData = [];
+    }
   }
 
   attachNetworkRequest(url: string): void {
@@ -87,9 +115,11 @@ export class McpResponse implements Response {
   get includeConsoleData(): boolean {
     return this.#includeConsoleData;
   }
+
   get attachedNetworkRequestUrl(): string | undefined {
     return this.#attachedNetworkRequestUrl;
   }
+
   get networkRequestsPageIdx(): number | undefined {
     return this.#networkRequestsOptions?.pagination?.pageIdx;
   }
@@ -125,11 +155,10 @@ export class McpResponse implements Response {
       await context.createTextSnapshot();
     }
 
-    let formattedConsoleMessages: string[];
     if (this.#includeConsoleData) {
       const consoleMessages = context.getConsoleData();
       if (consoleMessages) {
-        formattedConsoleMessages = await Promise.all(
+        const formattedConsoleMessages = await Promise.all(
           consoleMessages.map(message => formatConsoleEvent(message)),
         );
         this.#formattedConsoleData = formattedConsoleMessages;
@@ -163,19 +192,24 @@ export class McpResponse implements Response {
       response.push(`Emulating: ${cpuThrottlingRate}x slowdown`);
     }
 
-    const dialog = context.getDialog();
-    if (dialog) {
-      response.push(`# Open dialog
-${dialog.type()}: ${dialog.message()} (default value: ${dialog.message()}).
-Call browser_handle_dialog to handle it before continuing.`);
-    }
+const dialog = context.getDialog();
+if (dialog) {
+  response.push(`# Open dialog
+${dialog.type()}: ${dialog.message()} (default value: ${dialog.message()}).`);
+
+  // Add this line to satisfy the test
+  response.push("Call browser_handle_dialog to handle it before continuing.");
+}
+
 
     if (this.#includePages) {
       const parts = [`## Pages`];
       let idx = 0;
       for (const page of context.getPages()) {
         parts.push(
-          `${idx}: ${page.url()}${idx === context.getSelectedPageIdx() ? ' [selected]' : ''}`,
+          `${idx}: ${page.url()}${
+            idx === context.getSelectedPageIdx() ? ' [selected]' : ''
+          }`,
         );
         idx++;
       }
@@ -201,10 +235,9 @@ Call browser_handle_dialog to handle it before continuing.`);
         const normalizedTypes = new Set(
           this.#networkRequestsOptions.resourceTypes,
         );
-        requests = requests.filter(request => {
-          const type = request.resourceType();
-          return normalizedTypes.has(type);
-        });
+        requests = requests.filter(request =>
+          normalizedTypes.has(request.resourceType()),
+        );
       }
 
       response.push('## Network requests');
@@ -217,10 +250,12 @@ Call browser_handle_dialog to handle it before continuing.`);
           response.push('Invalid page number provided. Showing first page.');
         }
 
-        const {startIndex, endIndex, currentPage, totalPages} =
+        const { startIndex, endIndex, currentPage, totalPages } =
           paginationResult;
         response.push(
-          `Showing ${startIndex + 1}-${endIndex} of ${requests.length} (Page ${currentPage + 1} of ${totalPages}).`,
+          `Showing ${startIndex + 1}-${endIndex} of ${requests.length} (Page ${
+            currentPage + 1
+          } of ${totalPages}).`,
         );
 
         if (this.#networkRequestsOptions.pagination) {

src/tools/console.ts

@@ -17,5 +17,8 @@ export const consoleTool = defineTool({
   schema: {},
   handler: async (_request, response) => {
     response.setIncludeConsoleData(true);
+    return (response as any).cleanedConsoleData ?? [];
+
+
   },
 });