Skip to content

Commit 1a4ba4d

Browse files
authored
fix: add a message indicating that no console messages exist (#91)
To avoid clients being confused about the lack of console messages. Closes #87
1 parent 4e7001a commit 1a4ba4d

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

src/McpResponse.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,11 @@ Call browser_handle_dialog to handle it before continuing.`);
172172

173173
if (this.#includeConsoleData && this.#formattedConsoleData) {
174174
response.push('## Console messages');
175-
response.push(...this.#formattedConsoleData);
175+
if (this.#formattedConsoleData.length) {
176+
response.push(...this.#formattedConsoleData);
177+
} else {
178+
response.push('<no console messages found>');
179+
}
176180
}
177181

178182
const text: TextContent = {

tests/McpResponse.test.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,4 +246,18 @@ Log>`),
246246
assert.ok(result[0].text.toString().includes('Hello from the test'));
247247
});
248248
});
249+
250+
it('adds a message when no console messages exist', async () => {
251+
await withBrowser(async (response, context) => {
252+
response.setIncludeConsoleData(true);
253+
const result = await response.handle('test', context);
254+
assert.ok(result[0].text);
255+
assert.strictEqual(
256+
result[0].text.toString(),
257+
`# test response
258+
## Console messages
259+
<no console messages found>`,
260+
);
261+
});
262+
});
249263
});

0 commit comments

Comments
 (0)