Merge branch 'main' into warp

Author: sebastianbenz

.github/workflows/convetional-commit.yml

@@ -0,0 +1,24 @@
+name: 'Conventional Commit'
+
+on:
+  pull_request_target:
+    types:
+      # Defaults
+      # https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target
+      - opened
+      - reopened
+      - synchronize
+      # Tracks editing PR title or description, or base branch changes
+      # https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=edited#pull_request
+      - edited
+
+jobs:
+  main:
+    name: '[Required] Validate PR title'
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: read
+    steps:
+      - uses: amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50 # v6.1.1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/presubmit.yml

@@ -10,6 +10,7 @@ on:
 
 jobs:
   check-format:
+    name: '[Required] Check correct format'
     runs-on: ubuntu-latest
 
     steps:
@@ -31,6 +32,7 @@ jobs:
         run: npm run check-format
 
   check-docs:
+    name: '[Required] Check docs updated'
     runs-on: ubuntu-latest
 
     steps:

src/Mutex.ts

@@ -7,13 +7,10 @@
 export class Mutex {
   static Guard = class Guard {
     #mutex: Mutex;
-    #onRelease?: () => void;
-    constructor(mutex: Mutex, onRelease?: () => void) {
+    constructor(mutex: Mutex) {
       this.#mutex = mutex;
-      this.#onRelease = onRelease;
     }
     dispose(): void {
-      this.#onRelease?.();
       return this.#mutex.release();
     }
   };
@@ -22,17 +19,15 @@ export class Mutex {
   #acquirers: Array<() => void> = [];
 
   // This is FIFO.
-  async acquire(
-    onRelease?: () => void,
-  ): Promise<InstanceType<typeof Mutex.Guard>> {
+  async acquire(): Promise<InstanceType<typeof Mutex.Guard>> {
     if (!this.#locked) {
       this.#locked = true;
       return new Mutex.Guard(this);
     }
     const {resolve, promise} = Promise.withResolvers<void>();
     this.#acquirers.push(resolve);
     await promise;
-    return new Mutex.Guard(this, onRelease);
+    return new Mutex.Guard(this);
   }
 
   release(): void {