Skip to content

Commit 58aa99e

Browse files
Lightning00BladeAlinaVarkki
authored andcommitted
refactor: use different format for reqid (#380)
1 parent f3ffda3 commit 58aa99e

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

src/formatters/networkFormatter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export function getShortDescriptionForRequest(
1515
id: number,
1616
): string {
1717
// TODO truncate the URL
18-
return `reqid ${id} - ${request.url()} ${request.method()} ${getStatusFromRequest(request)}`;
18+
return `reqid=${id} ${request.method()} ${request.url()} ${getStatusFromRequest(request)}`;
1919
}
2020

2121
export function getStatusFromRequest(request: HTTPRequest): string {

tests/McpResponse.test.ts

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,8 @@ Call handle_dialog to handle it before continuing.`,
210210
`# test response
211211
## Network requests
212212
Showing 1-2 of 2 (Page 1 of 1).
213-
reqid 1 - http://example.com GET [pending]
214-
reqid 2 - http://example.com GET [pending]`,
213+
reqid=1 GET http://example.com [pending]
214+
reqid=2 GET http://example.com [pending]`,
215215
);
216216
});
217217
});
@@ -267,7 +267,7 @@ ${JSON.stringify({request: 'body'})}
267267
${JSON.stringify({response: 'body'})}
268268
## Network requests
269269
Showing 1-1 of 1 (Page 1 of 1).
270-
reqid 1 - http://example.com POST [success - 200]`,
270+
reqid=1 POST http://example.com [success - 200]`,
271271
);
272272
});
273273
});
@@ -290,7 +290,7 @@ Status: [pending]
290290
- content-size:10
291291
## Network requests
292292
Showing 1-1 of 1 (Page 1 of 1).
293-
reqid 1 - http://example.com GET [pending]`,
293+
reqid=1 GET http://example.com [pending]`,
294294
);
295295
});
296296
});
@@ -354,8 +354,8 @@ describe('McpResponse network request filtering', () => {
354354
`# test response
355355
## Network requests
356356
Showing 1-2 of 2 (Page 1 of 1).
357-
reqid 1 - http://example.com GET [pending]
358-
reqid 1 - http://example.com GET [pending]`,
357+
reqid=1 GET http://example.com [pending]
358+
reqid=1 GET http://example.com [pending]`,
359359
);
360360
});
361361
});
@@ -378,7 +378,7 @@ reqid 1 - http://example.com GET [pending]`,
378378
`# test response
379379
## Network requests
380380
Showing 1-1 of 1 (Page 1 of 1).
381-
reqid 1 - http://example.com GET [pending]`,
381+
reqid=1 GET http://example.com [pending]`,
382382
);
383383
});
384384
});
@@ -423,11 +423,11 @@ No requests found.`,
423423
`# test response
424424
## Network requests
425425
Showing 1-5 of 5 (Page 1 of 1).
426-
reqid 1 - http://example.com GET [pending]
427-
reqid 1 - http://example.com GET [pending]
428-
reqid 1 - http://example.com GET [pending]
429-
reqid 1 - http://example.com GET [pending]
430-
reqid 1 - http://example.com GET [pending]`,
426+
reqid=1 GET http://example.com [pending]
427+
reqid=1 GET http://example.com [pending]
428+
reqid=1 GET http://example.com [pending]
429+
reqid=1 GET http://example.com [pending]
430+
reqid=1 GET http://example.com [pending]`,
431431
);
432432
});
433433
});
@@ -452,11 +452,11 @@ reqid 1 - http://example.com GET [pending]`,
452452
`# test response
453453
## Network requests
454454
Showing 1-5 of 5 (Page 1 of 1).
455-
reqid 1 - http://example.com GET [pending]
456-
reqid 1 - http://example.com GET [pending]
457-
reqid 1 - http://example.com GET [pending]
458-
reqid 1 - http://example.com GET [pending]
459-
reqid 1 - http://example.com GET [pending]`,
455+
reqid=1 GET http://example.com [pending]
456+
reqid=1 GET http://example.com [pending]
457+
reqid=1 GET http://example.com [pending]
458+
reqid=1 GET http://example.com [pending]
459+
reqid=1 GET http://example.com [pending]`,
460460
);
461461
});
462462
});

tests/formatters/networkFormatter.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,20 @@ describe('networkFormatter', () => {
2323
const request = getMockRequest();
2424
const result = getShortDescriptionForRequest(request, 1);
2525

26-
assert.equal(result, 'reqid 1 - http://example.com GET [pending]');
26+
assert.equal(result, 'reqid=1 GET http://example.com [pending]');
2727
});
2828
it('shows correct method', async () => {
2929
const request = getMockRequest({method: 'POST'});
3030
const result = getShortDescriptionForRequest(request, 1);
3131

32-
assert.equal(result, 'reqid 1 - http://example.com POST [pending]');
32+
assert.equal(result, 'reqid=1 POST http://example.com [pending]');
3333
});
3434
it('shows correct status for request with response code in 200', async () => {
3535
const response = getMockResponse();
3636
const request = getMockRequest({response});
3737
const result = getShortDescriptionForRequest(request, 1);
3838

39-
assert.equal(result, 'reqid 1 - http://example.com GET [success - 200]');
39+
assert.equal(result, 'reqid=1 GET http://example.com [success - 200]');
4040
});
4141
it('shows correct status for request with response code in 100', async () => {
4242
const response = getMockResponse({
@@ -45,7 +45,7 @@ describe('networkFormatter', () => {
4545
const request = getMockRequest({response});
4646
const result = getShortDescriptionForRequest(request, 1);
4747

48-
assert.equal(result, 'reqid 1 - http://example.com GET [failed - 199]');
48+
assert.equal(result, 'reqid=1 GET http://example.com [failed - 199]');
4949
});
5050
it('shows correct status for request with response code above 200', async () => {
5151
const response = getMockResponse({
@@ -54,7 +54,7 @@ describe('networkFormatter', () => {
5454
const request = getMockRequest({response});
5555
const result = getShortDescriptionForRequest(request, 1);
5656

57-
assert.equal(result, 'reqid 1 - http://example.com GET [failed - 300]');
57+
assert.equal(result, 'reqid=1 GET http://example.com [failed - 300]');
5858
});
5959
it('shows correct status for request that failed', async () => {
6060
const request = getMockRequest({
@@ -68,7 +68,7 @@ describe('networkFormatter', () => {
6868

6969
assert.equal(
7070
result,
71-
'reqid 1 - http://example.com GET [failed - Error in Network]',
71+
'reqid=1 GET http://example.com [failed - Error in Network]',
7272
);
7373
});
7474
});

0 commit comments

Comments
 (0)