Skip to content

Commit 70cd290

Browse files
chore: rename options to includePreserved<Data> (#455)
1 parent 0fe2b8a commit 70cd290

File tree

8 files changed

+30
-26
lines changed

8 files changed

+30
-26
lines changed

docs/tool-reference.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@
269269

270270
**Parameters:**
271271

272-
- **includePreviousNavigations** (boolean) _(optional)_: Whether to include requests from previous navigations.
272+
- **includePreservedRequests** (boolean) _(optional)_: Set to true to return the preserved requests over the last 3 navigations.
273273
- **pageIdx** (integer) _(optional)_: Page number to return (0-based). When omitted, returns the first page.
274274
- **pageSize** (integer) _(optional)_: Maximum number of requests to return. When omitted, returns all requests.
275275
- **resourceTypes** (array) _(optional)_: Filter requests to only return requests of the specified resource types. When omitted or empty, returns all requests.
@@ -314,7 +314,7 @@ so returned values have to JSON-serializable.
314314

315315
**Parameters:**
316316

317-
- **includePreviousNavigations** (boolean) _(optional)_: Whether to include messages from previous navigations.
317+
- **includePreservedMessages** (boolean) _(optional)_: Set to true to return the preserved messages over the last 3 navigations.
318318
- **pageIdx** (integer) _(optional)_: Page number to return (0-based). When omitted, returns the first page.
319319
- **pageSize** (integer) _(optional)_: Maximum number of messages to return. When omitted, returns all requests.
320320
- **types** (array) _(optional)_: Filter messages to only return messages of the specified resource types. When omitted or empty, returns all messages.

src/McpContext.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,16 +140,16 @@ export class McpContext implements Context {
140140
return context;
141141
}
142142

143-
getNetworkRequests(includePreviousNavigations?: boolean): HTTPRequest[] {
143+
getNetworkRequests(includePreservedRequests?: boolean): HTTPRequest[] {
144144
const page = this.getSelectedPage();
145-
return this.#networkCollector.getData(page, includePreviousNavigations);
145+
return this.#networkCollector.getData(page, includePreservedRequests);
146146
}
147147

148148
getConsoleData(
149-
includePreviousNavigations?: boolean,
149+
includePreservedMessages?: boolean,
150150
): Array<ConsoleMessage | Error> {
151151
const page = this.getSelectedPage();
152-
return this.#consoleCollector.getData(page, includePreviousNavigations);
152+
return this.#consoleCollector.getData(page, includePreservedMessages);
153153
}
154154

155155
getConsoleMessageStableId(message: ConsoleMessage | Error): number {

src/McpResponse.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@ export class McpResponse implements Response {
4040
include: boolean;
4141
pagination?: PaginationOptions;
4242
resourceTypes?: ResourceType[];
43-
includePreviousNavigations?: boolean;
43+
includePreservedRequests?: boolean;
4444
};
4545
#consoleDataOptions?: {
4646
include: boolean;
4747
pagination?: PaginationOptions;
4848
types?: string[];
49-
includePreviousNavigations?: boolean;
49+
includePreservedMessages?: boolean;
5050
};
5151

5252
setIncludePages(value: boolean): void {
@@ -62,7 +62,7 @@ export class McpResponse implements Response {
6262
value: boolean,
6363
options?: PaginationOptions & {
6464
resourceTypes?: ResourceType[];
65-
includePreviousNavigations?: boolean;
65+
includePreservedRequests?: boolean;
6666
},
6767
): void {
6868
if (!value) {
@@ -80,15 +80,15 @@ export class McpResponse implements Response {
8080
}
8181
: undefined,
8282
resourceTypes: options?.resourceTypes,
83-
includePreviousNavigations: options?.includePreviousNavigations,
83+
includePreservedRequests: options?.includePreservedRequests,
8484
};
8585
}
8686

8787
setIncludeConsoleData(
8888
value: boolean,
8989
options?: PaginationOptions & {
9090
types?: string[];
91-
includePreviousNavigations?: boolean;
91+
includePreservedMessages?: boolean;
9292
},
9393
): void {
9494
if (!value) {
@@ -106,7 +106,7 @@ export class McpResponse implements Response {
106106
}
107107
: undefined,
108108
types: options?.types,
109-
includePreviousNavigations: options?.includePreviousNavigations,
109+
includePreservedMessages: options?.includePreservedMessages,
110110
};
111111
}
112112

@@ -232,7 +232,7 @@ export class McpResponse implements Response {
232232
let consoleListData: ConsoleMessageData[] | undefined;
233233
if (this.#consoleDataOptions?.include) {
234234
let messages = context.getConsoleData(
235-
this.#consoleDataOptions.includePreviousNavigations,
235+
this.#consoleDataOptions.includePreservedMessages,
236236
);
237237

238238
if (this.#consoleDataOptions.types?.length) {
@@ -353,7 +353,7 @@ Call ${handleDialog.name} to handle it before continuing.`);
353353

354354
if (this.#networkRequestsOptions?.include) {
355355
let requests = context.getNetworkRequests(
356-
this.#networkRequestsOptions?.includePreviousNavigations,
356+
this.#networkRequestsOptions?.includePreservedRequests,
357357
);
358358

359359
// Apply resource type filtering if specified

src/PageCollector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,13 @@ export class PageCollector<T> {
133133
this.storage.delete(page);
134134
}
135135

136-
getData(page: Page, includePreviousNavigations?: boolean): T[] {
136+
getData(page: Page, includePreservedData?: boolean): T[] {
137137
const navigations = this.storage.get(page);
138138
if (!navigations) {
139139
return [];
140140
}
141141

142-
if (!includePreviousNavigations) {
142+
if (!includePreservedData) {
143143
return navigations[0];
144144
}
145145

src/tools/ToolDefinition.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ export interface Response {
4949
value: boolean,
5050
options?: PaginationOptions & {
5151
resourceTypes?: string[];
52-
includePreviousNavigations?: boolean;
52+
includePreservedRequests?: boolean;
5353
},
5454
): void;
5555
setIncludeConsoleData(
5656
value: boolean,
5757
options?: PaginationOptions & {
5858
types?: string[];
59-
includePreviousNavigations?: boolean;
59+
includePreservedMessages?: boolean;
6060
},
6161
): void;
6262
setIncludeSnapshot(value: boolean): void;

src/tools/console.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,20 @@ export const listConsoleMessages = defineTool({
6666
.describe(
6767
'Filter messages to only return messages of the specified resource types. When omitted or empty, returns all messages.',
6868
),
69-
includePreviousNavigations: zod
69+
includePreservedMessages: zod
7070
.boolean()
7171
.default(false)
7272
.optional()
73-
.describe('Whether to include messages from previous navigations.'),
73+
.describe(
74+
'Set to true to return the preserved messages over the last 3 navigations.',
75+
),
7476
},
7577
handler: async (request, response) => {
7678
response.setIncludeConsoleData(true, {
7779
pageSize: request.params.pageSize,
7880
pageIdx: request.params.pageIdx,
7981
types: request.params.types,
80-
includePreviousNavigations: request.params.includePreviousNavigations,
82+
includePreservedMessages: request.params.includePreservedMessages,
8183
});
8284
},
8385
});

src/tools/network.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,20 @@ export const listNetworkRequests = defineTool({
6262
.describe(
6363
'Filter requests to only return requests of the specified resource types. When omitted or empty, returns all requests.',
6464
),
65-
includePreviousNavigations: zod
65+
includePreservedRequests: zod
6666
.boolean()
6767
.default(false)
6868
.optional()
69-
.describe('Whether to include requests from previous navigations.'),
69+
.describe(
70+
'Set to true to return the preserved requests over the last 3 navigations.',
71+
),
7072
},
7173
handler: async (request, response) => {
7274
response.setIncludeNetworkRequests(true, {
7375
pageSize: request.params.pageSize,
7476
pageIdx: request.params.pageIdx,
7577
resourceTypes: request.params.resourceTypes,
76-
includePreviousNavigations: request.params.includePreviousNavigations,
78+
includePreservedRequests: request.params.includePreservedRequests,
7779
});
7880
},
7981
});

tests/tools/network.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('network', () => {
6161
await listNetworkRequests.handler(
6262
{
6363
params: {
64-
includePreviousNavigations: true,
64+
includePreservedRequests: true,
6565
},
6666
},
6767
response,
@@ -99,7 +99,7 @@ describe('network', () => {
9999
await listNetworkRequests.handler(
100100
{
101101
params: {
102-
includePreviousNavigations: true,
102+
includePreservedRequests: true,
103103
},
104104
},
105105
response,

0 commit comments

Comments
 (0)