Skip to content

Commit ad307f6

Browse files
authored
chore: restrict imports outside of the mcp.js (#456)
1 parent 2553006 commit ad307f6

File tree

4 files changed

+24
-4
lines changed

4 files changed

+24
-4
lines changed

eslint.config.mjs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,22 @@ export default defineConfig([
112112

113113
'@stylistic/function-call-spacing': 'error',
114114
'@stylistic/semi': 'error',
115+
116+
'no-restricted-imports': [
117+
'error',
118+
{
119+
patterns: [
120+
{
121+
group: [
122+
'*/node_modules/chrome-devtools-frontend/*',
123+
'!*/node_modules/chrome-devtools-frontend/mcp/mcp.js',
124+
],
125+
message:
126+
'Import devtools-frontend code only from node_modules/chrome-devtools-frontend/mcp/mcp.js',
127+
},
128+
],
129+
},
130+
],
115131
},
116132
},
117133
{

src/DevToolsConnectionAdapter.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7+
// eslint-disable-next-line no-restricted-imports
78
import {ConnectionTransport as DevToolsConnectionTransport} from '../node_modules/chrome-devtools-frontend/front_end/core/protocol_client/ConnectionTransport.js';
89

910
import {type ConnectionTransport} from './third_party/index.js';

src/trace-processing/parse.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7-
import {PerformanceInsightFormatter} from '../../node_modules/chrome-devtools-frontend/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.js';
8-
import {PerformanceTraceFormatter} from '../../node_modules/chrome-devtools-frontend/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.js';
9-
import {AgentFocus} from '../../node_modules/chrome-devtools-frontend/front_end/models/ai_assistance/performance/AIContext.js';
10-
import * as TraceEngine from '../../node_modules/chrome-devtools-frontend/front_end/models/trace/trace.js';
7+
import {
8+
AgentFocus,
9+
TraceEngine,
10+
PerformanceTraceFormatter,
11+
PerformanceInsightFormatter,
12+
} from '../../node_modules/chrome-devtools-frontend/mcp/mcp.js';
1113
import {logger} from '../logger.js';
1214

1315
const engine = TraceEngine.TraceModel.Model.createWithAllHandlers();

tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"include": [
2727
"src/**/*.ts",
2828
"tests/**/*.ts",
29+
"node_modules/chrome-devtools-frontend/mcp/mcp.ts",
2930
"node_modules/chrome-devtools-frontend/front_end/legacy/legacy-defs.d.ts",
3031
"node_modules/chrome-devtools-frontend/front_end/models/trace",
3132
"node_modules/chrome-devtools-frontend/front_end/models/logs",

0 commit comments

Comments
 (0)