fix

Author: Lightning00Blade

src/PageCollector.ts

@@ -15,7 +15,6 @@ import {
 
 export type ListenerMap<EventMap extends PageEvents = PageEvents> = {
   [K in keyof EventMap]?: (event: EventMap[K]) => void;
-  // request: (event: PageEvents['request']) => void;
 };
 
 export class PageCollector<T> {
@@ -105,6 +104,7 @@ export class PageCollector<T> {
         page.off(name, listener as Handler<unknown>);
       }
     }
+    this.storage.delete(page);
   }
 
   getData(page: Page): T[] {

tests/PageCollector.test.ts

@@ -164,4 +164,33 @@ describe('PageCollector', () => {
 
     assert.equal(collector.getData(page).length, 2);
   });
+
+  it.only('should clear data on page destroy', async () => {
+    const browser = getMockBrowser();
+    const page = (await browser.pages())[0];
+    const request = getMockRequest();
+    const collector = new PageCollector(browser, collect => {
+      return {
+        request: req => {
+          collect(req);
+        },
+      } as ListenerMap;
+    });
+    await collector.init();
+
+    page.emit('request', request);
+
+    assert.equal(collector.getData(page).length, 1);
+
+    browser.emit('targetdestroyed', {
+      page() {
+        return Promise.resolve(page);
+      },
+    } as Target);
+
+    // The page inside part is async so we need to await some time
+    await new Promise<void>(res => res());
+
+    assert.equal(collector.getData(page).length, 0);
+  });
 });