Skip to content

Commit e413eae

Browse files
committed
chore: Prefix logged enum flag values with their snake_case name
1 parent ee35f20 commit e413eae

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/telemetry/flag-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export function computeFlagUsage(
5252
// For enums, log the value as uppercase
5353
// We're going to have an enum for such flags with choices represented
5454
// as an `enum` where the keys of the enum will map to the uppercase `choice`.
55-
usage[snakeCaseName] = value.toUpperCase();
55+
usage[snakeCaseName] = `${snakeCaseName}_${value}`.toUpperCase();
5656
}
5757
}
5858

tests/telemetry/flag-utils.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ describe('computeFlagUsage', () => {
4444
assert.equal(usage.bool_flag, false);
4545
});
4646

47-
it('logs enum flags as uppercase', () => {
47+
it('logs enum flags as uppercase strings prefixed by snake case flag name', () => {
4848
const args = {enumFlag: 'a'};
4949
const usage = computeFlagUsage(args, mockOptions);
50-
assert.equal(usage.enum_flag, 'A');
50+
assert.equal(usage.enum_flag, 'ENUM_FLAG_A');
5151
});
5252

5353
it('logs other flags as present with snake_case keys', () => {

0 commit comments

Comments
 (0)