diff --git a/package-lock.json b/package-lock.json index 1d0498be..23555d0f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -27,7 +27,7 @@ "@types/yargs": "^17.0.33", "@typescript-eslint/eslint-plugin": "^8.43.0", "@typescript-eslint/parser": "^8.43.0", - "chrome-devtools-frontend": "1.0.1516909", + "chrome-devtools-frontend": "1.0.1520139", "eslint": "^9.35.0", "eslint-import-resolver-typescript": "^4.4.4", "eslint-plugin-import": "^2.32.0", @@ -1760,9 +1760,9 @@ } }, "node_modules/chrome-devtools-frontend": { - "version": "1.0.1516909", - "resolved": "https://registry.npmjs.org/chrome-devtools-frontend/-/chrome-devtools-frontend-1.0.1516909.tgz", - "integrity": "sha512-e6RbPoMMJzg2k5xNOPufP0hv8yyuP60oZUHL+/GyF0qG5wEG/0cFzi04V/9HV146SzYlyYPjMBdMYiaYDZm1ZA==", + "version": "1.0.1520139", + "resolved": "https://registry.npmjs.org/chrome-devtools-frontend/-/chrome-devtools-frontend-1.0.1520139.tgz", + "integrity": "sha512-sebWwMkX6TZ/qa5R+1luGhjlUjbEBSm3jtmCPVTaXk8g3pY1ys8Rpb59FxKcmAKEDoaa0mIO4OAXLGR9GEyfhA==", "dev": true, "license": "BSD-3-Clause" }, diff --git a/package.json b/package.json index d79865dc..213d9e47 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "@types/yargs": "^17.0.33", "@typescript-eslint/eslint-plugin": "^8.43.0", "@typescript-eslint/parser": "^8.43.0", - "chrome-devtools-frontend": "1.0.1516909", + "chrome-devtools-frontend": "1.0.1520139", "eslint": "^9.35.0", "eslint-plugin-import": "^2.32.0", "eslint-import-resolver-typescript": "^4.4.4", diff --git a/src/trace-processing/parse.ts b/src/trace-processing/parse.ts index 8fd5c4e3..dbcb764c 100644 --- a/src/trace-processing/parse.ts +++ b/src/trace-processing/parse.ts @@ -74,9 +74,11 @@ export async function parseRawTraceBuffer( } export function getTraceSummary(result: TraceResult): string { - const focus = AgentFocus.full(result.parsedTrace); - const serializer = new TraceEngine.EventsSerializer.EventsSerializer(); - const formatter = new PerformanceTraceFormatter(focus, serializer); + const focus = AgentFocus.fromParsedTrace(result.parsedTrace); + const formatter = new PerformanceTraceFormatter( + focus, + PerformanceInsightFormatter.create, + ); const output = formatter.formatTraceSummary(); return output; } @@ -122,7 +124,7 @@ export function getInsightOutput( } const formatter = new PerformanceInsightFormatter( - result.parsedTrace, + AgentFocus.fromParsedTrace(result.parsedTrace), matchingInsight, ); return {output: formatter.formatInsight()}; diff --git a/tests/tools/performance.test.js.snapshot b/tests/tools/performance.test.js.snapshot index 3d0c36fc..cd756655 100644 --- a/tests/tools/performance.test.js.snapshot +++ b/tests/tools/performance.test.js.snapshot @@ -6,8 +6,9 @@ This insight is used to analyze the time spent that contributed to the final LCP ## Detailed analysis: The Largest Contentful Paint (LCP) time for this navigation was 129 ms. -The LCP element is an image fetched from \`https://web-dev.imgix.net/image/kheDArv5csY6rvQUJDbWRscckLr1/4i7JstVZvgTFk9dxCe4a.svg\`. +The LCP element is an image fetched from https://web-dev.imgix.net/image/kheDArv5csY6rvQUJDbWRscckLr1/4i7JstVZvgTFk9dxCe4a.svg (eventKey: s-1314). ## LCP resource network request: https://web-dev.imgix.net/image/kheDArv5csY6rvQUJDbWRscckLr1/4i7JstVZvgTFk9dxCe4a.svg +eventKey: s-1314 Timings: - Queued at: 41 ms - Request sent at: 47 ms @@ -55,7 +56,7 @@ Bounds: {min: 122410994891, max: 122416385853} CPU throttling: none Network throttling: none Metrics (lab / observed): - - LCP: 129 ms, event: (eventKey: r-6063, ts: 122411126100) + - LCP: 129 ms, event: (eventKey: r-6063, ts: 122411126100), nodeId: 7 - LCP breakdown: - TTFB: 8 ms, bounds: {min: 122410996889, max: 122411004828} - Load delay: 33 ms, bounds: {min: 122411004828, max: 122411037986} diff --git a/tests/trace-processing/parse.test.js.snapshot b/tests/trace-processing/parse.test.js.snapshot index 1988804b..f4a4fbf0 100644 --- a/tests/trace-processing/parse.test.js.snapshot +++ b/tests/trace-processing/parse.test.js.snapshot @@ -4,7 +4,7 @@ Bounds: {min: 122410994891, max: 122416385853} CPU throttling: none Network throttling: none Metrics (lab / observed): - - LCP: 129 ms, event: (eventKey: r-6063, ts: 122411126100) + - LCP: 129 ms, event: (eventKey: r-6063, ts: 122411126100), nodeId: 7 - LCP breakdown: - TTFB: 8 ms, bounds: {min: 122410996889, max: 122411004828} - Load delay: 33 ms, bounds: {min: 122411004828, max: 122411037986}