Skip to content

fix: return the default dialog value correctly #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OrKoN merged 2 commits into from
Oct 13, 2025
Merged

fix: return the default dialog value correctly #366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3195fb
fix: return the default dialog value correctly
OrKoN Oct 13, 2025
e05dec7
Update src/McpResponse.ts
OrKoN Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/McpResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export class McpResponse implements Response {
const dialog = context.getDialog();
if (dialog) {
response.push(`# Open dialog
${dialog.type()}: ${dialog.message()} (default value: ${dialog.message()}).
${dialog.type()}: ${dialog.message()} (default value: ${dialog.defaultValue()}).
Call ${handleDialog.name} to handle it before continuing.`);
}

Expand Down
4 changes: 2 additions & 2 deletions tests/McpResponse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ Emulating: 4x slowdown`,
});
});
page.evaluate(() => {
alert('test');
prompt('message', 'default');
});
await dialogPromise;
const result = await response.handle('test', context);
Expand All @@ -168,7 +168,7 @@ Emulating: 4x slowdown`,
result[0].text,
`# test response
# Open dialog
alert: test (default value: test).
prompt: test (default value: default).
Call handle_dialog to handle it before continuing.`,
);
});
Expand Down
Loading