Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/McpResponse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,12 @@ export class McpResponse implements Response {

const dialog = context.getDialog();
if (dialog) {
const defaultValueIfNeeded =
dialog.type() === 'prompt'
? ` (default value: "${dialog.defaultValue()}")`
: '';
response.push(`# Open dialog
${dialog.type()}: ${dialog.message()} (default value: ${dialog.message()}).
${dialog.type()}: ${dialog.message()}${defaultValueIfNeeded}.
Call ${handleDialog.name} to handle it before continuing.`);
}

Expand Down
30 changes: 27 additions & 3 deletions tests/McpResponse.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ Emulating: 4x slowdown`,
});
});

it('adds a dialog', async () => {
it('adds a prompt dialog', async () => {
await withBrowser(async (response, context) => {
const page = context.getSelectedPage();
const dialogPromise = new Promise<void>(resolve => {
Expand All @@ -159,7 +159,7 @@ Emulating: 4x slowdown`,
});
});
page.evaluate(() => {
alert('test');
prompt('message', 'default');
});
await dialogPromise;
const result = await response.handle('test', context);
Expand All @@ -168,7 +168,31 @@ Emulating: 4x slowdown`,
result[0].text,
`# test response
# Open dialog
alert: test (default value: test).
prompt: message (default value: "default").
Call handle_dialog to handle it before continuing.`,
);
});
});

it('adds an alert dialog', async () => {
await withBrowser(async (response, context) => {
const page = context.getSelectedPage();
const dialogPromise = new Promise<void>(resolve => {
page.on('dialog', () => {
resolve();
});
});
page.evaluate(() => {
alert('message');
});
await dialogPromise;
const result = await response.handle('test', context);
await context.getDialog()?.dismiss();
assert.strictEqual(
result[0].text,
`# test response
# Open dialog
alert: message.
Call handle_dialog to handle it before continuing.`,
);
});
Expand Down