feat: validate uids #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
OrKoN
commented
Sep 16, 2025
OrKoN
commented
- generate snapshot IDs.
- change uid to be a string.
- validate that uid is not coming from a stale snapshot.
OrKoN
force-pushed
the
orkon/uid-validation
branch
from
00731a6 to
412a5e6
Compare
Lightning00Blade
approved these changes
Sep 16, 2025
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
LGTM with comment
OrKoN
force-pushed
the
orkon/uid-validation
branch
from
412a5e6 to
f534989
Compare
OrKoN
pushed a commit
that referenced
this pull request
Sep 17, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.0](chrome-devtools-mcp-v0.1.0...chrome-devtools-mcp-v0.2.0) (2025-09-17) ### Features * add performance_analyze_insight tool. ([#42](#42)) ([21e175b](21e175b)) * support script evaluate arguments ([#40](#40)) ([c663f4d](c663f4d)) * use Performance Trace Formatter in trace output ([#36](#36)) ([0cb6147](0cb6147)) * validate uids ([#37](#37)) ([014a8bc](014a8bc)) ### Bug Fixes * change profile folder name to browser-profile ([#39](#39)) ([36115d7](36115d7)) * refresh context based on the browser instance ([#44](#44)) ([93f4579](93f4579)) * update puppeteer to fix a11y snapshot issues ([#43](#43)) ([b58f787](b58f787)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
OrKoN
pushed a commit
that referenced
this pull request
Sep 17, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.0](chrome-devtools-mcp-v0.1.0...chrome-devtools-mcp-v0.2.0) (2025-09-17) ### Features * add performance_analyze_insight tool. ([#42](#42)) ([21e175b](21e175b)) * support script evaluate arguments ([#40](#40)) ([c663f4d](c663f4d)) * use Performance Trace Formatter in trace output ([#36](#36)) ([0cb6147](0cb6147)) * validate uids ([#37](#37)) ([014a8bc](014a8bc)) ### Bug Fixes * change profile folder name to browser-profile ([#39](#39)) ([36115d7](36115d7)) * refresh context based on the browser instance ([#44](#44)) ([93f4579](93f4579)) * update puppeteer to fix a11y snapshot issues ([#43](#43)) ([b58f787](b58f787)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
OrKoN
pushed a commit
that referenced
this pull request
Sep 17, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.0](chrome-devtools-mcp-v0.1.0...chrome-devtools-mcp-v0.2.0) (2025-09-17) ### Features * add performance_analyze_insight tool. ([#42](#42)) ([21e175b](21e175b)) * support script evaluate arguments ([#40](#40)) ([c663f4d](c663f4d)) * use Performance Trace Formatter in trace output ([#36](#36)) ([0cb6147](0cb6147)) * validate uids ([#37](#37)) ([014a8bc](014a8bc)) ### Bug Fixes * change profile folder name to browser-profile ([#39](#39)) ([36115d7](36115d7)) * refresh context based on the browser instance ([#44](#44)) ([93f4579](93f4579)) * update puppeteer to fix a11y snapshot issues ([#43](#43)) ([b58f787](b58f787)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.