Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/formatters/networkFormatter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function getShortDescriptionForRequest(
id: number,
): string {
// TODO truncate the URL
return `reqid ${id} - ${request.url()} ${request.method()} ${getStatusFromRequest(request)}`;
return `reqid=${id} ${request.method()} ${request.url()} ${getStatusFromRequest(request)}`;
}

export function getStatusFromRequest(request: HTTPRequest): string {
Expand Down
34 changes: 17 additions & 17 deletions tests/McpResponse.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ Call handle_dialog to handle it before continuing.`,
`# test response
## Network requests
Showing 1-2 of 2 (Page 1 of 1).
reqid 1 - http://example.com GET [pending]
reqid 2 - http://example.com GET [pending]`,
reqid=1 GET http://example.com [pending]
reqid=2 GET http://example.com [pending]`,
);
});
});
Expand Down Expand Up @@ -267,7 +267,7 @@ ${JSON.stringify({request: 'body'})}
${JSON.stringify({response: 'body'})}
## Network requests
Showing 1-1 of 1 (Page 1 of 1).
reqid 1 - http://example.com POST [success - 200]`,
reqid=1 POST http://example.com [success - 200]`,
);
});
});
Expand All @@ -290,7 +290,7 @@ Status: [pending]
- content-size:10
## Network requests
Showing 1-1 of 1 (Page 1 of 1).
reqid 1 - http://example.com GET [pending]`,
reqid=1 GET http://example.com [pending]`,
);
});
});
Expand Down Expand Up @@ -355,8 +355,8 @@ describe('McpResponse network request filtering', () => {
`# test response
## Network requests
Showing 1-2 of 2 (Page 1 of 1).
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]`,
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]`,
);
});
});
Expand All @@ -379,7 +379,7 @@ reqid 1 - http://example.com GET [pending]`,
`# test response
## Network requests
Showing 1-1 of 1 (Page 1 of 1).
reqid 1 - http://example.com GET [pending]`,
reqid=1 GET http://example.com [pending]`,
);
});
});
Expand Down Expand Up @@ -424,11 +424,11 @@ No requests found.`,
`# test response
## Network requests
Showing 1-5 of 5 (Page 1 of 1).
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]`,
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]`,
);
});
});
Expand All @@ -453,11 +453,11 @@ reqid 1 - http://example.com GET [pending]`,
`# test response
## Network requests
Showing 1-5 of 5 (Page 1 of 1).
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]
reqid 1 - http://example.com GET [pending]`,
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]
reqid=1 GET http://example.com [pending]`,
);
});
});
Expand Down
12 changes: 6 additions & 6 deletions tests/formatters/networkFormatter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,20 @@ describe('networkFormatter', () => {
const request = getMockRequest();
const result = getShortDescriptionForRequest(request, 1);

assert.equal(result, 'reqid 1 - http://example.com GET [pending]');
assert.equal(result, 'reqid=1 GET http://example.com [pending]');
});
it('shows correct method', async () => {
const request = getMockRequest({method: 'POST'});
const result = getShortDescriptionForRequest(request, 1);

assert.equal(result, 'reqid 1 - http://example.com POST [pending]');
assert.equal(result, 'reqid=1 POST http://example.com [pending]');
});
it('shows correct status for request with response code in 200', async () => {
const response = getMockResponse();
const request = getMockRequest({response});
const result = getShortDescriptionForRequest(request, 1);

assert.equal(result, 'reqid 1 - http://example.com GET [success - 200]');
assert.equal(result, 'reqid=1 GET http://example.com [success - 200]');
});
it('shows correct status for request with response code in 100', async () => {
const response = getMockResponse({
Expand All @@ -45,7 +45,7 @@ describe('networkFormatter', () => {
const request = getMockRequest({response});
const result = getShortDescriptionForRequest(request, 1);

assert.equal(result, 'reqid 1 - http://example.com GET [failed - 199]');
assert.equal(result, 'reqid=1 GET http://example.com [failed - 199]');
});
it('shows correct status for request with response code above 200', async () => {
const response = getMockResponse({
Expand All @@ -54,7 +54,7 @@ describe('networkFormatter', () => {
const request = getMockRequest({response});
const result = getShortDescriptionForRequest(request, 1);

assert.equal(result, 'reqid 1 - http://example.com GET [failed - 300]');
assert.equal(result, 'reqid=1 GET http://example.com [failed - 300]');
});
it('shows correct status for request that failed', async () => {
const request = getMockRequest({
Expand All @@ -68,7 +68,7 @@ describe('networkFormatter', () => {

assert.equal(
result,
'reqid 1 - http://example.com GET [failed - Error in Network]',
'reqid=1 GET http://example.com [failed - Error in Network]',
);
});
});
Expand Down