Skip to content

build: clean third_party build only #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OrKoN wants to merge 1 commit into from
Closed

build: clean third_party build only #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
"bin": "./build/src/index.js",
"main": "index.js",
"scripts": {
"clean": "node -e \"require('fs').rmSync('build', {recursive: true, force: true})\"",
"build": "npm run clean && tsc && node --experimental-strip-types --no-warnings=ExperimentalWarning scripts/post-build.ts && rollup -c rollup.config.mjs",
"clean": "node -e \"require('fs').rmSync('build/src/third_party', {recursive: true, force: true})\"",
"clean:3p": "node -e \"require('fs').rmSync('build', {recursive: true, force: true})\"",
Copy link
Collaborator

@Lightning00Blade Lightning00Blade Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is flipped.

Copy link
Collaborator Author

@OrKoN OrKoN Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, that's why it "worked". Actually it does not work... tsc does not seem to check the state of the output and only relies on the tsbuildinfo so this will not work.

"build": "npm run clean:3p && tsc && node --experimental-strip-types --no-warnings=ExperimentalWarning scripts/post-build.ts && rollup -c rollup.config.mjs",
"typecheck": "tsc --noEmit",
"format": "eslint --cache --fix . && prettier --write --cache .",
"check-format": "eslint --cache . && prettier --check --cache .;",
Expand Down