chore: extract issue formatter in preparation to structured content #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattallius
approved these changes
Jan 19, 2026
| context?: McpContext, | ||
| ): string { | ||
| const aggregatedIssue = msg.item; | ||
| if (aggregatedIssue) { |
Collaborator
There was a problem hiding this comment.
maybe let's have the same check for issues message type as in formatConsoleEventShort fro consistency
msg.type === 'issue' && msg.item
| if (affectedResources.length) { | ||
| bodyParts.push('### Affected resources'); | ||
| } | ||
| bodyParts.push( |
Collaborator
There was a problem hiding this comment.
Maybe it makes sense to move this block inside if (affectedResources.length) { ...} cause it only make sense if there are resources to process. And it keeps the related logic together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to add JSON-format as the output for issues. Console formatter will be changed next.