[AI] Adopt single conversation type for performance conversations

This CL consolidates the AI conversation features (insights and main
thread call trees) into a single conversation type.

User facing changes:

* When a trace initially loads, the AI Assistance panel is now usable
  for asking anything about the trace
* Selecting an insight or an entry in the main-thread will add that
  to the current selected context for the active conversation. This is
  conveyed to the user via the context chip title
* The user simply needs to expand an insight or click on a main-thread
  entry to "select" it for the AI agent. The "Debug with AI" buttons
  still exist, and that will additionally open the AI Assistance panel
  if it isn't open already
* Moving from an "insight" to a "call-tree" context no longer starts
  a new conversation: it's all the same chat

Technical refactors:

* AgentFocus now has just one type, with the "insight" and "callTree"
  fields being optional to denote what the user has selected
* There is now only one performance ConversationType

Bug: 442392194
Change-Id: I9b49a53eeae54ed86897f594e1c2874a50bd1edf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6951783
Commit-Queue: Connor Clark <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Paul Irish <[email protected]>

Author: Connor Clark

front_end/models/ai_assistance/AiHistoryStorage.ts

@@ -13,9 +13,7 @@ export const enum ConversationType {
   STYLING = 'freestyler',
   FILE = 'drjones-file',
   NETWORK = 'drjones-network-request',
-  PERFORMANCE_CALL_TREE = 'drjones-performance',
-  PERFORMANCE_INSIGHT = 'performance-insight',
-  PERFORMANCE_FULL = 'drjones-performance-full',
+  PERFORMANCE = 'drjones-performance-full',
 }
 
 export const NOT_FOUND_IMAGE_DATA = '';

front_end/models/ai_assistance/ConversationHandler.test.ts

@@ -327,7 +327,7 @@ describeWithMockConnection('ConversationHandler', () => {
 
       const generator = await conversationHandler.handleExternalRequest({
         prompt: 'Please help me debug this problem',
-        conversationType: AiAssistanceModel.ConversationType.PERFORMANCE_FULL,
+        conversationType: AiAssistanceModel.ConversationType.PERFORMANCE,
         data: Timeline.TimelinePanel.TimelinePanel.instance().getOrCreateExternalAIConversationData(),
       });
       let response = await generator.next();

front_end/models/ai_assistance/ConversationHandler.ts

@@ -50,7 +50,7 @@ export interface ExternalPerformanceAIConversationData {
 }
 
 export interface ExternalPerformanceRequestParameters {
-  conversationType: ConversationType.PERFORMANCE_FULL;
+  conversationType: ConversationType.PERFORMANCE;
   prompt: string;
   data: ExternalPerformanceAIConversationData;
 }
@@ -201,7 +201,7 @@ export class ConversationHandler {
         case ConversationType.STYLING: {
           return await this.#handleExternalStylingConversation(parameters.prompt, parameters.selector);
         }
-        case ConversationType.PERFORMANCE_FULL:
+        case ConversationType.PERFORMANCE:
           return await this.#handleExternalPerformanceConversation(parameters.prompt, parameters.data);
         case ConversationType.NETWORK:
           if (!parameters.requestUrl) {
@@ -348,10 +348,8 @@ export class ConversationHandler {
         agent = new FileAgent(options);
         break;
       }
-      case ConversationType.PERFORMANCE_FULL:
-      case ConversationType.PERFORMANCE_INSIGHT:
-      case ConversationType.PERFORMANCE_CALL_TREE: {
-        agent = new PerformanceAgent(options, conversationType);
+      case ConversationType.PERFORMANCE: {
+        agent = new PerformanceAgent(options);
         break;
       }
     }

front_end/models/ai_assistance/agents/PerformanceAgent.test.ts

@@ -19,7 +19,6 @@ import * as Trace from '../../trace/trace.js';
 import {
   type ActionResponse,
   AICallTree,
-  ConversationType,
   PerformanceAgent,
   PerformanceTraceContext,
   PerformanceTraceFormatter,
@@ -39,11 +38,9 @@ describeWithEnvironment('PerformanceAgent', () => {
   describe('buildRequest', () => {
     it('builds a request with a model id', async () => {
       mockHostConfig('test model');
-      const agent = new PerformanceAgent(
-          {
-            aidaClient: {} as Host.AidaClient.AidaClient,
-          },
-          ConversationType.PERFORMANCE_CALL_TREE);
+      const agent = new PerformanceAgent({
+        aidaClient: {} as Host.AidaClient.AidaClient,
+      });
       assert.strictEqual(
           agent.buildRequest({text: 'test input'}, Host.AidaClient.Role.USER).options?.model_id,
           'test model',
@@ -52,11 +49,9 @@ describeWithEnvironment('PerformanceAgent', () => {
 
     it('builds a request with a temperature', async () => {
       mockHostConfig('test model', 1);
-      const agent = new PerformanceAgent(
-          {
-            aidaClient: {} as Host.AidaClient.AidaClient,
-          },
-          ConversationType.PERFORMANCE_CALL_TREE);
+      const agent = new PerformanceAgent({
+        aidaClient: {} as Host.AidaClient.AidaClient,
+      });
       assert.strictEqual(
           agent.buildRequest({text: 'test input'}, Host.AidaClient.Role.USER).options?.temperature,
           1,
@@ -66,12 +61,10 @@ describeWithEnvironment('PerformanceAgent', () => {
     it('structure matches the snapshot', async () => {
       mockHostConfig('test model');
       sinon.stub(crypto, 'randomUUID').returns('sessionId' as `${string}-${string}-${string}-${string}-${string}`);
-      const agent = new PerformanceAgent(
-          {
-            aidaClient: mockAidaClient([[{explanation: 'answer'}]]),
-            serverSideLoggingEnabled: true,
-          },
-          ConversationType.PERFORMANCE_CALL_TREE);
+      const agent = new PerformanceAgent({
+        aidaClient: mockAidaClient([[{explanation: 'answer'}]]),
+        serverSideLoggingEnabled: true,
+      });
 
       await Array.fromAsync(agent.run('question', {selected: null}));
       setUserAgentForTesting();
@@ -126,27 +119,20 @@ describeWithEnvironment('PerformanceAgent – call tree focus', () => {
       const aiCallTree = AICallTree.fromEvent(layoutEvt, parsedTrace);
       assert.exists(aiCallTree);
 
-      const agent = new PerformanceAgent(
-          {
-            aidaClient: mockAidaClient([[{
-              explanation: 'This is the answer',
-              metadata: {
-                rpcGlobalId: 123,
-              },
-            }]]),
+      const agent = new PerformanceAgent({
+        aidaClient: mockAidaClient([[{
+          explanation: 'This is the answer',
+          metadata: {
+            rpcGlobalId: 123,
           },
-          ConversationType.PERFORMANCE_CALL_TREE);
+        }]]),
+      });
 
       const context = PerformanceTraceContext.fromCallTree(aiCallTree);
       const responses = await Array.fromAsync(agent.run('test', {selected: context}));
-      const expectedData = '\n\n' +
-          `
-
-
-# Call tree:
-
-1;Task;3;;;2
-2;Layout;3;3;;;S`.trim();
+      const expectedData =
+          new PerformanceTraceFormatter(context.getItem(), new Trace.EventsSerializer.EventsSerializer())
+              .formatTraceSummary();
 
       assert.deepEqual(responses, [
         {
@@ -157,9 +143,9 @@ describeWithEnvironment('PerformanceAgent – call tree focus', () => {
         },
         {
           type: ResponseType.CONTEXT,
-          title: 'Analyzing call tree',
+          title: 'Analyzing trace',
           details: [
-            {title: 'Selected call tree', text: expectedData},
+            {title: 'Trace', text: expectedData},
           ],
         },
         {
@@ -190,11 +176,9 @@ describeWithEnvironment('PerformanceAgent – call tree focus', () => {
 
   describe('enhanceQuery', () => {
     it('does not send the serialized calltree again if it is a followup chat about the same calltree', async () => {
-      const agent = new PerformanceAgent(
-          {
-            aidaClient: {} as Host.AidaClient.AidaClient,
-          },
-          ConversationType.PERFORMANCE_CALL_TREE);
+      const agent = new PerformanceAgent({
+        aidaClient: {} as Host.AidaClient.AidaClient,
+      });
 
       const mockAiCallTree = {
         serialize: () => 'Mock call tree',
@@ -264,13 +248,19 @@ const FAKE_PARSED_TRACE = {
 } as unknown as Trace.TraceModel.ParsedTrace;
 
 function createAgentForInsightConversation(opts: {aidaClient?: Host.AidaClient.AidaClient} = {}) {
-  return new PerformanceAgent({aidaClient: opts.aidaClient ?? mockAidaClient()}, ConversationType.PERFORMANCE_INSIGHT);
+  return new PerformanceAgent({aidaClient: opts.aidaClient ?? mockAidaClient()});
 }
 
-describeWithEnvironment('PerformanceAgent – insight focus', () => {
+describeWithEnvironment('PerformanceAgent', () => {
+  it('uses the min and max bounds of the trace as the origin', async function() {
+    const parsedTrace = await TraceLoader.traceEngine(this, 'lcp-images.json.gz');
+    const context = PerformanceTraceContext.full(parsedTrace);
+    assert.strictEqual(context.getOrigin(), 'trace-658799706428-658804825864');
+  });
+
   it('outputs the right title for the selected insight', async () => {
     const context = PerformanceTraceContext.fromInsight(FAKE_PARSED_TRACE, FAKE_LCP_MODEL);
-    assert.strictEqual(context.getTitle(), 'Trace: www.example.com');
+    assert.strictEqual(context.getTitle(), 'Trace: www.example.com – LCP breakdown');
   });
 
   // See b/405054694 for context on why we do this.
@@ -559,11 +549,3 @@ code
     });
   });
 });
-
-describeWithEnvironment('PerformanceAgent – all focus', function() {
-  it('uses the min and max bounds of the trace as the origin', async function() {
-    const parsedTrace = await TraceLoader.traceEngine(this, 'lcp-images.json.gz');
-    const context = PerformanceTraceContext.full(parsedTrace);
-    assert.strictEqual(context.getOrigin(), 'trace-658799706428-658804825864');
-  });
-});

front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -11,7 +11,7 @@ import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
 import * as Tracing from '../../../services/tracing/tracing.js';
 import * as Trace from '../../trace/trace.js';
-import type {ConversationType} from '../AiHistoryStorage.js';
+import {ConversationType} from '../AiHistoryStorage.js';
 import {
   PerformanceInsightFormatter,
   TraceEventFormatter,
@@ -22,7 +22,6 @@ import {AICallTree} from '../performance/AICallTree.js';
 import {AgentFocus} from '../performance/AIContext.js';
 
 import {
-  type AgentOptions,
   AiAgent,
   type ContextResponse,
   ConversationContext,
@@ -38,7 +37,6 @@ const UIStringsNotTranslated = {
    *@description Shown when the agent is investigating a trace
    */
   analyzingTrace: 'Analyzing trace',
-  analyzingCallTree: 'Analyzing call tree',
   /**
    * @description Shown when the agent is investigating network activity
    */
@@ -196,7 +194,15 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
       url = new URL(focus.parsedTrace.data.Meta.mainFrameURL);
     }
 
-    return `Trace: ${url.hostname}`;
+    const parts = [`Trace: ${url.hostname}`];
+    if (focus.insight) {
+      parts.push(focus.insight.title);
+    }
+    if (focus.callTree) {
+      const node = focus.callTree.selectedNode ?? focus.callTree.rootNode;
+      parts.push(Trace.Name.forEntry(node.event));
+    }
+    return parts.join(' – ');
   }
 
   /**
@@ -206,7 +212,7 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
   override async getSuggestions(): Promise<[ConversationSuggestion, ...ConversationSuggestion[]]|undefined> {
     const focus = this.#focus.data;
 
-    if (focus.type !== 'insight') {
+    if (!focus.insight) {
       return;
     }
 
@@ -217,30 +223,16 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
 // 16k Tokens * ~4 char per token.
 const MAX_FUNCTION_RESULT_BYTE_LENGTH = 16384 * 4;
 
-/**
- * Union of all the performance conversation types, which are all implemented by this file.
- * This temporary until all Performance Panel AI features use the "Full" type. go/chrome-devtools:more-powerful-performance-agent-design
- */
-type PerformanceConversationType =
-    ConversationType.PERFORMANCE_FULL|ConversationType.PERFORMANCE_CALL_TREE|ConversationType.PERFORMANCE_INSIGHT;
-
 /**
  * One agent instance handles one conversation. Create a new agent
  * instance for a new conversation.
  */
 export class PerformanceAgent extends AiAgent<AgentFocus> {
-  // TODO: would make more sense on AgentOptions
-  #conversationType: PerformanceConversationType;
   #formatter: PerformanceTraceFormatter|null = null;
   #lastInsightForEnhancedQuery: Trace.Insights.Types.InsightModel|undefined;
   #eventsSerializer = new Trace.EventsSerializer.EventsSerializer();
   #lastFocusHandledForContextDetails: AgentFocus|null = null;
 
-  constructor(opts: AgentOptions, conversationType: PerformanceConversationType) {
-    super(opts);
-    this.#conversationType = conversationType;
-  }
-
   /**
    * Cache of all function calls made by the agent. This allows us to include (as a
    * fact) every function call to conversation requests, allowing the AI to access
@@ -285,7 +277,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
   }
 
   getConversationType(): ConversationType {
-    return this.#conversationType;
+    return ConversationType.PERFORMANCE;
   }
 
   #lookupEvent(key: Trace.Types.File.SerializableKey): Trace.Types.Events.Event|null {
@@ -318,31 +310,16 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
     this.#lastFocusHandledForContextDetails = focus;
 
-    if (focus.data.type === 'full' || focus.data.type === 'insight') {
-      yield {
-        type: ResponseType.CONTEXT,
-        title: lockedString(UIStringsNotTranslated.analyzingTrace),
-        details: [
-          {
-            title: 'Trace',
-            text: this.#formatter?.formatTraceSummary() ?? '',
-          },
-        ],
-      };
-    } else if (focus.data.type === 'call-tree') {
-      yield {
-        type: ResponseType.CONTEXT,
-        title: lockedString(UIStringsNotTranslated.analyzingCallTree),
-        details: [
-          {
-            title: 'Selected call tree',
-            text: focus.data.callTree.serialize(),
-          },
-        ],
-      };
-    } else {
-      Platform.assertNever(focus.data, 'Unknown agent focus');
-    }
+    yield {
+      type: ResponseType.CONTEXT,
+      title: lockedString(UIStringsNotTranslated.analyzingTrace),
+      details: [
+        {
+          title: 'Trace',
+          text: this.#formatter?.formatTraceSummary() ?? '',
+        },
+      ],
+    };
   }
 
   #callTreeContextSet = new WeakSet();
@@ -378,12 +355,9 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
     this.#declareFunctions(context);
 
     const focus = context.getItem();
+    const selected: string[] = [];
 
-    if (focus.data.type === 'full') {
-      return query;
-    }
-
-    if (focus.data.type === 'call-tree') {
+    if (focus.data.callTree) {
       // If this is a followup chat about the same call tree, don't include the call tree serialization again.
       // We don't need to repeat it and we'd rather have more the context window space.
       let contextString = '';
@@ -392,17 +366,12 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
         this.#callTreeContextSet.add(focus.data.callTree);
       }
 
-      if (!contextString) {
-        return query;
+      if (contextString) {
+        selected.push(`User selected the following call tree:\n\n${contextString}\n\n`);
       }
-
-      let enhancedQuery = '';
-      enhancedQuery += `User selected the following call tree:\n\n${contextString}\n\n`;
-      enhancedQuery += `# User query\n\n${query}`;
-      return enhancedQuery;
     }
 
-    if (focus.data.type === 'insight') {
+    if (focus.data.insight) {
       // We only need to add Insight info to a prompt when the context changes. For example:
       // User clicks Insight A. We need to send info on Insight A with the prompt.
       // User asks follow up question. We do not need to resend Insight A with the prompt.
@@ -411,17 +380,17 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       const includeInsightInfo = focus.data.insight !== this.#lastInsightForEnhancedQuery;
       this.#lastInsightForEnhancedQuery = focus.data.insight;
 
-      if (!includeInsightInfo) {
-        return query;
+      if (includeInsightInfo) {
+        selected.push(`User selected the ${focus.data.insight.insightKey} insight.\n\n`);
       }
+    }
 
-      let enhancedQuery = '';
-      enhancedQuery += `User selected the ${focus.data.insight.insightKey} insight.\n\n`;
-      enhancedQuery += `# User query\n\n${query}`;
-      return enhancedQuery;
+    if (!selected.length) {
+      return query;
     }
 
-    Platform.assertNever(focus.data, 'Unknown agent focus');
+    selected.push(`# User query\n\n${query}`);
+    return selected.join('');
   }
 
   override async * run(initialQuery: string, options: {