Move the expand option to UI.UIUtils.Renderer

Bug: 407751692
Change-Id: Iafc903ce041916dad214e33ce111ddb692c1b79d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6897970
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>

Author: OrKoN

front_end/models/extensions/ExtensionPanel.ts

@@ -218,15 +218,11 @@ export class ExtensionSidebarPane extends UI.View.SimpleView {
       return;
     }
     objectPropertiesView.element.removeChildren();
-    void UI.UIUtils.Renderer.render(object, {title, editable: false}).then(result => {
+    void UI.UIUtils.Renderer.render(object, {title, editable: false, expand: true}).then(result => {
       if (!result) {
         callback();
         return;
       }
-      const firstChild = result.tree?.firstChild();
-      if (firstChild) {
-        firstChild.expand();
-      }
       objectPropertiesView.element.appendChild(result.node);
       callback();
     });

front_end/panels/console/ConsoleViewMessage.ts

@@ -943,7 +943,7 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
         result.appendChild(this.formatParameterAsObject(remoteObject, false));
         return;
       }
-      const renderResult = await UI.UIUtils.Renderer.render((node as Object));
+      const renderResult = await UI.UIUtils.Renderer.render(node);
       if (renderResult) {
         if (renderResult.tree) {
           this.selectableChildren.push(renderResult.tree);

front_end/panels/elements/ElementsTreeOutlineRenderer.ts

@@ -50,7 +50,7 @@ export class Renderer implements UI.UIUtils.Renderer {
     return rendererInstance;
   }
 
-  async render(object: Object): Promise<{
+  async render(object: Object, options?: UI.UIUtils.Options): Promise<{
     node: Node,
     tree: UI.TreeOutline.TreeOutline|null,
   }|null> {
@@ -75,6 +75,9 @@ export class Renderer implements UI.UIUtils.Renderer {
     // @ts-expect-error used in console_test_runner
     treeOutline.element.treeElementForTest = treeOutline.firstChild();
     treeOutline.setShowSelectionOnKeyboardFocus(/* show: */ true, /* preventTabOrder: */ true);
+    if (options?.expand) {
+      treeOutline.firstChild()?.expand();
+    }
     return {node: treeOutline.element, tree: treeOutline};
   }
 }

front_end/ui/legacy/UIUtils.ts

@@ -1812,6 +1812,10 @@ export function formatTimestamp(timestamp: number, full: boolean): string {
 export interface Options {
   title?: string|Element;
   editable?: boolean;
+  /**
+   * Should the resulting object be expanded.
+   */
+  expand?: boolean;
 }
 
 export interface HighlightChange {

front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts

@@ -1659,6 +1659,9 @@ export class Renderer implements UI.UIUtils.Renderer {
       section.titleLessMode();
     }
     section.editable = Boolean(options.editable);
+    if (options.expand) {
+      section.firstChild()?.expand();
+    }
     return {node: section.element, tree: section} as {
       node: Node,
       tree: UI.TreeOutline.TreeOutline | null,