[cleanup] Fix Types in RemoteObject

Removes unnesisery type casting, `internal` suffix.
No type code changes marked by comments

Bug: none
Change-Id: Ia7397d76c64ab9c319dda8b586478f077e8edaa2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439211
Reviewed-by: Benedikt Meurer <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

extensions/cxx_debugging/src/CustomFormatters.ts

@@ -346,13 +346,13 @@ export class CXXValue implements Value, LazyObject {
     if (this.type.hasValue && this.type.arraySize === 0) {
       const formatter = CustomFormatters.get(this.type);
       if (!formatter) {
-        const type = 'undefined' as Chrome.DevTools.RemoteObjectType;
+        const type = 'undefined';
         const description = '<not displayable>';
         return {type, description, hasChildren: false};
       }
 
       if (this.location === undefined || (!this.data && this.location === 0xffffffff)) {
-        const type = 'undefined' as Chrome.DevTools.RemoteObjectType;
+        const type = 'undefined';
         const description = '<optimized out>';
         return {type, description, hasChildren: false};
       }
@@ -369,7 +369,7 @@ export class CXXValue implements Value, LazyObject {
       }
     }
 
-    const type = (this.type.arraySize > 0 ? 'array' : 'object') as Chrome.DevTools.RemoteObjectType;
+    const type = this.type.arraySize > 0 ? 'array' : 'object';
     const {objectId} = this;
     return {
       type,

extensions/cxx_debugging/tests/TestUtils.ts

@@ -67,7 +67,7 @@ export function relativePathname(url: URL, base: URL): string {
 
 export function nonNull<T>(value: T|null|undefined): T {
   assert.exists(value);
-  return value as T;
+  return value;
 }
 
 export function remoteObject(value: Chrome.DevTools.RemoteObject|Chrome.DevTools.ForeignObject|null):
@@ -226,7 +226,7 @@ export class TestValue implements Value {
     if (typeof member === 'number' || !member.includes('.')) {
       return this.members[member];
     }
-    let value = this as Value;
+    let value: Value = this;
     for (const prop of member.split('.')) {
       value = value.$(prop);
     }

front_end/core/i18n/DevToolsLocale.ts

@@ -60,7 +60,7 @@ export class DevToolsLocale {
   }
 
   forceFallbackLocale(): void {
-    // Locale is 'readonly', this is the only case where we want to forceably
+    // Locale is 'readonly', this is the only case where we want to forcibly
     // overwrite the locale.
     (this.locale as unknown) = 'en-US';
   }

front_end/core/sdk/DOMModel.ts

@@ -405,7 +405,7 @@ export class DOMNode {
       return null;
     }
 
-    let current: (DOMNode|null) = (this as DOMNode | null);
+    let current: DOMNode|null = this;
     while (current && !current.isShadowRoot()) {
       current = current.parentNode;
     }
@@ -603,7 +603,7 @@ export class DOMNode {
     }
 
     const path = [];
-    let node: (DOMNode|null) = (this as DOMNode | null);
+    let node: (DOMNode|null) = this;
     while (node) {
       const key = getNodeKey(node);
       if (key === null) {
@@ -838,22 +838,22 @@ export class DOMNode {
       }
 
       this.#markers.delete(name);
-      for (let node: (DOMNode|null) = (this as DOMNode | null); node; node = node.parentNode) {
+      for (let node: (DOMNode|null) = this; node; node = node.parentNode) {
         --node.#subtreeMarkerCount;
       }
-      for (let node: (DOMNode|null) = (this as DOMNode | null); node; node = node.parentNode) {
+      for (let node: (DOMNode|null) = this; node; node = node.parentNode) {
         this.#domModelInternal.dispatchEventToListeners(Events.MarkersChanged, node);
       }
       return;
     }
 
     if (this.parentNode && !this.#markers.has(name)) {
-      for (let node: (DOMNode|null) = (this as DOMNode | null); node; node = node.parentNode) {
+      for (let node: (DOMNode|null) = this; node; node = node.parentNode) {
         ++node.#subtreeMarkerCount;
       }
     }
     this.#markers.set(name, value);
-    for (let node: (DOMNode|null) = (this as DOMNode | null); node; node = node.parentNode) {
+    for (let node: (DOMNode|null) = this; node; node = node.parentNode) {
       this.#domModelInternal.dispatchEventToListeners(Events.MarkersChanged, node);
     }
   }
@@ -888,7 +888,7 @@ export class DOMNode {
     if (!url) {
       return url as Platform.DevToolsPath.UrlString;
     }
-    for (let frameOwnerCandidate: (DOMNode|null) = (this as DOMNode | null); frameOwnerCandidate;
+    for (let frameOwnerCandidate: (DOMNode|null) = this; frameOwnerCandidate;
          frameOwnerCandidate = frameOwnerCandidate.parentNode) {
       if (frameOwnerCandidate instanceof DOMDocument && frameOwnerCandidate.baseURL) {
         return Common.ParsedURL.ParsedURL.completeURL(frameOwnerCandidate.baseURL, url);
@@ -941,7 +941,7 @@ export class DOMNode {
   }
 
   enclosingElementOrSelf(): DOMNode|null {
-    let node: DOMNode|null|(DOMNode | null) = (this as DOMNode | null);
+    let node: DOMNode|null = this;
     if (node && node.nodeType() === Node.TEXT_NODE && node.parentNode) {
       node = node.parentNode;
     }