Clear report onPrimaryPageChanged

When a user navigates from site a.com to b.com, they should not see
the 3pc issues from a.com still.

Bug: 365737493
Change-Id: Iba1eb0b929318550143a5c06412805bbd8d020d8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6039196
Commit-Queue: Joshua Thomas <[email protected]>
Reviewed-by: Kim-Anh Tran <[email protected]>
Reviewed-by: Shuran Huang <[email protected]>

Author: masnoble

front_end/panels/security/CookieReportView.test.ts

@@ -2,10 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import type * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
 import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
 import {createFakeSetting, createTarget} from '../../testing/EnvironmentHelpers.js';
 import {describeWithMockConnection} from '../../testing/MockConnection.js';
+import {getMainFrame, navigate} from '../../testing/ResourceTreeHelpers.js';
 
 import * as Security from './security.js';
 
@@ -37,10 +39,11 @@ function getTestCookieIssue(
 
 describeWithMockConnection('CookieReportView', () => {
   let mockView: sinon.SinonStub;
+  let target: SDK.Target.Target;
 
   beforeEach(() => {
     mockView = sinon.stub();
-    createTarget();
+    target = createTarget();
     const showThirdPartyIssuesSetting = createFakeSetting('third party flag', true);
     IssuesManager.IssuesManager.IssuesManager.instance({
       forceNew: false,
@@ -136,4 +139,19 @@ describeWithMockConnection('CookieReportView', () => {
     await view.pendingUpdate();
     assert.strictEqual(view.gridData.length, 1);
   });
+
+  it('should have zero entries after the primary page was changed', async () => {
+    const view = new Security.CookieReportView.CookieReportView(undefined, mockView);
+
+    // @ts-ignore
+    globalThis.addIssueForTest(getTestCookieIssue(true));
+
+    await view.pendingUpdate();
+    assert.strictEqual(view.gridData.length, 1);
+
+    navigate(getMainFrame(target));
+
+    await view.pendingUpdate();
+    assert.strictEqual(view.gridData.length, 0);
+  });
 });

front_end/panels/security/CookieReportView.ts

@@ -4,6 +4,7 @@
 
 import type * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as SDK from '../../core/sdk/sdk.js';
 import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
 import * as DataGrid from '../../ui/legacy/components/data_grid/data_grid.js';
 import * as UI from '../../ui/legacy/legacy.js';
@@ -173,6 +174,10 @@ export class CookieReportView extends UI.Widget.VBox {
     super(true, undefined, element);
     this.#view = view;
 
+    SDK.TargetManager.TargetManager.instance().addModelListener(
+        SDK.ResourceTreeModel.ResourceTreeModel, SDK.ResourceTreeModel.Events.PrimaryPageChanged,
+        this.#onPrimaryPageChanged, this);
+
     this.#issuesManager = IssuesManager.IssuesManager.IssuesManager.instance();
     this.#issuesManager.addEventListener(
         IssuesManager.IssuesManager.Events.ISSUE_ADDED, this.#onIssueEventReceived, this);
@@ -198,6 +203,11 @@ export class CookieReportView extends UI.Widget.VBox {
     this.update();
   }
 
+  #onPrimaryPageChanged(): void {
+    this.#cookieRows.clear();
+    this.update();
+  }
+
   #onIssueEventReceived(event: Common.EventTarget.EventTargetEvent<IssuesManager.IssuesManager.IssueAddedEvent>): void {
     if (event.data.issue instanceof IssuesManager.CookieIssue.CookieIssue) {
       if (this.#cookieRows.has(event.data.issue.cookieId())) {