Revert "[test] Remove snapshot assertions"

This reverts commit 8b9f9ec.

Reason for revert: Lots of flakiness and tree closures: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/19772/overview

Original change's description:
> [test] Remove snapshot assertions
>
> Only used in recorder.
>
> Fixed: 402422819
> Change-Id: Ia3e20ecce7e1fbaf176e856289d628c8d22d8fa7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6345653
> Auto-Submit: Nikolay Vitkov <[email protected]>
> Reviewed-by: Alex Rudenko <[email protected]>
> Commit-Queue: Nikolay Vitkov <[email protected]>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iffc801ee90a6db66affc906fb35d3718fdb501b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346612
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>

Author: pfaffe

test/e2e/application/cookies_test.json

@@ -0,0 +1,20 @@
+{
+  "The Application Tab shows cookies even when navigating to an unreachable page (crbug.com/1047348) - 1": [
+    {
+      "name": "urlencoded",
+      "value": "Hello%2BWorld!"
+    },
+    {
+      "name": "__Host-foo3",
+      "value": "bar"
+    },
+    {
+      "name": "foo2",
+      "value": "bar"
+    },
+    {
+      "name": "foo",
+      "value": "bar"
+    }
+  ]
+}

test/e2e/recorder/helpers.ts

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {assert} from 'chai';
 import type {ElementHandle, Page} from 'puppeteer-core';
 
 import type {UserFlow} from '../../../front_end/panels/recorder/models/Schema.js';
@@ -20,6 +19,7 @@ import {
   waitFor,
   waitForAria,
 } from '../../../test/shared/helper.js';
+import {assertMatchesJSONSnapshot} from '../../../test/shared/snapshots.js';
 
 const RECORDER_CONTROLLER_TAG_NAME = 'devtools-recorder-controller';
 const TEST_RECORDING_NAME = 'New Recording';
@@ -96,10 +96,10 @@ async function createRecording(name: string, selectorAttribute?: string) {
 }
 
 export async function createAndStartRecording(
-    name?: string,
+    name: string,
     selectorAttribute?: string,
 ) {
-  await createRecording(name ?? TEST_RECORDING_NAME, selectorAttribute);
+  await createRecording(name, selectorAttribute);
   const onRecordingStarted = onRecordingStateChanged();
   await click('devtools-control-button');
   await waitFor('devtools-recording-view');
@@ -160,71 +160,31 @@ interface RecordingSnapshotOptions {
    * @defaultValue `false`
    */
   offsets?: boolean;
-  /**
-   * @defaultValue `true`
-   */
-  expectCommon?: boolean;
-  resource?: string;
 }
 
-export const processAndVerifyBaseRecording = (
+export const preprocessRecording = (
     recording: unknown,
     options: RecordingSnapshotOptions = {},
     ) => {
-  const {
-    offsets = false,
-    expectCommon = true,
-    resource = 'recorder/recorder.html',
-  } = options;
-
   let value = JSON.stringify(recording).replaceAll(
       `:${getTestServerPort()}`,
       ':<test-port>',
   );
   value = value.replaceAll('\u200b', '');
-  if (!offsets) {
+  if (!options.offsets) {
     value = value.replaceAll(
         /,?"(?:offsetY|offsetX)":[0-9]+(?:\.[0-9]+)?/g,
         '',
     );
   }
+  return JSON.parse(value.trim());
+};
 
-  const parsed = JSON.parse(value.trim());
-  if (expectCommon) {
-    assert.strictEqual(
-        parsed.title,
-        'New Recording',
-    );
-    delete parsed.title;
-    assert.deepEqual(
-        parsed.steps[0],
-        {
-          type: 'setViewport',
-          width: 1280,
-          height: 720,
-          deviceScaleFactor: 1,
-          isMobile: false,
-          hasTouch: false,
-          isLandscape: false
-        },
-    );
-    assert.deepEqual(
-        parsed.steps[1],
-        {
-          type: 'navigate',
-          url: `https://localhost:<test-port>/test/e2e/resources/${resource}`,
-          assertedEvents: [{
-            type: 'navigation',
-            url: `https://localhost:<test-port>/test/e2e/resources/${resource}`,
-            title: '',
-          }]
-        },
-    );
-
-    parsed.steps = parsed.steps.slice(2);
-  }
-
-  return parsed;
+export const assertRecordingMatchesSnapshot = (
+    recording: unknown,
+    options: RecordingSnapshotOptions = {},
+    ) => {
+  assertMatchesJSONSnapshot(preprocessRecording(recording, options));
 };
 
 async function setCode(flow: string) {
@@ -297,7 +257,7 @@ export async function setupRecorderWithScriptAndReplay(
   await onceFinished;
 }
 
-export async function getCurrentRecording() {
+export async function getCurrentRecording(): Promise<unknown> {
   const {frontend} = getBrowserAndPages();
   await frontend.bringToFront();
   const controller = await $(RECORDER_CONTROLLER_TAG_NAME);