Skip to content

Commit 0a5cef1

Browse files
Liviu RauDevtools-frontend LUCI CQ
authored andcommitted
Used right default docking settings
Bug: 407460244 Change-Id: Ifcdda3cefd3cc71d8c7bb126473d663f61633ace Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6433949 Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Liviu Rau <[email protected]>
1 parent 382090d commit 0a5cef1

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

test/e2e_non_hosted/performance/selector-stats-tracing_test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ async function cssSelectorStatsRecording(testName: string, devToolsPage: DevTool
3333
await stopRecording(devToolsPage);
3434
}
3535

36-
describe('The Performance panel', function() {
36+
describe('The Performance panel', () => {
37+
setup({dockingMode: 'undocked'});
38+
3739
it('Can navigate to CSS file in source panel via available link in selector stats table',
3840
async ({devToolsPage, inspectedPage}) => {
3941
await cssSelectorStatsRecording('selectorStats/page-with-style', devToolsPage, inspectedPage);

test/e2e_non_hosted/shared/frontend-helper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ export const DEFAULT_DEVTOOLS_SETTINGS = {
270270
devToolsSettings: {
271271
isUnderTest: true,
272272
},
273-
dockingMode: 'undocked',
273+
dockingMode: 'right',
274274
};
275275

276276
export async function setupDevToolsPage(context: puppeteer.BrowserContext, settings: DevtoolsSettings) {

test/e2e_non_hosted/types.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ declare global {
2828
state: E2E.State;
2929
browser: BrowserWrapper;
3030
}
31+
32+
export interface HookFunction {
33+
(fn: E2E.SuiteSettings): void;
34+
}
3135
}
3236
namespace E2E {
3337
export type HarnessSettings = BrowserSettings&DevtoolsSettings;

0 commit comments

Comments
 (0)